From: Greg KH <gregkh@linuxfoundation.org>
To: Carlos Bilbao <bilbao@vt.edu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Matthew Wilcox <willy@infradead.org>,
Arnd Bergmann <arnd@arndb.de>, kbuild test robot <lkp@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
corbet@lwn.net, rdunlap@infradead.org, mchehab+huawei@kernel.org
Subject: Re: [PATCH v5] include: linux: Reorganize timekeeping and ktime headers
Date: Fri, 3 Dec 2021 14:28:40 +0100 [thread overview]
Message-ID: <YaobiAO2swGf3X3+@kroah.com> (raw)
In-Reply-To: <0ec6b0b3-0d59-ff68-13b3-c9798f3ac6c6@vt.edu>
On Wed, Dec 01, 2021 at 10:22:21AM -0500, Carlos Bilbao wrote:
> On 11/16/21 5:11 PM, Carlos Bilbao wrote:
> > Reorganize and separate the headers by making ktime.h take care of the
> > ktime_get() family of functions, and reserve timekeeping.h for the actual
> > timekeeping. This also helps to avoid implicit function errors and strengthens
> > the header dependencies, since timekeeping.h was using ktime_to_ns(), a static
> > function defined in a header it does no include, ktime.h. Include the header
> > timekeeping.h wherever it is necessary for a successful compilation after the
> > header code reorganization.
> >
> > Signed-off-by: Carlos Bilbao <bilbao@vt.edu>
> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Reported-by: kernel test robot <lkp@intel.com>
> > ---
>
> Someone, look at me! What a lonely and solitary patch I am...
Yes it is, maybe the time maintainers will pick it up eventually if they
feel it is valid.
good luck!
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Carlos Bilbao <bilbao@vt.edu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Matthew Wilcox <willy@infradead.org>,
Arnd Bergmann <arnd@arndb.de>, kbuild test robot <lkp@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
corbet@lwn.net, rdunlap@infradead.org, mchehab+huawei@kernel.org
Subject: Re: [PATCH v5] include: linux: Reorganize timekeeping and ktime headers
Date: Fri, 3 Dec 2021 14:28:40 +0100 [thread overview]
Message-ID: <YaobiAO2swGf3X3+@kroah.com> (raw)
In-Reply-To: <0ec6b0b3-0d59-ff68-13b3-c9798f3ac6c6@vt.edu>
On Wed, Dec 01, 2021 at 10:22:21AM -0500, Carlos Bilbao wrote:
> On 11/16/21 5:11 PM, Carlos Bilbao wrote:
> > Reorganize and separate the headers by making ktime.h take care of the
> > ktime_get() family of functions, and reserve timekeeping.h for the actual
> > timekeeping. This also helps to avoid implicit function errors and strengthens
> > the header dependencies, since timekeeping.h was using ktime_to_ns(), a static
> > function defined in a header it does no include, ktime.h. Include the header
> > timekeeping.h wherever it is necessary for a successful compilation after the
> > header code reorganization.
> >
> > Signed-off-by: Carlos Bilbao <bilbao@vt.edu>
> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Reported-by: kernel test robot <lkp@intel.com>
> > ---
>
> Someone, look at me! What a lonely and solitary patch I am...
Yes it is, maybe the time maintainers will pick it up eventually if they
feel it is valid.
good luck!
greg k-h
next prev parent reply other threads:[~2021-12-03 13:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 19:30 arch/powerpc/kernel/time.c:801:5: error: no previous prototype for 'update_persistent_clock64' kernel test robot
2021-07-31 19:30 ` kernel test robot
2021-08-01 20:12 ` [PATCH v4.1] include: linux: Reorganize timekeeping and ktime headers Carlos Bilbao
2021-08-01 20:12 ` Carlos Bilbao
2021-08-01 20:12 ` Carlos Bilbao
2021-08-09 15:07 ` Geert Uytterhoeven
2021-08-09 15:07 ` Geert Uytterhoeven
2021-08-09 15:07 ` Geert Uytterhoeven
2021-08-09 16:39 ` Carlos Bilbao
2021-08-09 16:39 ` Carlos Bilbao
2021-08-09 16:39 ` Carlos Bilbao
2021-08-22 13:15 ` Carlos Bilbao
2021-08-22 13:15 ` Carlos Bilbao
2021-08-22 13:23 ` Greg KH
2021-08-22 13:23 ` Greg KH
2021-08-22 13:27 ` [PATCH v5] " Carlos Bilbao
2021-08-22 13:27 ` Carlos Bilbao
2021-09-12 15:33 ` Carlos Bilbao
2021-09-12 15:33 ` Carlos Bilbao
2021-11-03 19:33 ` Carlos Bilbao
2021-11-03 19:33 ` Carlos Bilbao
2021-11-04 6:21 ` Greg KH
2021-11-04 6:21 ` Greg KH
2021-11-16 22:11 ` Carlos Bilbao
2021-11-16 22:11 ` Carlos Bilbao
2021-11-16 22:11 ` Carlos Bilbao
2021-11-16 22:11 ` Carlos Bilbao
2021-12-01 15:22 ` Carlos Bilbao
2021-12-01 15:22 ` Carlos Bilbao
2021-12-03 13:28 ` Greg KH [this message]
2021-12-03 13:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaobiAO2swGf3X3+@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bilbao@vt.edu \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mchehab+huawei@kernel.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.