All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Milan Stevanovic <milan.stevanovic@se.com>,
	Jimmy Lalande <jimmy.lalande@se.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-renesas-soc@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Gareth Williams <gareth.williams.jx@renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Chris Brandt <Chris.Brandt@renesas.com>,
	Ralph Siemsen <ralph.siemsen@linaro.org>
Subject: Re: [PATCH v6 2/4] mtd: rawnand: renesas: Add new NAND controller driver
Date: Fri, 17 Dec 2021 22:37:24 +0100	[thread overview]
Message-ID: <Yb0DFEsjlScimzU2@kunai> (raw)
In-Reply-To: <20211217142033.353599-3-miquel.raynal@bootlin.com>


[-- Attachment #1.1: Type: text/plain, Size: 898 bytes --]

On Fri, Dec 17, 2021 at 03:20:31PM +0100, Miquel Raynal wrote:
> Introduce Renesas NAND controller driver which currently supports the
> following features on R-Car Gen3 and RZ/N1 SoCs:
> - All ONFI timing modes
> - Different configurations of its internal ECC controller
> - On-die (not tested) and software ECC support
> - Several chips (not tested)
> - Subpage accesses
> - DMA and PIO
> 
> This controller was originally provided by Evatronix before being bought
> by Cadence.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Tested-by: Ralph Siemsen <ralph.siemsen@linaro.org>

As I mentioned before, I can't test the driver and have no bandwidth for
a proper review. However, it looks really good from a glimpse and I
think we are in good shape for Gen3 additions if we need them somewhen.
So:

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Milan Stevanovic <milan.stevanovic@se.com>,
	Jimmy Lalande <jimmy.lalande@se.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-renesas-soc@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Gareth Williams <gareth.williams.jx@renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Chris Brandt <Chris.Brandt@renesas.com>,
	Ralph Siemsen <ralph.siemsen@linaro.org>
Subject: Re: [PATCH v6 2/4] mtd: rawnand: renesas: Add new NAND controller driver
Date: Fri, 17 Dec 2021 22:37:24 +0100	[thread overview]
Message-ID: <Yb0DFEsjlScimzU2@kunai> (raw)
In-Reply-To: <20211217142033.353599-3-miquel.raynal@bootlin.com>

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On Fri, Dec 17, 2021 at 03:20:31PM +0100, Miquel Raynal wrote:
> Introduce Renesas NAND controller driver which currently supports the
> following features on R-Car Gen3 and RZ/N1 SoCs:
> - All ONFI timing modes
> - Different configurations of its internal ECC controller
> - On-die (not tested) and software ECC support
> - Several chips (not tested)
> - Subpage accesses
> - DMA and PIO
> 
> This controller was originally provided by Evatronix before being bought
> by Cadence.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Tested-by: Ralph Siemsen <ralph.siemsen@linaro.org>

As I mentioned before, I can't test the driver and have no bandwidth for
a proper review. However, it looks really good from a glimpse and I
think we are in good shape for Gen3 additions if we need them somewhen.
So:

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-12-17 21:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 14:20 [PATCH v6 0/4] Renesas NAND controller support Miquel Raynal
2021-12-17 14:20 ` Miquel Raynal
2021-12-17 14:20 ` [PATCH v6 1/4] dt-bindings: mtd: renesas: Describe Renesas R-Car Gen3 & RZ/N1 NAND controller Miquel Raynal
2021-12-17 14:20   ` Miquel Raynal
2021-12-17 15:44   ` Geert Uytterhoeven
2021-12-17 15:44     ` Geert Uytterhoeven
2021-12-17 15:51     ` Miquel Raynal
2021-12-17 15:51       ` Miquel Raynal
2021-12-17 15:52       ` Geert Uytterhoeven
2021-12-17 15:52         ` Geert Uytterhoeven
2021-12-17 21:38   ` Wolfram Sang
2021-12-17 21:38     ` Wolfram Sang
2021-12-21 17:10   ` Miquel Raynal
2021-12-21 17:10     ` Miquel Raynal
2021-12-17 14:20 ` [PATCH v6 2/4] mtd: rawnand: renesas: Add new NAND controller driver Miquel Raynal
2021-12-17 14:20   ` Miquel Raynal
2021-12-17 21:37   ` Wolfram Sang [this message]
2021-12-17 21:37     ` Wolfram Sang
2021-12-21 17:10   ` Miquel Raynal
2021-12-21 17:10     ` Miquel Raynal
2021-12-17 14:20 ` [PATCH v6 3/4] MAINTAINERS: Add an entry for Renesas NAND controller Miquel Raynal
2021-12-17 14:20   ` Miquel Raynal
2021-12-17 21:34   ` Wolfram Sang
2021-12-17 21:34     ` Wolfram Sang
2021-12-21  9:16     ` Miquel Raynal
2021-12-21  9:16       ` Miquel Raynal
2021-12-21 17:10   ` Miquel Raynal
2021-12-21 17:10     ` Miquel Raynal
2021-12-17 14:20 ` [PATCH v6 4/4] ARM: dts: r9a06g032: Describe the " Miquel Raynal
2021-12-17 14:20   ` Miquel Raynal
2021-12-17 21:38   ` Wolfram Sang
2021-12-17 21:38     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yb0DFEsjlScimzU2@kunai \
    --to=wsa@kernel.org \
    --cc=Chris.Brandt@renesas.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gareth.williams.jx@renesas.com \
    --cc=geert@linux-m68k.org \
    --cc=jimmy.lalande@se.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=michael@walle.cc \
    --cc=milan.stevanovic@se.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.yadav@ti.com \
    --cc=phil.edworthy@renesas.com \
    --cc=ralph.siemsen@linaro.org \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.