Re: [Intel-gfx] [PATCH v6 10/11] drm/i915: Use to_gt() helper for GGTT accesses

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Andi Shyti <andi.shyti@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
	"Intel GFX" <intel-gfx@lists.freedesktop.org>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"DRI Devel" <dri-devel@lists.freedesktop.org>,
	"Chris Wilson" <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH v6 10/11] drm/i915: Use to_gt() helper for GGTT accesses
Date: Fri, 10 Dec 2021 04:11:01 +0200	[thread overview]
Message-ID: <YbK3FyffoS8jl+zM@intel.intel> (raw)
In-Reply-To: <20211210001858.GX2219399@mdroper-desk1.amr.corp.intel.com>

Hi Matt,

> > GGTT is currently available both through i915->ggtt and gt->ggtt, and we
> > eventually want to get rid of the i915->ggtt one.
> > Use to_gt() for all i915->ggtt accesses to help with the future
> > refactoring.
> 
> I think we can also convert the two references in i915_drm_suspend() and
> i915_drm_resume(), right?  With those converted, I think the only
> remaining use of i915->ggtt will be the call to intel_gt_init_hw_early()
> during startup that assigns the gt->ggtt pointer.  Maybe we should just
> make that function assign a drmm_kzalloc() and drop the i915->ggtt
> completely?

I think calling directly drmm_kzalloc() and get rid of i915->ggtt
is a good idea.

Thanks,
Andi

WARNING: multiple messages have this Message-ID (diff)

From: Andi Shyti <andi.shyti@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
	"Andi Shyti" <andi@etezian.org>,
	"Intel GFX" <intel-gfx@lists.freedesktop.org>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"DRI Devel" <dri-devel@lists.freedesktop.org>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Andi Shyti" <andi.shyti@linux.intel.com>
Subject: Re: [PATCH v6 10/11] drm/i915: Use to_gt() helper for GGTT accesses
Date: Fri, 10 Dec 2021 04:11:01 +0200	[thread overview]
Message-ID: <YbK3FyffoS8jl+zM@intel.intel> (raw)
In-Reply-To: <20211210001858.GX2219399@mdroper-desk1.amr.corp.intel.com>

Hi Matt,

> > GGTT is currently available both through i915->ggtt and gt->ggtt, and we
> > eventually want to get rid of the i915->ggtt one.
> > Use to_gt() for all i915->ggtt accesses to help with the future
> > refactoring.
> 
> I think we can also convert the two references in i915_drm_suspend() and
> i915_drm_resume(), right?  With those converted, I think the only
> remaining use of i915->ggtt will be the call to intel_gt_init_hw_early()
> during startup that assigns the gt->ggtt pointer.  Maybe we should just
> make that function assign a drmm_kzalloc() and drop the i915->ggtt
> completely?

I think calling directly drmm_kzalloc() and get rid of i915->ggtt
is a good idea.

Thanks,
Andi

next prev parent reply	other threads:[~2021-12-10  2:11 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 13:25 [Intel-gfx] [PATCH v6 00/11] More preparation for multi gt patches Andi Shyti
2021-12-09 13:25 ` Andi Shyti
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 01/11] drm/i915: Store backpointer to GT in uncore Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-09 17:06   ` [Intel-gfx] " Jani Nikula
2021-12-09 17:26     ` Andi Shyti
2021-12-09 17:26       ` Andi Shyti
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 02/11] drm/i915: Introduce to_gt() helper Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-09 23:00   ` [Intel-gfx] " Matt Roper
2021-12-09 23:00     ` Matt Roper
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 03/11] drm/i915/display: Use " Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-09 23:03   ` [Intel-gfx] " Matt Roper
2021-12-09 23:03     ` Matt Roper
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 04/11] drm/i915/gt: " Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-09 23:33   ` [Intel-gfx] " Matt Roper
2021-12-09 23:33     ` Matt Roper
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 05/11] drm/i915/gem: " Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-09 23:50   ` [Intel-gfx] " Matt Roper
2021-12-09 23:50     ` Matt Roper
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 06/11] drm/i915/gvt: " Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-09 23:51   ` [Intel-gfx] " Matt Roper
2021-12-09 23:51     ` Matt Roper
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 07/11] drm/i915/selftests: " Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-09 23:55   ` [Intel-gfx] " Matt Roper
2021-12-09 23:55     ` Matt Roper
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 08/11] drm/i915/pxp: " Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-09 23:59   ` [Intel-gfx] " Matt Roper
2021-12-09 23:59     ` Matt Roper
2021-12-10  0:21     ` [Intel-gfx] " Andi Shyti
2021-12-10  0:21       ` Andi Shyti
2021-12-10  0:22       ` [Intel-gfx] " Matt Roper
2021-12-10  0:22         ` Matt Roper
2021-12-10  1:07   ` [Intel-gfx] [PATCH v7 " Andi Shyti
2021-12-10  1:07     ` Andi Shyti
2021-12-10 15:27     ` [Intel-gfx] " Matt Roper
2021-12-10 15:27       ` Matt Roper
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 09/11] drm/i915: " Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-10  0:02   ` [Intel-gfx] " Matt Roper
2021-12-10  0:02     ` Matt Roper
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 10/11] drm/i915: Use to_gt() helper for GGTT accesses Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-10  0:18   ` [Intel-gfx] " Matt Roper
2021-12-10  0:18     ` Matt Roper
2021-12-10  2:11     ` Andi Shyti [this message]
2021-12-10  2:11       ` Andi Shyti
2021-12-09 13:25 ` [Intel-gfx] [PATCH v6 11/11] drm/i915: Rename i915->gt to i915->gt0 Andi Shyti
2021-12-09 13:25   ` Andi Shyti
2021-12-10  0:19   ` [Intel-gfx] " Matt Roper
2021-12-10  0:19     ` Matt Roper
2021-12-10 10:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More preparation for multi gt patches (rev7) Patchwork
2021-12-10 10:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-12-10 10:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-11  3:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbK3FyffoS8jl+zM@intel.intel \
    --to=andi.shyti@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=michal.winiarski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.