From: Tzung-Bi Shih <tzungbi@google.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com,
mchehab@kernel.org, matthias.bgg@gmail.com,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: mtk-vcodec: potential dereference of null pointer
Date: Wed, 15 Dec 2021 13:55:47 +0800 [thread overview]
Message-ID: <YbmDY9PbQUlHgyPF@google.com> (raw)
In-Reply-To: <20211215052157.94172-1-jiasheng@iscas.ac.cn>
On Wed, Dec 15, 2021 at 01:21:57PM +0800, Jiasheng Jiang wrote:
> The return value of devm_kzalloc() needs to be checked.
> To avoid use of null pointer in case of thefailure of alloc.
>
> Fixes: 46233e91fa24 ("media: mtk-vcodec: move firmware implementations into their own files")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
With a nit:
s/thefailure/the failure/
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com,
mchehab@kernel.org, matthias.bgg@gmail.com,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: mtk-vcodec: potential dereference of null pointer
Date: Wed, 15 Dec 2021 13:55:47 +0800 [thread overview]
Message-ID: <YbmDY9PbQUlHgyPF@google.com> (raw)
In-Reply-To: <20211215052157.94172-1-jiasheng@iscas.ac.cn>
On Wed, Dec 15, 2021 at 01:21:57PM +0800, Jiasheng Jiang wrote:
> The return value of devm_kzalloc() needs to be checked.
> To avoid use of null pointer in case of thefailure of alloc.
>
> Fixes: 46233e91fa24 ("media: mtk-vcodec: move firmware implementations into their own files")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
With a nit:
s/thefailure/the failure/
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com,
mchehab@kernel.org, matthias.bgg@gmail.com,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: mtk-vcodec: potential dereference of null pointer
Date: Wed, 15 Dec 2021 13:55:47 +0800 [thread overview]
Message-ID: <YbmDY9PbQUlHgyPF@google.com> (raw)
In-Reply-To: <20211215052157.94172-1-jiasheng@iscas.ac.cn>
On Wed, Dec 15, 2021 at 01:21:57PM +0800, Jiasheng Jiang wrote:
> The return value of devm_kzalloc() needs to be checked.
> To avoid use of null pointer in case of thefailure of alloc.
>
> Fixes: 46233e91fa24 ("media: mtk-vcodec: move firmware implementations into their own files")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
With a nit:
s/thefailure/the failure/
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
next prev parent reply other threads:[~2021-12-15 5:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 5:21 [PATCH v2] media: mtk-vcodec: potential dereference of null pointer Jiasheng Jiang
2021-12-15 5:21 ` Jiasheng Jiang
2021-12-15 5:21 ` Jiasheng Jiang
2021-12-15 5:55 ` Tzung-Bi Shih [this message]
2021-12-15 5:55 ` Tzung-Bi Shih
2021-12-15 5:55 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbmDY9PbQUlHgyPF@google.com \
--to=tzungbi@google.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.