* LTS "Warning: file conntrack_vrf.sh is not executable, correct this."
@ 2021-12-16 8:00 Rantala, Tommi T. (Nokia - FI/Espoo)
2021-12-16 8:07 ` gregkh
0 siblings, 1 reply; 4+ messages in thread
From: Rantala, Tommi T. (Nokia - FI/Espoo) @ 2021-12-16 8:00 UTC (permalink / raw)
To: gregkh@linuxfoundation.org, stable@vger.kernel.org
Cc: fw@strlen.de, linux-kernel@vger.kernel.org
Hi Greg,
Incorrect 0644 in LTS for new selftest file, seen in 5.4.165 since
"selftests: netfilter: add a vrf+conntrack testcase" was added to LTS.
It's correct 755 in upstream, but somehow messed up in LTS :-(
linux-5.4.y
===========
commit 8d3563ecbca3526fcc6639065c9fb11b2f234706
Author: Florian Westphal <fw@strlen.de>
Date: Mon Oct 18 14:38:13 2021 +0200
selftests: netfilter: add a vrf+conntrack testcase
commit 33b8aad21ac175eba9577a73eb62b0aa141c241c upstream.
[...]
diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
new file mode 100644 <----------------
linux-5.15.y
============
commit cffab968e94e513bdcef25e11402243ce2919803
[...]
new file mode 100644 <----------------
upstream
========
$ git show 33b8aad21ac175eba9577a73eb62b0aa141c241c
commit 33b8aad21ac175eba9577a73eb62b0aa141c241c
Author: Florian Westphal <fw@strlen.de>
Date: Mon Oct 18 14:38:13 2021 +0200
selftests: netfilter: add a vrf+conntrack testcase
[...]
diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
new file mode 100755 <-----------------------
-Tommi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: LTS "Warning: file conntrack_vrf.sh is not executable, correct this."
2021-12-16 8:00 LTS "Warning: file conntrack_vrf.sh is not executable, correct this." Rantala, Tommi T. (Nokia - FI/Espoo)
@ 2021-12-16 8:07 ` gregkh
2021-12-16 8:13 ` gregkh
0 siblings, 1 reply; 4+ messages in thread
From: gregkh @ 2021-12-16 8:07 UTC (permalink / raw)
To: Rantala, Tommi T. (Nokia - FI/Espoo)
Cc: stable@vger.kernel.org, fw@strlen.de,
linux-kernel@vger.kernel.org
On Thu, Dec 16, 2021 at 08:00:30AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
> Hi Greg,
>
> Incorrect 0644 in LTS for new selftest file, seen in 5.4.165 since
> "selftests: netfilter: add a vrf+conntrack testcase" was added to LTS.
> It's correct 755 in upstream, but somehow messed up in LTS :-(
That is because quilt/git can not set modes of files.
> linux-5.4.y
> ===========
> commit 8d3563ecbca3526fcc6639065c9fb11b2f234706
> Author: Florian Westphal <fw@strlen.de>
> Date: Mon Oct 18 14:38:13 2021 +0200
>
> selftests: netfilter: add a vrf+conntrack testcase
>
> commit 33b8aad21ac175eba9577a73eb62b0aa141c241c upstream.
>
> [...]
> diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
> new file mode 100644 <----------------
>
>
> linux-5.15.y
> ============
> commit cffab968e94e513bdcef25e11402243ce2919803
> [...]
> new file mode 100644 <----------------
>
>
> upstream
> ========
> $ git show 33b8aad21ac175eba9577a73eb62b0aa141c241c
>
> commit 33b8aad21ac175eba9577a73eb62b0aa141c241c
> Author: Florian Westphal <fw@strlen.de>
> Date: Mon Oct 18 14:38:13 2021 +0200
>
> selftests: netfilter: add a vrf+conntrack testcase
>
> [...]
> diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
> new file mode 100755 <-----------------------
>
>
> -Tommi
>
What about the 5.10.y tree? Does it need this change as well?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: LTS "Warning: file conntrack_vrf.sh is not executable, correct this."
2021-12-16 8:07 ` gregkh
@ 2021-12-16 8:13 ` gregkh
2021-12-17 6:38 ` gregkh
0 siblings, 1 reply; 4+ messages in thread
From: gregkh @ 2021-12-16 8:13 UTC (permalink / raw)
To: Rantala, Tommi T. (Nokia - FI/Espoo)
Cc: stable@vger.kernel.org, fw@strlen.de,
linux-kernel@vger.kernel.org
On Thu, Dec 16, 2021 at 09:07:13AM +0100, gregkh@linuxfoundation.org wrote:
> On Thu, Dec 16, 2021 at 08:00:30AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
> > Hi Greg,
> >
> > Incorrect 0644 in LTS for new selftest file, seen in 5.4.165 since
> > "selftests: netfilter: add a vrf+conntrack testcase" was added to LTS.
> > It's correct 755 in upstream, but somehow messed up in LTS :-(
>
> That is because quilt/git can not set modes of files.
>
> > linux-5.4.y
> > ===========
> > commit 8d3563ecbca3526fcc6639065c9fb11b2f234706
> > Author: Florian Westphal <fw@strlen.de>
> > Date: Mon Oct 18 14:38:13 2021 +0200
> >
> > selftests: netfilter: add a vrf+conntrack testcase
> >
> > commit 33b8aad21ac175eba9577a73eb62b0aa141c241c upstream.
> >
> > [...]
> > diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
> > new file mode 100644 <----------------
> >
> >
> > linux-5.15.y
> > ============
> > commit cffab968e94e513bdcef25e11402243ce2919803
> > [...]
> > new file mode 100644 <----------------
> >
> >
> > upstream
> > ========
> > $ git show 33b8aad21ac175eba9577a73eb62b0aa141c241c
> >
> > commit 33b8aad21ac175eba9577a73eb62b0aa141c241c
> > Author: Florian Westphal <fw@strlen.de>
> > Date: Mon Oct 18 14:38:13 2021 +0200
> >
> > selftests: netfilter: add a vrf+conntrack testcase
> >
> > [...]
> > diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
> > new file mode 100755 <-----------------------
> >
> >
> > -Tommi
> >
>
> What about the 5.10.y tree? Does it need this change as well?
To answer my own question, yes, it is an issue there too. I'll go do a
release right now with the mode changed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: LTS "Warning: file conntrack_vrf.sh is not executable, correct this."
2021-12-16 8:13 ` gregkh
@ 2021-12-17 6:38 ` gregkh
0 siblings, 0 replies; 4+ messages in thread
From: gregkh @ 2021-12-17 6:38 UTC (permalink / raw)
To: Rantala, Tommi T. (Nokia - FI/Espoo)
Cc: stable@vger.kernel.org, fw@strlen.de,
linux-kernel@vger.kernel.org
On Thu, Dec 16, 2021 at 09:13:38AM +0100, gregkh@linuxfoundation.org wrote:
> On Thu, Dec 16, 2021 at 09:07:13AM +0100, gregkh@linuxfoundation.org wrote:
> > On Thu, Dec 16, 2021 at 08:00:30AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
> > > Hi Greg,
> > >
> > > Incorrect 0644 in LTS for new selftest file, seen in 5.4.165 since
> > > "selftests: netfilter: add a vrf+conntrack testcase" was added to LTS.
> > > It's correct 755 in upstream, but somehow messed up in LTS :-(
> >
> > That is because quilt/git can not set modes of files.
> >
> > > linux-5.4.y
> > > ===========
> > > commit 8d3563ecbca3526fcc6639065c9fb11b2f234706
> > > Author: Florian Westphal <fw@strlen.de>
> > > Date: Mon Oct 18 14:38:13 2021 +0200
> > >
> > > selftests: netfilter: add a vrf+conntrack testcase
> > >
> > > commit 33b8aad21ac175eba9577a73eb62b0aa141c241c upstream.
> > >
> > > [...]
> > > diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
> > > new file mode 100644 <----------------
> > >
> > >
> > > linux-5.15.y
> > > ============
> > > commit cffab968e94e513bdcef25e11402243ce2919803
> > > [...]
> > > new file mode 100644 <----------------
> > >
> > >
> > > upstream
> > > ========
> > > $ git show 33b8aad21ac175eba9577a73eb62b0aa141c241c
> > >
> > > commit 33b8aad21ac175eba9577a73eb62b0aa141c241c
> > > Author: Florian Westphal <fw@strlen.de>
> > > Date: Mon Oct 18 14:38:13 2021 +0200
> > >
> > > selftests: netfilter: add a vrf+conntrack testcase
> > >
> > > [...]
> > > diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
> > > new file mode 100755 <-----------------------
> > >
> > >
> > > -Tommi
> > >
> >
> > What about the 5.10.y tree? Does it need this change as well?
>
> To answer my own question, yes, it is an issue there too. I'll go do a
> release right now with the mode changed.
This should now be fixed in the 3 kernel releases that went out
yesterday. Please let me know if you continue to see this problem.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-17 6:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-16 8:00 LTS "Warning: file conntrack_vrf.sh is not executable, correct this." Rantala, Tommi T. (Nokia - FI/Espoo)
2021-12-16 8:07 ` gregkh
2021-12-16 8:13 ` gregkh
2021-12-17 6:38 ` gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.