From: Tzung-Bi Shih <tzungbi@google.com>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
tiwai@suse.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org,
shumingf@realtek.com, broonie@kernel.org,
linux-mediatek@lists.infradead.org, jiaxin.yu@mediatek.com,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8195: update control for RT5682 series
Date: Thu, 16 Dec 2021 13:02:47 +0800 [thread overview]
Message-ID: <YbrId5gnJSjeT1Ni@google.com> (raw)
In-Reply-To: <0b99c46f84c98c56e8fc99b2e103f52f756b5bf9.camel@mediatek.com>
On Thu, Dec 16, 2021 at 11:37:34AM +0800, Trevor Wu wrote:
> On Wed, 2021-12-15 at 16:20 +0800, Tzung-Bi Shih wrote:
> > On Wed, Dec 15, 2021 at 02:58:34PM +0800, Trevor Wu wrote:
> > > @@ -1072,6 +1119,19 @@ static int
> > > mt8195_mt6359_rt1011_rt5682_dev_probe(struct platform_device *pdev)
> > > return -EINVAL;
> > > }
> > >
> > > + priv->i2so1_mclk = devm_clk_get(&pdev->dev, "i2so1_mclk");
> > > + if (IS_ERR(priv->i2so1_mclk)) {
> > > + ret = PTR_ERR(priv->i2so1_mclk);
> > > + if (ret == -ENOENT) {
> > > + dev_dbg(&pdev->dev,
> > > + "Failed to get i2so1_mclk, defer
> > > probe\n");
> > > + return -EPROBE_DEFER;
> > > + }
> >
> > Does devm_clk_get_optional() could make the block more concise?
>
> Even though we use devm_clk_get_optional, we still have to handle the
> (-ENOENT) case in probe function. In my opinion, original
> implementation could be kept.
I am neutral to my original suggestion but devm_clk_get_optional() returns NULL if -ENONENT.
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org,
matthias.bgg@gmail.com, alsa-devel@alsa-project.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
jiaxin.yu@mediatek.com, shumingf@realtek.com
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8195: update control for RT5682 series
Date: Thu, 16 Dec 2021 13:02:47 +0800 [thread overview]
Message-ID: <YbrId5gnJSjeT1Ni@google.com> (raw)
In-Reply-To: <0b99c46f84c98c56e8fc99b2e103f52f756b5bf9.camel@mediatek.com>
On Thu, Dec 16, 2021 at 11:37:34AM +0800, Trevor Wu wrote:
> On Wed, 2021-12-15 at 16:20 +0800, Tzung-Bi Shih wrote:
> > On Wed, Dec 15, 2021 at 02:58:34PM +0800, Trevor Wu wrote:
> > > @@ -1072,6 +1119,19 @@ static int
> > > mt8195_mt6359_rt1011_rt5682_dev_probe(struct platform_device *pdev)
> > > return -EINVAL;
> > > }
> > >
> > > + priv->i2so1_mclk = devm_clk_get(&pdev->dev, "i2so1_mclk");
> > > + if (IS_ERR(priv->i2so1_mclk)) {
> > > + ret = PTR_ERR(priv->i2so1_mclk);
> > > + if (ret == -ENOENT) {
> > > + dev_dbg(&pdev->dev,
> > > + "Failed to get i2so1_mclk, defer
> > > probe\n");
> > > + return -EPROBE_DEFER;
> > > + }
> >
> > Does devm_clk_get_optional() could make the block more concise?
>
> Even though we use devm_clk_get_optional, we still have to handle the
> (-ENOENT) case in probe function. In my opinion, original
> implementation could be kept.
I am neutral to my original suggestion but devm_clk_get_optional() returns NULL if -ENONENT.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org,
matthias.bgg@gmail.com, alsa-devel@alsa-project.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
jiaxin.yu@mediatek.com, shumingf@realtek.com
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8195: update control for RT5682 series
Date: Thu, 16 Dec 2021 13:02:47 +0800 [thread overview]
Message-ID: <YbrId5gnJSjeT1Ni@google.com> (raw)
In-Reply-To: <0b99c46f84c98c56e8fc99b2e103f52f756b5bf9.camel@mediatek.com>
On Thu, Dec 16, 2021 at 11:37:34AM +0800, Trevor Wu wrote:
> On Wed, 2021-12-15 at 16:20 +0800, Tzung-Bi Shih wrote:
> > On Wed, Dec 15, 2021 at 02:58:34PM +0800, Trevor Wu wrote:
> > > @@ -1072,6 +1119,19 @@ static int
> > > mt8195_mt6359_rt1011_rt5682_dev_probe(struct platform_device *pdev)
> > > return -EINVAL;
> > > }
> > >
> > > + priv->i2so1_mclk = devm_clk_get(&pdev->dev, "i2so1_mclk");
> > > + if (IS_ERR(priv->i2so1_mclk)) {
> > > + ret = PTR_ERR(priv->i2so1_mclk);
> > > + if (ret == -ENOENT) {
> > > + dev_dbg(&pdev->dev,
> > > + "Failed to get i2so1_mclk, defer
> > > probe\n");
> > > + return -EPROBE_DEFER;
> > > + }
> >
> > Does devm_clk_get_optional() could make the block more concise?
>
> Even though we use devm_clk_get_optional, we still have to handle the
> (-ENOENT) case in probe function. In my opinion, original
> implementation could be kept.
I am neutral to my original suggestion but devm_clk_get_optional() returns NULL if -ENONENT.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org,
matthias.bgg@gmail.com, alsa-devel@alsa-project.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
jiaxin.yu@mediatek.com, shumingf@realtek.com
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8195: update control for RT5682 series
Date: Thu, 16 Dec 2021 13:02:47 +0800 [thread overview]
Message-ID: <YbrId5gnJSjeT1Ni@google.com> (raw)
In-Reply-To: <0b99c46f84c98c56e8fc99b2e103f52f756b5bf9.camel@mediatek.com>
On Thu, Dec 16, 2021 at 11:37:34AM +0800, Trevor Wu wrote:
> On Wed, 2021-12-15 at 16:20 +0800, Tzung-Bi Shih wrote:
> > On Wed, Dec 15, 2021 at 02:58:34PM +0800, Trevor Wu wrote:
> > > @@ -1072,6 +1119,19 @@ static int
> > > mt8195_mt6359_rt1011_rt5682_dev_probe(struct platform_device *pdev)
> > > return -EINVAL;
> > > }
> > >
> > > + priv->i2so1_mclk = devm_clk_get(&pdev->dev, "i2so1_mclk");
> > > + if (IS_ERR(priv->i2so1_mclk)) {
> > > + ret = PTR_ERR(priv->i2so1_mclk);
> > > + if (ret == -ENOENT) {
> > > + dev_dbg(&pdev->dev,
> > > + "Failed to get i2so1_mclk, defer
> > > probe\n");
> > > + return -EPROBE_DEFER;
> > > + }
> >
> > Does devm_clk_get_optional() could make the block more concise?
>
> Even though we use devm_clk_get_optional, we still have to handle the
> (-ENOENT) case in probe function. In my opinion, original
> implementation could be kept.
I am neutral to my original suggestion but devm_clk_get_optional() returns NULL if -ENONENT.
next prev parent reply other threads:[~2021-12-16 5:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 6:58 [PATCH 1/2] ASoC: mediatek: mt8195: update control for RT5682 series Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` [PATCH 2/2] dt-bindings: mediatek: mt8195: add clock property to sound node Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-16 19:06 ` Rob Herring
2021-12-16 19:06 ` Rob Herring
2021-12-16 19:06 ` Rob Herring
2021-12-16 19:06 ` Rob Herring
2021-12-17 7:35 ` Trevor Wu
2021-12-17 7:35 ` Trevor Wu
2021-12-17 7:35 ` Trevor Wu
2021-12-17 7:35 ` Trevor Wu
2021-12-15 8:20 ` [PATCH 1/2] ASoC: mediatek: mt8195: update control for RT5682 series Tzung-Bi Shih
2021-12-15 8:20 ` Tzung-Bi Shih
2021-12-15 8:20 ` Tzung-Bi Shih
2021-12-15 8:20 ` Tzung-Bi Shih
2021-12-16 3:37 ` Trevor Wu
2021-12-16 3:37 ` Trevor Wu
2021-12-16 3:37 ` Trevor Wu
2021-12-16 3:37 ` Trevor Wu
2021-12-16 5:02 ` Tzung-Bi Shih [this message]
2021-12-16 5:02 ` Tzung-Bi Shih
2021-12-16 5:02 ` Tzung-Bi Shih
2021-12-16 5:02 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbrId5gnJSjeT1Ni@google.com \
--to=tzungbi@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.