From: Rob Herring <robh@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
tiwai@suse.com, jiaxin.yu@mediatek.com,
linux-kernel@vger.kernel.org, shumingf@realtek.com,
broonie@kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] dt-bindings: mediatek: mt8195: add clock property to sound node
Date: Thu, 16 Dec 2021 13:06:40 -0600 [thread overview]
Message-ID: <YbuOQOH3esG1pFQU@robh.at.kernel.org> (raw)
In-Reply-To: <20211215065835.3074-2-trevor.wu@mediatek.com>
On Wed, Dec 15, 2021 at 02:58:35PM +0800, Trevor Wu wrote:
> clocks and clock-names are added to provide MCLK phandle for sound card.
>
> Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
> ---
> .../bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml | 12 ++++++++++++
> .../bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml | 12 ++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> index cf6ad7933e23..b57c856d0cf3 100644
> --- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> @@ -32,11 +32,21 @@ properties:
> $ref: "/schemas/types.yaml#/definitions/phandle"
> description: The phandle of MT8195 HDMI codec node.
>
> + clocks:
> + items:
> + - description: phandle and clock specifier for codec MCLK.
> +
> + clock-names:
> + items:
> + - const: i2so1_mclk
> +
> additionalProperties: false
>
> required:
> - compatible
> - mediatek,platform
> + - clocks
> + - clock-names
>
> examples:
> - |
> @@ -44,6 +54,8 @@ examples:
> sound: mt8195-sound {
> compatible = "mediatek,mt8195_mt6359_rt1011_rt5682";
> mediatek,platform = <&afe>;
> + clocks = <&topckgen 235>; //CLK_TOP_APLL12_DIV2
> + clock-names = "i2so1_mclk";
> pinctrl-names = "default";
> pinctrl-0 = <&aud_pins_default>;
> };
> diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> index 8f177e02ad35..e4720f76f66b 100644
> --- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> @@ -42,11 +42,21 @@ properties:
> A list of the desired dai-links in the sound card. Each entry is a
> name defined in the machine driver.
>
> + clocks:
> + items:
> + - description: phandle and clock specifier for codec MCLK.
> +
> + clock-names:
> + items:
> + - const: i2so1_mclk
> +
> additionalProperties: false
>
> required:
> - compatible
> - mediatek,platform
> + - clocks
> + - clock-names
>
> examples:
> - |
> @@ -54,6 +64,8 @@ examples:
> sound: mt8195-sound {
> compatible = "mediatek,mt8195_mt6359_rt1019_rt5682";
> mediatek,platform = <&afe>;
> + clocks = <&topckgen 235>; //CLK_TOP_APLL12_DIV2
> + clock-names = "i2so1_mclk";
Being a virtual node, how does it have clocks? This belongs in the h/w
device that consumes the clock.
> pinctrl-names = "default";
> pinctrl-0 = <&aud_pins_default>;
> };
> --
> 2.18.0
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com,
alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
jiaxin.yu@mediatek.com, shumingf@realtek.com
Subject: Re: [PATCH 2/2] dt-bindings: mediatek: mt8195: add clock property to sound node
Date: Thu, 16 Dec 2021 13:06:40 -0600 [thread overview]
Message-ID: <YbuOQOH3esG1pFQU@robh.at.kernel.org> (raw)
In-Reply-To: <20211215065835.3074-2-trevor.wu@mediatek.com>
On Wed, Dec 15, 2021 at 02:58:35PM +0800, Trevor Wu wrote:
> clocks and clock-names are added to provide MCLK phandle for sound card.
>
> Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
> ---
> .../bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml | 12 ++++++++++++
> .../bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml | 12 ++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> index cf6ad7933e23..b57c856d0cf3 100644
> --- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> @@ -32,11 +32,21 @@ properties:
> $ref: "/schemas/types.yaml#/definitions/phandle"
> description: The phandle of MT8195 HDMI codec node.
>
> + clocks:
> + items:
> + - description: phandle and clock specifier for codec MCLK.
> +
> + clock-names:
> + items:
> + - const: i2so1_mclk
> +
> additionalProperties: false
>
> required:
> - compatible
> - mediatek,platform
> + - clocks
> + - clock-names
>
> examples:
> - |
> @@ -44,6 +54,8 @@ examples:
> sound: mt8195-sound {
> compatible = "mediatek,mt8195_mt6359_rt1011_rt5682";
> mediatek,platform = <&afe>;
> + clocks = <&topckgen 235>; //CLK_TOP_APLL12_DIV2
> + clock-names = "i2so1_mclk";
> pinctrl-names = "default";
> pinctrl-0 = <&aud_pins_default>;
> };
> diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> index 8f177e02ad35..e4720f76f66b 100644
> --- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> @@ -42,11 +42,21 @@ properties:
> A list of the desired dai-links in the sound card. Each entry is a
> name defined in the machine driver.
>
> + clocks:
> + items:
> + - description: phandle and clock specifier for codec MCLK.
> +
> + clock-names:
> + items:
> + - const: i2so1_mclk
> +
> additionalProperties: false
>
> required:
> - compatible
> - mediatek,platform
> + - clocks
> + - clock-names
>
> examples:
> - |
> @@ -54,6 +64,8 @@ examples:
> sound: mt8195-sound {
> compatible = "mediatek,mt8195_mt6359_rt1019_rt5682";
> mediatek,platform = <&afe>;
> + clocks = <&topckgen 235>; //CLK_TOP_APLL12_DIV2
> + clock-names = "i2so1_mclk";
Being a virtual node, how does it have clocks? This belongs in the h/w
device that consumes the clock.
> pinctrl-names = "default";
> pinctrl-0 = <&aud_pins_default>;
> };
> --
> 2.18.0
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com,
alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
jiaxin.yu@mediatek.com, shumingf@realtek.com
Subject: Re: [PATCH 2/2] dt-bindings: mediatek: mt8195: add clock property to sound node
Date: Thu, 16 Dec 2021 13:06:40 -0600 [thread overview]
Message-ID: <YbuOQOH3esG1pFQU@robh.at.kernel.org> (raw)
In-Reply-To: <20211215065835.3074-2-trevor.wu@mediatek.com>
On Wed, Dec 15, 2021 at 02:58:35PM +0800, Trevor Wu wrote:
> clocks and clock-names are added to provide MCLK phandle for sound card.
>
> Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
> ---
> .../bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml | 12 ++++++++++++
> .../bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml | 12 ++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> index cf6ad7933e23..b57c856d0cf3 100644
> --- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> @@ -32,11 +32,21 @@ properties:
> $ref: "/schemas/types.yaml#/definitions/phandle"
> description: The phandle of MT8195 HDMI codec node.
>
> + clocks:
> + items:
> + - description: phandle and clock specifier for codec MCLK.
> +
> + clock-names:
> + items:
> + - const: i2so1_mclk
> +
> additionalProperties: false
>
> required:
> - compatible
> - mediatek,platform
> + - clocks
> + - clock-names
>
> examples:
> - |
> @@ -44,6 +54,8 @@ examples:
> sound: mt8195-sound {
> compatible = "mediatek,mt8195_mt6359_rt1011_rt5682";
> mediatek,platform = <&afe>;
> + clocks = <&topckgen 235>; //CLK_TOP_APLL12_DIV2
> + clock-names = "i2so1_mclk";
> pinctrl-names = "default";
> pinctrl-0 = <&aud_pins_default>;
> };
> diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> index 8f177e02ad35..e4720f76f66b 100644
> --- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> @@ -42,11 +42,21 @@ properties:
> A list of the desired dai-links in the sound card. Each entry is a
> name defined in the machine driver.
>
> + clocks:
> + items:
> + - description: phandle and clock specifier for codec MCLK.
> +
> + clock-names:
> + items:
> + - const: i2so1_mclk
> +
> additionalProperties: false
>
> required:
> - compatible
> - mediatek,platform
> + - clocks
> + - clock-names
>
> examples:
> - |
> @@ -54,6 +64,8 @@ examples:
> sound: mt8195-sound {
> compatible = "mediatek,mt8195_mt6359_rt1019_rt5682";
> mediatek,platform = <&afe>;
> + clocks = <&topckgen 235>; //CLK_TOP_APLL12_DIV2
> + clock-names = "i2so1_mclk";
Being a virtual node, how does it have clocks? This belongs in the h/w
device that consumes the clock.
> pinctrl-names = "default";
> pinctrl-0 = <&aud_pins_default>;
> };
> --
> 2.18.0
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com,
alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
jiaxin.yu@mediatek.com, shumingf@realtek.com
Subject: Re: [PATCH 2/2] dt-bindings: mediatek: mt8195: add clock property to sound node
Date: Thu, 16 Dec 2021 13:06:40 -0600 [thread overview]
Message-ID: <YbuOQOH3esG1pFQU@robh.at.kernel.org> (raw)
In-Reply-To: <20211215065835.3074-2-trevor.wu@mediatek.com>
On Wed, Dec 15, 2021 at 02:58:35PM +0800, Trevor Wu wrote:
> clocks and clock-names are added to provide MCLK phandle for sound card.
>
> Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
> ---
> .../bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml | 12 ++++++++++++
> .../bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml | 12 ++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> index cf6ad7933e23..b57c856d0cf3 100644
> --- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
> @@ -32,11 +32,21 @@ properties:
> $ref: "/schemas/types.yaml#/definitions/phandle"
> description: The phandle of MT8195 HDMI codec node.
>
> + clocks:
> + items:
> + - description: phandle and clock specifier for codec MCLK.
> +
> + clock-names:
> + items:
> + - const: i2so1_mclk
> +
> additionalProperties: false
>
> required:
> - compatible
> - mediatek,platform
> + - clocks
> + - clock-names
>
> examples:
> - |
> @@ -44,6 +54,8 @@ examples:
> sound: mt8195-sound {
> compatible = "mediatek,mt8195_mt6359_rt1011_rt5682";
> mediatek,platform = <&afe>;
> + clocks = <&topckgen 235>; //CLK_TOP_APLL12_DIV2
> + clock-names = "i2so1_mclk";
> pinctrl-names = "default";
> pinctrl-0 = <&aud_pins_default>;
> };
> diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> index 8f177e02ad35..e4720f76f66b 100644
> --- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml
> @@ -42,11 +42,21 @@ properties:
> A list of the desired dai-links in the sound card. Each entry is a
> name defined in the machine driver.
>
> + clocks:
> + items:
> + - description: phandle and clock specifier for codec MCLK.
> +
> + clock-names:
> + items:
> + - const: i2so1_mclk
> +
> additionalProperties: false
>
> required:
> - compatible
> - mediatek,platform
> + - clocks
> + - clock-names
>
> examples:
> - |
> @@ -54,6 +64,8 @@ examples:
> sound: mt8195-sound {
> compatible = "mediatek,mt8195_mt6359_rt1019_rt5682";
> mediatek,platform = <&afe>;
> + clocks = <&topckgen 235>; //CLK_TOP_APLL12_DIV2
> + clock-names = "i2so1_mclk";
Being a virtual node, how does it have clocks? This belongs in the h/w
device that consumes the clock.
> pinctrl-names = "default";
> pinctrl-0 = <&aud_pins_default>;
> };
> --
> 2.18.0
>
>
next prev parent reply other threads:[~2021-12-16 19:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 6:58 [PATCH 1/2] ASoC: mediatek: mt8195: update control for RT5682 series Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` [PATCH 2/2] dt-bindings: mediatek: mt8195: add clock property to sound node Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-15 6:58 ` Trevor Wu
2021-12-16 19:06 ` Rob Herring [this message]
2021-12-16 19:06 ` Rob Herring
2021-12-16 19:06 ` Rob Herring
2021-12-16 19:06 ` Rob Herring
2021-12-17 7:35 ` Trevor Wu
2021-12-17 7:35 ` Trevor Wu
2021-12-17 7:35 ` Trevor Wu
2021-12-17 7:35 ` Trevor Wu
2021-12-15 8:20 ` [PATCH 1/2] ASoC: mediatek: mt8195: update control for RT5682 series Tzung-Bi Shih
2021-12-15 8:20 ` Tzung-Bi Shih
2021-12-15 8:20 ` Tzung-Bi Shih
2021-12-15 8:20 ` Tzung-Bi Shih
2021-12-16 3:37 ` Trevor Wu
2021-12-16 3:37 ` Trevor Wu
2021-12-16 3:37 ` Trevor Wu
2021-12-16 3:37 ` Trevor Wu
2021-12-16 5:02 ` Tzung-Bi Shih
2021-12-16 5:02 ` Tzung-Bi Shih
2021-12-16 5:02 ` Tzung-Bi Shih
2021-12-16 5:02 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbuOQOH3esG1pFQU@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.