From: Tzung-Bi Shih <tzungbi@google.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Steve Cho <stevecho@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered
Date: Wed, 29 Dec 2021 14:36:54 +0800 [thread overview]
Message-ID: <YcwCBgw6ZjYwBLFf@google.com> (raw)
In-Reply-To: <20211228094146.20505-6-yunfei.dong@mediatek.com>
On Tue, Dec 28, 2021 at 05:41:39PM +0800, Yunfei Dong wrote:
> From: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com>
Same as 4th patch. Please fix it.
> For lat and core architecture, just need to get output buffer for lat
> decode. For core hardware need to get lat's message and capture buffer.
> In order to let lat and core decode in parallel, need to set capture
> buffer buffered.
I think the description should be rephrased.
I may misunderstand but something like the template:
"""
OUTPUT -> lat -> core -> CAPTURE. Lat and core can work in parallel.
Sets capture buffer buffered to ...
"""
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> index 5aebf88f997b..23a154c4e321 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> @@ -314,6 +314,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx)
> src_vq = v4l2_m2m_get_vq(ctx->m2m_ctx,
> V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
>
> + if (ctx->dev->vdec_pdata->hw_arch != MTK_VDEC_PURE_SINGLE_CORE)
> + v4l2_m2m_set_dst_buffered(ctx->m2m_ctx, 1);
s/1/true/ helps readability.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Steve Cho <stevecho@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered
Date: Wed, 29 Dec 2021 14:36:54 +0800 [thread overview]
Message-ID: <YcwCBgw6ZjYwBLFf@google.com> (raw)
In-Reply-To: <20211228094146.20505-6-yunfei.dong@mediatek.com>
On Tue, Dec 28, 2021 at 05:41:39PM +0800, Yunfei Dong wrote:
> From: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com>
Same as 4th patch. Please fix it.
> For lat and core architecture, just need to get output buffer for lat
> decode. For core hardware need to get lat's message and capture buffer.
> In order to let lat and core decode in parallel, need to set capture
> buffer buffered.
I think the description should be rephrased.
I may misunderstand but something like the template:
"""
OUTPUT -> lat -> core -> CAPTURE. Lat and core can work in parallel.
Sets capture buffer buffered to ...
"""
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> index 5aebf88f997b..23a154c4e321 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> @@ -314,6 +314,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx)
> src_vq = v4l2_m2m_get_vq(ctx->m2m_ctx,
> V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
>
> + if (ctx->dev->vdec_pdata->hw_arch != MTK_VDEC_PURE_SINGLE_CORE)
> + v4l2_m2m_set_dst_buffered(ctx->m2m_ctx, 1);
s/1/true/ helps readability.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Steve Cho <stevecho@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered
Date: Wed, 29 Dec 2021 14:36:54 +0800 [thread overview]
Message-ID: <YcwCBgw6ZjYwBLFf@google.com> (raw)
In-Reply-To: <20211228094146.20505-6-yunfei.dong@mediatek.com>
On Tue, Dec 28, 2021 at 05:41:39PM +0800, Yunfei Dong wrote:
> From: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com>
Same as 4th patch. Please fix it.
> For lat and core architecture, just need to get output buffer for lat
> decode. For core hardware need to get lat's message and capture buffer.
> In order to let lat and core decode in parallel, need to set capture
> buffer buffered.
I think the description should be rephrased.
I may misunderstand but something like the template:
"""
OUTPUT -> lat -> core -> CAPTURE. Lat and core can work in parallel.
Sets capture buffer buffered to ...
"""
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> index 5aebf88f997b..23a154c4e321 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> @@ -314,6 +314,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx)
> src_vq = v4l2_m2m_get_vq(ctx->m2m_ctx,
> V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
>
> + if (ctx->dev->vdec_pdata->hw_arch != MTK_VDEC_PURE_SINGLE_CORE)
> + v4l2_m2m_set_dst_buffered(ctx->m2m_ctx, 1);
s/1/true/ helps readability.
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Steve Cho <stevecho@chromium.org>,
Irui Wang <irui.wang@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Fritz Koenig <frkoenig@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tomasz Figa <tfiga@google.com>, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tiffany Lin <tiffany.lin@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
srv_heupstream@mediatek.com,
Alexandre Courbot <acourbot@chromium.org>,
linux-kernel@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered
Date: Wed, 29 Dec 2021 14:36:54 +0800 [thread overview]
Message-ID: <YcwCBgw6ZjYwBLFf@google.com> (raw)
In-Reply-To: <20211228094146.20505-6-yunfei.dong@mediatek.com>
On Tue, Dec 28, 2021 at 05:41:39PM +0800, Yunfei Dong wrote:
> From: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com>
Same as 4th patch. Please fix it.
> For lat and core architecture, just need to get output buffer for lat
> decode. For core hardware need to get lat's message and capture buffer.
> In order to let lat and core decode in parallel, need to set capture
> buffer buffered.
I think the description should be rephrased.
I may misunderstand but something like the template:
"""
OUTPUT -> lat -> core -> CAPTURE. Lat and core can work in parallel.
Sets capture buffer buffered to ...
"""
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> index 5aebf88f997b..23a154c4e321 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c
> @@ -314,6 +314,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx)
> src_vq = v4l2_m2m_get_vq(ctx->m2m_ctx,
> V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
>
> + if (ctx->dev->vdec_pdata->hw_arch != MTK_VDEC_PURE_SINGLE_CORE)
> + v4l2_m2m_set_dst_buffered(ctx->m2m_ctx, 1);
s/1/true/ helps readability.
next prev parent reply other threads:[~2021-12-29 6:37 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 9:41 [PATCH v2, 00/12] media: mtk-vcodec: support for MT8192 decoder Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` [PATCH v2, 01/12] media: mtk-vcodec: Add vdec enable/disable hardware helpers Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-29 5:35 ` Tzung-Bi Shih
2021-12-29 5:35 ` Tzung-Bi Shih
2021-12-29 5:35 ` Tzung-Bi Shih
2021-12-29 5:35 ` Tzung-Bi Shih
2021-12-28 9:41 ` [PATCH v2, 02/12] media: mtk-vcodec: Using firmware type to separate different firmware architecture Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-29 5:36 ` Tzung-Bi Shih
2021-12-29 5:36 ` Tzung-Bi Shih
2021-12-29 5:36 ` Tzung-Bi Shih
2021-12-29 5:36 ` Tzung-Bi Shih
2021-12-28 9:41 ` [PATCH v2, 03/12] media: mtk-vcodec: get capture queue buffer size from scp Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-29 5:36 ` Tzung-Bi Shih
2021-12-29 5:36 ` Tzung-Bi Shih
2021-12-29 5:36 ` Tzung-Bi Shih
2021-12-29 5:36 ` Tzung-Bi Shih
2021-12-29 6:52 ` yunfei.dong
2021-12-29 6:52 ` yunfei.dong
2021-12-29 6:52 ` yunfei.dong
2021-12-29 6:52 ` yunfei.dong
2021-12-29 7:27 ` Tzung-Bi Shih
2021-12-29 7:27 ` Tzung-Bi Shih
2021-12-29 7:27 ` Tzung-Bi Shih
2021-12-29 7:27 ` Tzung-Bi Shih
2021-12-28 9:41 ` [PATCH v2, 04/12] media: mtk-vcodec: Read max resolution from dec_capability Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-29 5:56 ` Tzung-Bi Shih
2021-12-29 5:56 ` Tzung-Bi Shih
2021-12-29 5:56 ` Tzung-Bi Shih
2021-12-29 5:56 ` Tzung-Bi Shih
2021-12-28 9:41 ` [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-29 6:36 ` Tzung-Bi Shih [this message]
2021-12-29 6:36 ` Tzung-Bi Shih
2021-12-29 6:36 ` Tzung-Bi Shih
2021-12-29 6:36 ` Tzung-Bi Shih
2021-12-28 9:41 ` [PATCH v2, 06/12] media: mtk-vcodec: Refactor get and put capture buffer flow Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` [PATCH v2, 07/12] media: mtk-vcodec: Refactor supported vdec formats and framesizes Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` [PATCH v2, 08/12] media: mtk-vcodec: Add format to support MT21C Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` [PATCH v2, 09/12] media: mtk-vcodec: disable vp8 4K capability Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` [PATCH v2, 10/12] media: mtk-vcodec: Fix v4l2-compliance fail Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` [PATCH v2, 11/12] media: mtk-vcodec: Extract H264 common code Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` [PATCH v2, 12/12] media: mtk-vcodec: Add h264 decoder driver for mt8192 Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
2021-12-28 9:41 ` Yunfei Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcwCBgw6ZjYwBLFf@google.com \
--to=tzungbi@google.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=stevecho@chromium.org \
--cc=tfiga@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=tzungbi@chromium.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.