From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Gabriel Somlo <somlo@cmu.edu>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu_fw_cfg: use default_groups in kobj_type
Date: Thu, 6 Jan 2022 14:25:32 +0100 [thread overview]
Message-ID: <YdbtzL59aCePeDnt@kroah.com> (raw)
In-Reply-To: <20220105175546-mutt-send-email-mst@kernel.org>
On Wed, Jan 05, 2022 at 05:56:26PM -0500, Michael S. Tsirkin wrote:
> On Wed, Jan 05, 2022 at 07:31:33PM +0100, Greg Kroah-Hartman wrote:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the firmware qemu_fw_cfg sysfs code to use default_groups
> > field which has been the preferred way since aa30f47cf666 ("kobject: Add
> > support for default attribute groups to kobj_type") so that we can soon
> > get rid of the obsolete default_attrs field.
> >
> > Cc: Gabriel Somlo <somlo@cmu.edu>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: qemu-devel@nongnu.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> OK then you know best I guess
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> feel free to queue.
Thanks, will do!
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gabriel Somlo <somlo@cmu.edu>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu_fw_cfg: use default_groups in kobj_type
Date: Thu, 6 Jan 2022 14:25:32 +0100 [thread overview]
Message-ID: <YdbtzL59aCePeDnt@kroah.com> (raw)
In-Reply-To: <20220105175546-mutt-send-email-mst@kernel.org>
On Wed, Jan 05, 2022 at 05:56:26PM -0500, Michael S. Tsirkin wrote:
> On Wed, Jan 05, 2022 at 07:31:33PM +0100, Greg Kroah-Hartman wrote:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the firmware qemu_fw_cfg sysfs code to use default_groups
> > field which has been the preferred way since aa30f47cf666 ("kobject: Add
> > support for default attribute groups to kobj_type") so that we can soon
> > get rid of the obsolete default_attrs field.
> >
> > Cc: Gabriel Somlo <somlo@cmu.edu>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: qemu-devel@nongnu.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> OK then you know best I guess
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> feel free to queue.
Thanks, will do!
greg k-h
next prev parent reply other threads:[~2022-01-06 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 18:31 [PATCH] qemu_fw_cfg: use default_groups in kobj_type Greg Kroah-Hartman
2022-01-05 18:31 ` Greg Kroah-Hartman
2022-01-05 22:56 ` Michael S. Tsirkin
2022-01-05 22:56 ` Michael S. Tsirkin
2022-01-06 13:25 ` Greg Kroah-Hartman [this message]
2022-01-06 13:25 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdbtzL59aCePeDnt@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.