From: Henrik Grimler <henrik@grimler.se>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Inki Dae" <inki.dae@samsung.com>,
"Maíra Canal" <maira.canal@usp.br>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node
Date: Mon, 24 Jan 2022 16:22:41 +0100 [thread overview]
Message-ID: <Ye7EQRefzECSqVOe@grimlerstat> (raw)
In-Reply-To: <20220124135246.6998-1-m.szyprowski@samsung.com>
Hi Marek,
On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote:
> TE-gpio, if defined, is placed in the panel's node, not the parent DSI
> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and
> pass proper device node to it. The code already has a proper cleanup
> path, so it looks that the devm_* variant has been applied assidentally
~~~~~~~~~~~~
Small observation: the spelling above should probably be "accidentally".
> during the conversion to gpiod API.
Best regards,
Henrik Grimler
WARNING: multiple messages have this Message-ID (diff)
From: Henrik Grimler <henrik@grimler.se>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Maíra Canal" <maira.canal@usp.br>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node
Date: Mon, 24 Jan 2022 16:22:41 +0100 [thread overview]
Message-ID: <Ye7EQRefzECSqVOe@grimlerstat> (raw)
In-Reply-To: <20220124135246.6998-1-m.szyprowski@samsung.com>
Hi Marek,
On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote:
> TE-gpio, if defined, is placed in the panel's node, not the parent DSI
> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and
> pass proper device node to it. The code already has a proper cleanup
> path, so it looks that the devm_* variant has been applied assidentally
~~~~~~~~~~~~
Small observation: the spelling above should probably be "accidentally".
> during the conversion to gpiod API.
Best regards,
Henrik Grimler
next prev parent reply other threads:[~2022-01-24 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220124135259eucas1p1ed3c76ef23d30afe620e06a419540c9e@eucas1p1.samsung.com>
2022-01-24 13:52 ` [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node Marek Szyprowski
2022-01-24 13:52 ` Marek Szyprowski
2022-01-24 15:22 ` Henrik Grimler [this message]
2022-01-24 15:22 ` Henrik Grimler
2022-01-28 6:24 ` Inki Dae
2022-01-28 6:24 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye7EQRefzECSqVOe@grimlerstat \
--to=henrik@grimler.se \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maira.canal@usp.br \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.