* [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node [not found] <CGME20220124135259eucas1p1ed3c76ef23d30afe620e06a419540c9e@eucas1p1.samsung.com> @ 2022-01-24 13:52 ` Marek Szyprowski 0 siblings, 0 replies; 6+ messages in thread From: Marek Szyprowski @ 2022-01-24 13:52 UTC (permalink / raw) To: dri-devel, linux-samsung-soc Cc: Marek Szyprowski, Seung-Woo Kim, Inki Dae, Maíra Canal, Krzysztof Kozlowski TE-gpio, if defined, is placed in the panel's node, not the parent DSI node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and pass proper device node to it. The code already has a proper cleanup path, so it looks that the devm_* variant has been applied assidentally during the conversion to gpiod API. Fixes: ee6c8b5afa62 ("drm/exynos: Replace legacy gpio interface for gpiod interface") Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 14ebbb124852..d13f5e3a030d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1334,7 +1334,7 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi, int ret; int te_gpio_irq; - dsi->te_gpio = devm_gpiod_get_optional(dsi->dev, "te", GPIOD_IN); + dsi->te_gpio = gpiod_get_optional(panel, "te", GPIOD_IN); if (!dsi->te_gpio) { return 0; } else if (IS_ERR(dsi->te_gpio)) { -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node @ 2022-01-24 13:52 ` Marek Szyprowski 0 siblings, 0 replies; 6+ messages in thread From: Marek Szyprowski @ 2022-01-24 13:52 UTC (permalink / raw) To: dri-devel, linux-samsung-soc Cc: Maíra Canal, Krzysztof Kozlowski, Seung-Woo Kim, Marek Szyprowski TE-gpio, if defined, is placed in the panel's node, not the parent DSI node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and pass proper device node to it. The code already has a proper cleanup path, so it looks that the devm_* variant has been applied assidentally during the conversion to gpiod API. Fixes: ee6c8b5afa62 ("drm/exynos: Replace legacy gpio interface for gpiod interface") Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 14ebbb124852..d13f5e3a030d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1334,7 +1334,7 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi, int ret; int te_gpio_irq; - dsi->te_gpio = devm_gpiod_get_optional(dsi->dev, "te", GPIOD_IN); + dsi->te_gpio = gpiod_get_optional(panel, "te", GPIOD_IN); if (!dsi->te_gpio) { return 0; } else if (IS_ERR(dsi->te_gpio)) { -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node 2022-01-24 13:52 ` Marek Szyprowski @ 2022-01-24 15:22 ` Henrik Grimler -1 siblings, 0 replies; 6+ messages in thread From: Henrik Grimler @ 2022-01-24 15:22 UTC (permalink / raw) To: Marek Szyprowski Cc: dri-devel, linux-samsung-soc, Seung-Woo Kim, Inki Dae, Maíra Canal, Krzysztof Kozlowski Hi Marek, On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote: > TE-gpio, if defined, is placed in the panel's node, not the parent DSI > node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and > pass proper device node to it. The code already has a proper cleanup > path, so it looks that the devm_* variant has been applied assidentally ~~~~~~~~~~~~ Small observation: the spelling above should probably be "accidentally". > during the conversion to gpiod API. Best regards, Henrik Grimler ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node @ 2022-01-24 15:22 ` Henrik Grimler 0 siblings, 0 replies; 6+ messages in thread From: Henrik Grimler @ 2022-01-24 15:22 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-samsung-soc, Krzysztof Kozlowski, Maíra Canal, Seung-Woo Kim, dri-devel Hi Marek, On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote: > TE-gpio, if defined, is placed in the panel's node, not the parent DSI > node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and > pass proper device node to it. The code already has a proper cleanup > path, so it looks that the devm_* variant has been applied assidentally ~~~~~~~~~~~~ Small observation: the spelling above should probably be "accidentally". > during the conversion to gpiod API. Best regards, Henrik Grimler ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node 2022-01-24 15:22 ` Henrik Grimler @ 2022-01-28 6:24 ` Inki Dae -1 siblings, 0 replies; 6+ messages in thread From: Inki Dae @ 2022-01-28 6:24 UTC (permalink / raw) To: Henrik Grimler, Marek Szyprowski Cc: dri-devel, linux-samsung-soc, Seung-Woo Kim, Maíra Canal, Krzysztof Kozlowski Hi, 22. 1. 25. 00:22에 Henrik Grimler 이(가) 쓴 글: > Hi Marek, > > On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote: >> TE-gpio, if defined, is placed in the panel's node, not the parent DSI >> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and >> pass proper device node to it. The code already has a proper cleanup >> path, so it looks that the devm_* variant has been applied assidentally > ~~~~~~~~~~~~ > Small observation: the spelling above should probably be "accidentally". > I can fix it. Thanks. >> during the conversion to gpiod API. > > Best regards, > Henrik Grimler > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node @ 2022-01-28 6:24 ` Inki Dae 0 siblings, 0 replies; 6+ messages in thread From: Inki Dae @ 2022-01-28 6:24 UTC (permalink / raw) To: Henrik Grimler, Marek Szyprowski Cc: Maíra Canal, linux-samsung-soc, Seung-Woo Kim, dri-devel, Krzysztof Kozlowski Hi, 22. 1. 25. 00:22에 Henrik Grimler 이(가) 쓴 글: > Hi Marek, > > On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote: >> TE-gpio, if defined, is placed in the panel's node, not the parent DSI >> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and >> pass proper device node to it. The code already has a proper cleanup >> path, so it looks that the devm_* variant has been applied assidentally > ~~~~~~~~~~~~ > Small observation: the spelling above should probably be "accidentally". > I can fix it. Thanks. >> during the conversion to gpiod API. > > Best regards, > Henrik Grimler > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-28 6:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20220124135259eucas1p1ed3c76ef23d30afe620e06a419540c9e@eucas1p1.samsung.com>
2022-01-24 13:52 ` [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node Marek Szyprowski
2022-01-24 13:52 ` Marek Szyprowski
2022-01-24 15:22 ` Henrik Grimler
2022-01-24 15:22 ` Henrik Grimler
2022-01-28 6:24 ` Inki Dae
2022-01-28 6:24 ` Inki Dae
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.