From: Lee Jones <lee.jones@linaro.org>
To: Evgeny Boger <boger@wirenboard.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
linux-sunxi@lists.linux.dev, Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] iio: adc: sun4i-gpadc-iio: no temp sensor on R40
Date: Mon, 17 Jan 2022 09:00:49 +0000 [thread overview]
Message-ID: <YeUwQfkdWbEZlnh2@google.com> (raw)
In-Reply-To: <20211119191456.510435-2-boger@wirenboard.com>
On Fri, 19 Nov 2021, Evgeny Boger wrote:
> R40 SoC has touchscreen controller also serving as general-purpose ADC.
> The hardware is very similar to A31, except that R40 has separate
> calibrated thermal sensor IP (handled by sun8i_thermal).
>
> Despite the temperature sensor in the RTP is never mentioned in
> the R40 family user manuals, it appears to be working. However,
> it's not very useful as it lacks calibration data and there is another
> fully functioning temperature sensor anyway.
>
> This patch disables the temperature sensor in RTP/GPADC IP on R40.
>
> The reason for disabling the temperature sensor is that the IP
> needs to be switched back and forth between RTP and GPADC modes for
> temperature measurements. Not only this introduces delays, but it also
> disturbs external circuitry by injecting current into ADC inputs.
>
> Signed-off-by: Evgeny Boger <boger@wirenboard.com>
> ---
> drivers/iio/adc/sun4i-gpadc-iio.c | 32 +++++++++++++++++++++++--------
> drivers/mfd/sun4i-gpadc.c | 17 ++++++++++++++++
Please split these out.
They don't *need* to go in via a single tree.
> 2 files changed, 41 insertions(+), 8 deletions(-)
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Evgeny Boger <boger@wirenboard.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
linux-sunxi@lists.linux.dev, Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] iio: adc: sun4i-gpadc-iio: no temp sensor on R40
Date: Mon, 17 Jan 2022 09:00:49 +0000 [thread overview]
Message-ID: <YeUwQfkdWbEZlnh2@google.com> (raw)
In-Reply-To: <20211119191456.510435-2-boger@wirenboard.com>
On Fri, 19 Nov 2021, Evgeny Boger wrote:
> R40 SoC has touchscreen controller also serving as general-purpose ADC.
> The hardware is very similar to A31, except that R40 has separate
> calibrated thermal sensor IP (handled by sun8i_thermal).
>
> Despite the temperature sensor in the RTP is never mentioned in
> the R40 family user manuals, it appears to be working. However,
> it's not very useful as it lacks calibration data and there is another
> fully functioning temperature sensor anyway.
>
> This patch disables the temperature sensor in RTP/GPADC IP on R40.
>
> The reason for disabling the temperature sensor is that the IP
> needs to be switched back and forth between RTP and GPADC modes for
> temperature measurements. Not only this introduces delays, but it also
> disturbs external circuitry by injecting current into ADC inputs.
>
> Signed-off-by: Evgeny Boger <boger@wirenboard.com>
> ---
> drivers/iio/adc/sun4i-gpadc-iio.c | 32 +++++++++++++++++++++++--------
> drivers/mfd/sun4i-gpadc.c | 17 ++++++++++++++++
Please split these out.
They don't *need* to go in via a single tree.
> 2 files changed, 41 insertions(+), 8 deletions(-)
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-17 9:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 19:14 [PATCH 0/3] Enable RTP (GPADC) controller on Allwinner R40 Evgeny Boger
2021-11-19 19:14 ` Evgeny Boger
2021-11-19 19:14 ` [PATCH 1/3] iio: adc: sun4i-gpadc-iio: no temp sensor on R40 Evgeny Boger
2021-11-19 19:14 ` Evgeny Boger
2021-11-22 9:11 ` Maxime Ripard
2021-11-22 9:11 ` Maxime Ripard
2021-11-22 12:41 ` Jonathan Cameron
2021-11-22 12:41 ` Jonathan Cameron
2022-01-11 13:13 ` Evgeny Boger
2022-01-11 13:13 ` Evgeny Boger
2022-01-15 15:41 ` Jonathan Cameron
2022-01-15 15:41 ` Jonathan Cameron
2022-01-17 9:00 ` Lee Jones [this message]
2022-01-17 9:00 ` Lee Jones
2021-11-19 19:14 ` [PATCH 2/3] dt-bindings: iio: adc: new compatible for Allwinner R40 RTP controller Evgeny Boger
2021-11-19 19:14 ` Evgeny Boger
2021-11-22 9:10 ` Maxime Ripard
2021-11-22 9:10 ` Maxime Ripard
2021-11-30 1:46 ` Rob Herring
2021-11-30 1:46 ` Rob Herring
2021-11-19 19:14 ` [PATCH 3/3] ARM: dts: sun8i: r40: add rtp node Evgeny Boger
2021-11-19 19:14 ` Evgeny Boger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeUwQfkdWbEZlnh2@google.com \
--to=lee.jones@linaro.org \
--cc=boger@wirenboard.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.