From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: bhelgaas@google.com, koba.ko@canonical.com,
Russell Currey <ruscur@russell.cc>,
Oliver O'Halloran <oohall@gmail.com>,
Lalithambika Krishnakumar <lalithambika.krishnakumar@intel.com>,
Joerg Roedel <jroedel@suse.de>,
Lu Baolu <baolu.lu@linux.intel.com>,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI/AER: Disable AER when link is in L2/L3 ready, L2 and L3 state
Date: Thu, 27 Jan 2022 08:35:27 +0200 [thread overview]
Message-ID: <YfI9L01LI/0rZIuP@lahna> (raw)
In-Reply-To: <YfI7u5XSlNlx2w4I@lahna>
On Thu, Jan 27, 2022 at 08:29:22AM +0200, Mika Westerberg wrote:
> > For example, should we convert commit a697f072f5da8 ("PCI: Disable PTM
> > during suspend to save power") to PM hooks in PTM service?
>
> Yes, I think that's the right thing to do. I wonder how it was not using
> the PM hooks in the first place.
Actually no. The reason it is not using PM hooks is that PTM is not a
port "service" so it needs to be dealt in the core.
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Joerg Roedel <jroedel@suse.de>,
Lalithambika Krishnakumar <lalithambika.krishnakumar@intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
koba.ko@canonical.com, Oliver O'Halloran <oohall@gmail.com>,
bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH 1/2] PCI/AER: Disable AER when link is in L2/L3 ready, L2 and L3 state
Date: Thu, 27 Jan 2022 08:35:27 +0200 [thread overview]
Message-ID: <YfI9L01LI/0rZIuP@lahna> (raw)
In-Reply-To: <YfI7u5XSlNlx2w4I@lahna>
On Thu, Jan 27, 2022 at 08:29:22AM +0200, Mika Westerberg wrote:
> > For example, should we convert commit a697f072f5da8 ("PCI: Disable PTM
> > during suspend to save power") to PM hooks in PTM service?
>
> Yes, I think that's the right thing to do. I wonder how it was not using
> the PM hooks in the first place.
Actually no. The reason it is not using PM hooks is that PTM is not a
port "service" so it needs to be dealt in the core.
next prev parent reply other threads:[~2022-01-27 6:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 7:18 [PATCH 1/2] PCI/AER: Disable AER when link is in L2/L3 ready, L2 and L3 state Kai-Heng Feng
2022-01-26 7:18 ` Kai-Heng Feng
2022-01-26 7:18 ` [PATCH 2/2] PCI/DPC: Disable DPC " Kai-Heng Feng
2022-01-26 7:18 ` Kai-Heng Feng
2022-01-26 11:10 ` Mika Westerberg
2022-01-26 11:10 ` Mika Westerberg
2022-01-27 2:22 ` Kai-Heng Feng
2022-01-27 2:22 ` Kai-Heng Feng
2022-01-26 11:03 ` [PATCH 1/2] PCI/AER: Disable AER " Mika Westerberg
2022-01-26 11:03 ` Mika Westerberg
2022-01-27 2:21 ` Kai-Heng Feng
2022-01-27 2:21 ` Kai-Heng Feng
2022-01-27 6:29 ` Mika Westerberg
2022-01-27 6:29 ` Mika Westerberg
2022-01-27 6:35 ` Mika Westerberg [this message]
2022-01-27 6:35 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfI9L01LI/0rZIuP@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=jroedel@suse.de \
--cc=kai.heng.feng@canonical.com \
--cc=koba.ko@canonical.com \
--cc=lalithambika.krishnakumar@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.