From: Mark Rutland <mark.rutland@arm.com>
To: kbuild-all@lists.01.org
Subject: Re: [peterz-queue:sched/core 32/32] arch/arm64/include/asm/preempt.h:85:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_TRUE'
Date: Tue, 08 Feb 2022 18:49:07 +0000 [thread overview]
Message-ID: <YgK7I2bMJQA8IPmt@FVFF77S0Q05N> (raw)
In-Reply-To: <202202081918.RDLHzFHh-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
On Tue, Feb 08, 2022 at 07:08:33PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
> head: ac7695a93a578befdcf4900a90860bf19e057e1b
> commit: ac7695a93a578befdcf4900a90860bf19e057e1b [32/32] arm64: support PREEMPT_DYNAMIC
> >> arch/arm64/include/asm/preempt.h:85:1: warning: data definition has no type or storage class
> 85 | DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched);
> | ^~~~~~~~~~~~~~~~~~~~~~~
This is because I forgot to include <linux/jump_label.h>, so GCC has no idea
what `DECLARE_STATIC_KEY_TRUE` means.
I'll go add that where needed and check that doesn't introduce a circular
dependency.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [peterz-queue:sched/core 32/32] arch/arm64/include/asm/preempt.h:85:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_TRUE'
Date: Tue, 8 Feb 2022 18:49:07 +0000 [thread overview]
Message-ID: <YgK7I2bMJQA8IPmt@FVFF77S0Q05N> (raw)
In-Reply-To: <202202081918.RDLHzFHh-lkp@intel.com>
On Tue, Feb 08, 2022 at 07:08:33PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
> head: ac7695a93a578befdcf4900a90860bf19e057e1b
> commit: ac7695a93a578befdcf4900a90860bf19e057e1b [32/32] arm64: support PREEMPT_DYNAMIC
> >> arch/arm64/include/asm/preempt.h:85:1: warning: data definition has no type or storage class
> 85 | DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched);
> | ^~~~~~~~~~~~~~~~~~~~~~~
This is because I forgot to include <linux/jump_label.h>, so GCC has no idea
what `DECLARE_STATIC_KEY_TRUE` means.
I'll go add that where needed and check that doesn't introduce a circular
dependency.
Thanks,
Mark.
next prev parent reply other threads:[~2022-02-08 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 11:08 [peterz-queue:sched/core 32/32] arch/arm64/include/asm/preempt.h:85:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_TRUE' kernel test robot
2022-02-08 11:08 ` kernel test robot
2022-02-08 18:49 ` Mark Rutland [this message]
2022-02-08 18:49 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgK7I2bMJQA8IPmt@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.