All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Dave Chinner <david@fromorbit.com>,
	Linux-Kernal <linux-kernel@vger.kernel.org>,
	qat-linux@intel.com, linux-xfs <linux-xfs@vger.kernel.org>,
	device-mapper development <dm-devel@redhat.com>,
	Kyle Sanderson <kyle.leet@gmail.com>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs
Date: Mon, 28 Feb 2022 21:59:08 +0100	[thread overview]
Message-ID: <Yh03nCTcDGqReEGs@kroah.com> (raw)
In-Reply-To: <Yh0y75aegqS4jIP7@silpixa00400314>

On Mon, Feb 28, 2022 at 08:39:11PM +0000, Giovanni Cabiddu wrote:
> On Mon, Feb 28, 2022 at 11:25:49AM -0800, Linus Torvalds wrote:
> > On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson <kyle.leet@gmail.com> wrote:
> > >
> > > Makes sense - this kernel driver has been destroying users for many
> > > years. I'm disappointed that this critical bricking failure isn't
> > > searchable for others.
> > 
> > It does sound like we should just disable that driver entirely until
> > it is fixed.
> > 
> > Or at least the configuration that can cause problems, if there is
> > some particular sub-case.
> The dm-crypt + QAT use-case is already disabled since kernel 5.10 due to
> a different issue.
> Is it an option to port those patches to stable till I provide a fix for
> the driver? I drafted already few alternatives for the fix and I am aiming
> for a final set by end of week.

If the existing situation is broken, yes, those patches are fine for
stable releases.

thanks,

greg k-h

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Kyle Sanderson <kyle.leet@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Dave Chinner <david@fromorbit.com>,
	qat-linux@intel.com, Linux-Kernal <linux-kernel@vger.kernel.org>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs
Date: Mon, 28 Feb 2022 21:59:08 +0100	[thread overview]
Message-ID: <Yh03nCTcDGqReEGs@kroah.com> (raw)
In-Reply-To: <Yh0y75aegqS4jIP7@silpixa00400314>

On Mon, Feb 28, 2022 at 08:39:11PM +0000, Giovanni Cabiddu wrote:
> On Mon, Feb 28, 2022 at 11:25:49AM -0800, Linus Torvalds wrote:
> > On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson <kyle.leet@gmail.com> wrote:
> > >
> > > Makes sense - this kernel driver has been destroying users for many
> > > years. I'm disappointed that this critical bricking failure isn't
> > > searchable for others.
> > 
> > It does sound like we should just disable that driver entirely until
> > it is fixed.
> > 
> > Or at least the configuration that can cause problems, if there is
> > some particular sub-case.
> The dm-crypt + QAT use-case is already disabled since kernel 5.10 due to
> a different issue.
> Is it an option to port those patches to stable till I provide a fix for
> the driver? I drafted already few alternatives for the fix and I am aiming
> for a final set by end of week.

If the existing situation is broken, yes, those patches are fine for
stable releases.

thanks,

greg k-h

  reply	other threads:[~2022-02-28 21:08 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19  5:02 [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs Kyle Sanderson
2022-02-19  5:02 ` Kyle Sanderson
2022-02-19 21:03 ` [dm-devel] " Dave Chinner
2022-02-19 21:03   ` Dave Chinner
2022-02-19 23:00   ` [dm-devel] " Kyle Sanderson
2022-02-19 23:00     ` Kyle Sanderson
2022-02-21 11:47     ` [dm-devel] " Giovanni Cabiddu
2022-02-21 11:47       ` Giovanni Cabiddu
2022-02-28  8:18       ` [dm-devel] " Kyle Sanderson
2022-02-28  8:18         ` Kyle Sanderson
2022-02-28 19:25         ` [dm-devel] " Linus Torvalds
2022-02-28 19:25           ` Linus Torvalds
2022-02-28 20:39           ` [dm-devel] " Giovanni Cabiddu
2022-02-28 20:39             ` Giovanni Cabiddu
2022-02-28 20:59             ` Greg KH [this message]
2022-02-28 20:59               ` Greg KH
2022-02-28 23:26             ` [dm-devel] " Herbert Xu
2022-02-28 23:26               ` Herbert Xu
2022-03-01  1:12               ` [dm-devel] " Linus Torvalds
2022-03-01  1:12                 ` Linus Torvalds
2022-03-01  4:11                 ` [dm-devel] " Herbert Xu
2022-03-01  4:11                   ` Herbert Xu
2022-03-02 10:29                   ` [dm-devel] " Greg KH
2022-03-02 10:29                     ` Greg KH
2022-03-02 11:49                     ` [dm-devel] " Giovanni Cabiddu
2022-03-02 11:49                       ` Giovanni Cabiddu
2022-03-02 14:56                       ` [dm-devel] " Greg KH
2022-03-02 14:56                         ` Greg KH
2022-03-02 22:27                         ` [dm-devel] " Herbert Xu
2022-03-02 22:27                           ` Herbert Xu
2022-03-02 22:42                           ` [dm-devel] " Giovanni Cabiddu
2022-03-02 22:42                             ` Giovanni Cabiddu
2022-03-02 22:45                             ` [dm-devel] " Herbert Xu
2022-03-02 22:45                               ` Herbert Xu
2022-03-03 13:49                               ` [dm-devel] " Giovanni Cabiddu
2022-03-03 13:49                                 ` Giovanni Cabiddu
2022-03-03 19:21                                 ` [dm-devel] " Eric Biggers
2022-03-03 19:21                                   ` Eric Biggers
2022-03-03 21:24                                   ` [dm-devel] " Giovanni Cabiddu
2022-03-03 21:24                                     ` Giovanni Cabiddu
2022-03-03 21:44                                     ` [dm-devel] " Eric Biggers
2022-03-03 21:44                                       ` Eric Biggers
2022-03-04 17:50                                       ` Giovanni Cabiddu
2022-03-16 21:38                                         ` [dm-devel] " Kyle Sanderson
2022-03-16 21:38                                           ` Kyle Sanderson
2022-03-16 22:13                                           ` [dm-devel] " Herbert Xu
2022-03-16 22:13                                             ` Herbert Xu
2022-02-28 21:13           ` [dm-devel] " Milan Broz
2022-02-28 21:13             ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yh03nCTcDGqReEGs@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=david@fromorbit.com \
    --cc=dm-devel@redhat.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kyle.leet@gmail.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=qat-linux@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.