All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: Rahul T R <r-ravikumar@ti.com>,
	catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org,
	krzk@kernel.org, geert+renesas@glider.be,
	marcel.ziswiler@toradex.com, biju.das.jz@bp.renesas.com,
	vkoul@kernel.org, enric.balletbo@collabora.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, tomi.valkeinen@ideasonboard.com,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e
Date: Tue, 22 Feb 2022 12:40:42 -0800	[thread overview]
Message-ID: <YhVKSpMOKWzZy9a2@ripper> (raw)
In-Reply-To: <20220222193930.sbc5xlsofhg3amgk@overrun>

On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote:

> On 23:37-20220222, Rahul T R wrote:
> > Enable DRM and PHY configs required for supporting
> > DisplayPort on J721e
> > 
> > Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> > ---
> >  arch/arm64/configs/defconfig | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 9f23d7ec1232..b0cb894a392e 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y
> >  CONFIG_DRM_EXYNOS_HDMI=y
> >  CONFIG_DRM_EXYNOS_MIC=y
> >  CONFIG_DRM_ROCKCHIP=m
> > +CONFIG_DRM_TIDSS=m
> > +CONFIG_DRM_DISPLAY_CONNECTOR=m
> > +CONFIG_DRM_CDNS_MHDP8546=m
> 
> Please use savedefconfig to place the changes in the correct location
> 

Just to clarify the request, use "make savedefconfig" to generate a
defconfig, then based on that put _only_ the relevant changes in the
commit.

> Also indicate changes if any in vmlinux in commit message.
> 

Nishanth, what are you asking for here? Just a mentioning if this has
any impact to vmlinux (or is isolated to the modules selected), or are
you asking for anything specific?

Regards,
Bjorn

> A bootlog indicating functionality in diffstat is also additional good
> thing to do.
> 
> >  CONFIG_ROCKCHIP_ANALOGIX_DP=y
> >  CONFIG_ROCKCHIP_CDN_DP=y
> >  CONFIG_ROCKCHIP_DW_HDMI=y
> > @@ -1175,6 +1178,8 @@ CONFIG_PHY_SAMSUNG_UFS=y
> >  CONFIG_PHY_UNIPHIER_USB2=y
> >  CONFIG_PHY_UNIPHIER_USB3=y
> >  CONFIG_PHY_TEGRA_XUSB=y
> > +CONFIG_PHY_J721E_WIZ=m
> > +CONFIG_PHY_CADENCE_TORRENT=m
> >  CONFIG_ARM_SMMU_V3_PMU=m
> >  CONFIG_FSL_IMX8_DDR_PMU=m
> >  CONFIG_QCOM_L2_PMU=y
> > -- 
> > 2.17.1
> > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: Rahul T R <r-ravikumar@ti.com>,
	catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org,
	krzk@kernel.org, geert+renesas@glider.be,
	marcel.ziswiler@toradex.com, biju.das.jz@bp.renesas.com,
	vkoul@kernel.org, enric.balletbo@collabora.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, tomi.valkeinen@ideasonboard.com,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e
Date: Tue, 22 Feb 2022 12:40:42 -0800	[thread overview]
Message-ID: <YhVKSpMOKWzZy9a2@ripper> (raw)
In-Reply-To: <20220222193930.sbc5xlsofhg3amgk@overrun>

On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote:

> On 23:37-20220222, Rahul T R wrote:
> > Enable DRM and PHY configs required for supporting
> > DisplayPort on J721e
> > 
> > Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> > ---
> >  arch/arm64/configs/defconfig | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 9f23d7ec1232..b0cb894a392e 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y
> >  CONFIG_DRM_EXYNOS_HDMI=y
> >  CONFIG_DRM_EXYNOS_MIC=y
> >  CONFIG_DRM_ROCKCHIP=m
> > +CONFIG_DRM_TIDSS=m
> > +CONFIG_DRM_DISPLAY_CONNECTOR=m
> > +CONFIG_DRM_CDNS_MHDP8546=m
> 
> Please use savedefconfig to place the changes in the correct location
> 

Just to clarify the request, use "make savedefconfig" to generate a
defconfig, then based on that put _only_ the relevant changes in the
commit.

> Also indicate changes if any in vmlinux in commit message.
> 

Nishanth, what are you asking for here? Just a mentioning if this has
any impact to vmlinux (or is isolated to the modules selected), or are
you asking for anything specific?

Regards,
Bjorn

> A bootlog indicating functionality in diffstat is also additional good
> thing to do.
> 
> >  CONFIG_ROCKCHIP_ANALOGIX_DP=y
> >  CONFIG_ROCKCHIP_CDN_DP=y
> >  CONFIG_ROCKCHIP_DW_HDMI=y
> > @@ -1175,6 +1178,8 @@ CONFIG_PHY_SAMSUNG_UFS=y
> >  CONFIG_PHY_UNIPHIER_USB2=y
> >  CONFIG_PHY_UNIPHIER_USB3=y
> >  CONFIG_PHY_TEGRA_XUSB=y
> > +CONFIG_PHY_J721E_WIZ=m
> > +CONFIG_PHY_CADENCE_TORRENT=m
> >  CONFIG_ARM_SMMU_V3_PMU=m
> >  CONFIG_FSL_IMX8_DDR_PMU=m
> >  CONFIG_QCOM_L2_PMU=y
> > -- 
> > 2.17.1
> > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2022-02-22 20:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 18:07 [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e Rahul T R
2022-02-22 19:39 ` Nishanth Menon
2022-02-22 19:39   ` Nishanth Menon
2022-02-22 20:40   ` Bjorn Andersson [this message]
2022-02-22 20:40     ` Bjorn Andersson
2022-02-22 21:26     ` Nishanth Menon
2022-02-22 21:26       ` Nishanth Menon
2022-02-22 22:15       ` Bjorn Andersson
2022-02-22 22:15         ` Bjorn Andersson
2022-02-23  7:58         ` Rahul T R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhVKSpMOKWzZy9a2@ripper \
    --to=bjorn.andersson@linaro.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=catalin.marinas@arm.com \
    --cc=enric.balletbo@collabora.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=nm@ti.com \
    --cc=r-ravikumar@ti.com \
    --cc=shawnguo@kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.