From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: Rahul T R <r-ravikumar@ti.com>,
catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org,
krzk@kernel.org, geert+renesas@glider.be,
marcel.ziswiler@toradex.com, biju.das.jz@bp.renesas.com,
vkoul@kernel.org, enric.balletbo@collabora.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, tomi.valkeinen@ideasonboard.com,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e
Date: Tue, 22 Feb 2022 14:15:40 -0800 [thread overview]
Message-ID: <YhVgjFWShgc8btJP@ripper> (raw)
In-Reply-To: <20220222212642.vwtw7xiz7cck63ea@zombie>
On Tue 22 Feb 13:26 PST 2022, Nishanth Menon wrote:
> On 12:40-20220222, Bjorn Andersson wrote:
> > On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote:
> >
> > > On 23:37-20220222, Rahul T R wrote:
> > > > Enable DRM and PHY configs required for supporting
> > > > DisplayPort on J721e
> > > >
> > > > Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> > > > ---
> > > > arch/arm64/configs/defconfig | 5 +++++
> > > > 1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > > index 9f23d7ec1232..b0cb894a392e 100644
> > > > --- a/arch/arm64/configs/defconfig
> > > > +++ b/arch/arm64/configs/defconfig
> > > > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y
> > > > CONFIG_DRM_EXYNOS_HDMI=y
> > > > CONFIG_DRM_EXYNOS_MIC=y
> > > > CONFIG_DRM_ROCKCHIP=m
> > > > +CONFIG_DRM_TIDSS=m
> > > > +CONFIG_DRM_DISPLAY_CONNECTOR=m
> > > > +CONFIG_DRM_CDNS_MHDP8546=m
> > >
> > > Please use savedefconfig to place the changes in the correct location
> > >
> >
> > Just to clarify the request, use "make savedefconfig" to generate a
> > defconfig, then based on that put _only_ the relevant changes in the
> > commit.
>
> Yup, thanks for clarifying.
> >
> > > Also indicate changes if any in vmlinux in commit message.
> > >
> >
> > Nishanth, what are you asking for here? Just a mentioning if this has
> > any impact to vmlinux (or is isolated to the modules selected), or are
> > you asking for anything specific?
>
> In this case, just ensure to state that vmlinux size has'nt
> changed, in case where we see a =y, we should indicate via
> ./scripts/bloat-o-meter change that is introduced and if yes, we
> should explain why this is fundamental to system boot.
>
> Why is this necessary? This is to prevent product specific
> configurations (such as early display banner, chime etc) from creeping
> and increasing vmlinux size which has an impact for all ARM SoCs.
>
Sounds very reasonable, I'll make sure to ask for such motivations in
the defconfig changes that I pick up through the Qualcomm tree as well.
Regards,
Bjorn
>
> [...]
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: Rahul T R <r-ravikumar@ti.com>,
catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org,
krzk@kernel.org, geert+renesas@glider.be,
marcel.ziswiler@toradex.com, biju.das.jz@bp.renesas.com,
vkoul@kernel.org, enric.balletbo@collabora.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, tomi.valkeinen@ideasonboard.com,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e
Date: Tue, 22 Feb 2022 14:15:40 -0800 [thread overview]
Message-ID: <YhVgjFWShgc8btJP@ripper> (raw)
In-Reply-To: <20220222212642.vwtw7xiz7cck63ea@zombie>
On Tue 22 Feb 13:26 PST 2022, Nishanth Menon wrote:
> On 12:40-20220222, Bjorn Andersson wrote:
> > On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote:
> >
> > > On 23:37-20220222, Rahul T R wrote:
> > > > Enable DRM and PHY configs required for supporting
> > > > DisplayPort on J721e
> > > >
> > > > Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> > > > ---
> > > > arch/arm64/configs/defconfig | 5 +++++
> > > > 1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > > index 9f23d7ec1232..b0cb894a392e 100644
> > > > --- a/arch/arm64/configs/defconfig
> > > > +++ b/arch/arm64/configs/defconfig
> > > > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y
> > > > CONFIG_DRM_EXYNOS_HDMI=y
> > > > CONFIG_DRM_EXYNOS_MIC=y
> > > > CONFIG_DRM_ROCKCHIP=m
> > > > +CONFIG_DRM_TIDSS=m
> > > > +CONFIG_DRM_DISPLAY_CONNECTOR=m
> > > > +CONFIG_DRM_CDNS_MHDP8546=m
> > >
> > > Please use savedefconfig to place the changes in the correct location
> > >
> >
> > Just to clarify the request, use "make savedefconfig" to generate a
> > defconfig, then based on that put _only_ the relevant changes in the
> > commit.
>
> Yup, thanks for clarifying.
> >
> > > Also indicate changes if any in vmlinux in commit message.
> > >
> >
> > Nishanth, what are you asking for here? Just a mentioning if this has
> > any impact to vmlinux (or is isolated to the modules selected), or are
> > you asking for anything specific?
>
> In this case, just ensure to state that vmlinux size has'nt
> changed, in case where we see a =y, we should indicate via
> ./scripts/bloat-o-meter change that is introduced and if yes, we
> should explain why this is fundamental to system boot.
>
> Why is this necessary? This is to prevent product specific
> configurations (such as early display banner, chime etc) from creeping
> and increasing vmlinux size which has an impact for all ARM SoCs.
>
Sounds very reasonable, I'll make sure to ask for such motivations in
the defconfig changes that I pick up through the Qualcomm tree as well.
Regards,
Bjorn
>
> [...]
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2022-02-22 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 18:07 [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e Rahul T R
2022-02-22 19:39 ` Nishanth Menon
2022-02-22 19:39 ` Nishanth Menon
2022-02-22 20:40 ` Bjorn Andersson
2022-02-22 20:40 ` Bjorn Andersson
2022-02-22 21:26 ` Nishanth Menon
2022-02-22 21:26 ` Nishanth Menon
2022-02-22 22:15 ` Bjorn Andersson [this message]
2022-02-22 22:15 ` Bjorn Andersson
2022-02-23 7:58 ` Rahul T R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhVgjFWShgc8btJP@ripper \
--to=bjorn.andersson@linaro.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=catalin.marinas@arm.com \
--cc=enric.balletbo@collabora.com \
--cc=geert+renesas@glider.be \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=nm@ti.com \
--cc=r-ravikumar@ti.com \
--cc=shawnguo@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.