All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ronak Jain <ronak.jain@xilinx.com>
Cc: michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
	rajan.vaja@xilinx.com, corbet@lwn.net,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	lakshmi.sai.krishna.potthuri@xilinx.com
Subject: Re: [PATCH v5 3/3] firmware: xilinx: Add sysfs support for feature config
Date: Fri, 25 Feb 2022 12:12:41 +0100	[thread overview]
Message-ID: <Yhi5qesqaZINe6QS@kroah.com> (raw)
In-Reply-To: <20220209082709.32378-4-ronak.jain@xilinx.com>

On Wed, Feb 09, 2022 at 12:27:09AM -0800, Ronak Jain wrote:
> Add support for sysfs interface for runtime features configuration.
>  The user can configure the features at runtime. First, the user need
>  to select the config id of the supported features and then the user
>  can configure the parameters of the feature based on the config id.
> 
> Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>

You are adding new sysfs files, without any Documentation/ABI/ entries.
That will cause errors when you run the scripts/get_abi.pl tool, right?

Please fix.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Ronak Jain <ronak.jain@xilinx.com>
Cc: michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
	rajan.vaja@xilinx.com, corbet@lwn.net,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	lakshmi.sai.krishna.potthuri@xilinx.com
Subject: Re: [PATCH v5 3/3] firmware: xilinx: Add sysfs support for feature config
Date: Fri, 25 Feb 2022 12:12:41 +0100	[thread overview]
Message-ID: <Yhi5qesqaZINe6QS@kroah.com> (raw)
In-Reply-To: <20220209082709.32378-4-ronak.jain@xilinx.com>

On Wed, Feb 09, 2022 at 12:27:09AM -0800, Ronak Jain wrote:
> Add support for sysfs interface for runtime features configuration.
>  The user can configure the features at runtime. First, the user need
>  to select the config id of the supported features and then the user
>  can configure the parameters of the feature based on the config id.
> 
> Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>

You are adding new sysfs files, without any Documentation/ABI/ entries.
That will cause errors when you run the scripts/get_abi.pl tool, right?

Please fix.

thanks,

greg k-h

  parent reply	other threads:[~2022-02-25 11:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09  8:27 [PATCH v5 0/3] Add support for runtime features Ronak Jain
2022-02-09  8:27 ` Ronak Jain
2022-02-09  8:27 ` [PATCH v5 1/3] firmware: xilinx: " Ronak Jain
2022-02-09  8:27   ` Ronak Jain
2022-02-09  9:27   ` Michal Simek
2022-02-09  9:27     ` Michal Simek
2022-02-09  8:27 ` [PATCH v5 2/3] firmware: zynqmp: Add documentation for runtime feature config Ronak Jain
2022-02-09  8:27   ` Ronak Jain
2022-02-09  9:29   ` Michal Simek
2022-02-09  9:29     ` Michal Simek
2022-02-25 11:13   ` Greg KH
2022-02-25 11:13     ` Greg KH
2022-02-09  8:27 ` [PATCH v5 3/3] firmware: xilinx: Add sysfs support for " Ronak Jain
2022-02-09  8:27   ` Ronak Jain
2022-02-09  9:29   ` Michal Simek
2022-02-09  9:29     ` Michal Simek
2022-02-25 11:12   ` Greg KH [this message]
2022-02-25 11:12     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yhi5qesqaZINe6QS@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=lakshmi.sai.krishna.potthuri@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=rajan.vaja@xilinx.com \
    --cc=ronak.jain@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.