From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: David Gow <davidgow@google.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-um@lists.infradead.org,
anton ivanov <anton.ivanov@cambridgegreys.com>
Subject: Re: [PATCH v2] Input: samsung-keypad - Properly state IOMEM dependency
Date: Sun, 27 Feb 2022 21:00:35 -0800 [thread overview]
Message-ID: <YhxW89ZYH6KgruvI@google.com> (raw)
In-Reply-To: <20220225041727.1902850-1-davidgow@google.com>
On Fri, Feb 25, 2022 at 12:17:27PM +0800, David Gow wrote:
> Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it
> calls devm_ioremap(). This prevents compile errors in some configs (e.g,
> allyesconfig/randconfig under UML):
>
> /usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
> samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
>
> Signed-off-by: David Gow <davidgow@google.com>
> Acked-by: anton ivanov <anton.ivanov@cambridgegreys.com>
Applied, thank you.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: David Gow <davidgow@google.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-um@lists.infradead.org,
anton ivanov <anton.ivanov@cambridgegreys.com>
Subject: Re: [PATCH v2] Input: samsung-keypad - Properly state IOMEM dependency
Date: Sun, 27 Feb 2022 21:00:35 -0800 [thread overview]
Message-ID: <YhxW89ZYH6KgruvI@google.com> (raw)
In-Reply-To: <20220225041727.1902850-1-davidgow@google.com>
On Fri, Feb 25, 2022 at 12:17:27PM +0800, David Gow wrote:
> Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it
> calls devm_ioremap(). This prevents compile errors in some configs (e.g,
> allyesconfig/randconfig under UML):
>
> /usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
> samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
>
> Signed-off-by: David Gow <davidgow@google.com>
> Acked-by: anton ivanov <anton.ivanov@cambridgegreys.com>
Applied, thank you.
--
Dmitry
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2022-02-28 5:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 4:17 [PATCH v2] Input: samsung-keypad - Properly state IOMEM dependency David Gow
2022-02-25 4:17 ` David Gow
2022-02-28 5:00 ` Dmitry Torokhov [this message]
2022-02-28 5:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhxW89ZYH6KgruvI@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=davidgow@google.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.