* [PATCH v2] Input: samsung-keypad - Properly state IOMEM dependency
@ 2022-02-25 4:17 ` David Gow
0 siblings, 0 replies; 4+ messages in thread
From: David Gow @ 2022-02-25 4:17 UTC (permalink / raw)
To: Joonyoung Shim, Dmitry Torokhov
Cc: David Gow, linux-input, linux-kernel, linux-um, anton ivanov
Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it
calls devm_ioremap(). This prevents compile errors in some configs (e.g,
allyesconfig/randconfig under UML):
/usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
Signed-off-by: David Gow <davidgow@google.com>
Acked-by: anton ivanov <anton.ivanov@cambridgegreys.com>
---
Changes since v1:
http://lists.infradead.org/pipermail/linux-um/2022-February/002264.html
- Fix to depend on HAS_IOMEM, not IOMEM
- Add Acked-by tag.
---
drivers/input/keyboard/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 0c607da9ee10..9417ee0b1eff 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -556,7 +556,7 @@ config KEYBOARD_PMIC8XXX
config KEYBOARD_SAMSUNG
tristate "Samsung keypad support"
- depends on HAVE_CLK
+ depends on HAS_IOMEM && HAVE_CLK
select INPUT_MATRIXKMAP
help
Say Y here if you want to use the keypad on your Samsung mobile
--
2.35.1.574.g5d30c73bfb-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] Input: samsung-keypad - Properly state IOMEM dependency
@ 2022-02-25 4:17 ` David Gow
0 siblings, 0 replies; 4+ messages in thread
From: David Gow @ 2022-02-25 4:17 UTC (permalink / raw)
To: Joonyoung Shim, Dmitry Torokhov
Cc: David Gow, linux-input, linux-kernel, linux-um, anton ivanov
Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it
calls devm_ioremap(). This prevents compile errors in some configs (e.g,
allyesconfig/randconfig under UML):
/usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
Signed-off-by: David Gow <davidgow@google.com>
Acked-by: anton ivanov <anton.ivanov@cambridgegreys.com>
---
Changes since v1:
http://lists.infradead.org/pipermail/linux-um/2022-February/002264.html
- Fix to depend on HAS_IOMEM, not IOMEM
- Add Acked-by tag.
---
drivers/input/keyboard/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 0c607da9ee10..9417ee0b1eff 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -556,7 +556,7 @@ config KEYBOARD_PMIC8XXX
config KEYBOARD_SAMSUNG
tristate "Samsung keypad support"
- depends on HAVE_CLK
+ depends on HAS_IOMEM && HAVE_CLK
select INPUT_MATRIXKMAP
help
Say Y here if you want to use the keypad on your Samsung mobile
--
2.35.1.574.g5d30c73bfb-goog
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Input: samsung-keypad - Properly state IOMEM dependency
2022-02-25 4:17 ` David Gow
@ 2022-02-28 5:00 ` Dmitry Torokhov
-1 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2022-02-28 5:00 UTC (permalink / raw)
To: David Gow
Cc: Joonyoung Shim, linux-input, linux-kernel, linux-um, anton ivanov
On Fri, Feb 25, 2022 at 12:17:27PM +0800, David Gow wrote:
> Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it
> calls devm_ioremap(). This prevents compile errors in some configs (e.g,
> allyesconfig/randconfig under UML):
>
> /usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
> samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
>
> Signed-off-by: David Gow <davidgow@google.com>
> Acked-by: anton ivanov <anton.ivanov@cambridgegreys.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Input: samsung-keypad - Properly state IOMEM dependency
@ 2022-02-28 5:00 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2022-02-28 5:00 UTC (permalink / raw)
To: David Gow
Cc: Joonyoung Shim, linux-input, linux-kernel, linux-um, anton ivanov
On Fri, Feb 25, 2022 at 12:17:27PM +0800, David Gow wrote:
> Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it
> calls devm_ioremap(). This prevents compile errors in some configs (e.g,
> allyesconfig/randconfig under UML):
>
> /usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
> samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
>
> Signed-off-by: David Gow <davidgow@google.com>
> Acked-by: anton ivanov <anton.ivanov@cambridgegreys.com>
Applied, thank you.
--
Dmitry
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-28 5:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-25 4:17 [PATCH v2] Input: samsung-keypad - Properly state IOMEM dependency David Gow
2022-02-25 4:17 ` David Gow
2022-02-28 5:00 ` Dmitry Torokhov
2022-02-28 5:00 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.