All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alifer Moraes <alifer.m@variscite.com>
Cc: pierluigi.p@variscite.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, nicoleotsuka@gmail.com,
	Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
	shengjiu.wang@gmail.com, tiwai@suse.com,
	linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
	eran.m@variscite.com, broonie@kernel.org,
	patches@opensource.cirrus.com, festevam@gmail.com
Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support
Date: Thu, 10 Mar 2022 14:51:13 -0600	[thread overview]
Message-ID: <YipkwW6rUbWweXn7@robh.at.kernel.org> (raw)
In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com>

On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote:
> From: Pierluigi Passaro <pierluigi.p@variscite.com>
> 
> The platform_data structure is not populated when using device trees.
> This patch adds optional dts properties to allow populating it:
> - gpio-cfg
> - mic-cfg
> - num-drc-cfgs
> - drc-cfg-regs
> - drc-cfg-names
> - num-retune-mobile-cfgs
> - retune-mobile-cfg-regs
> - retune-mobile-cfg-names
> - retune-mobile-cfg-rates

If you want to add all this, convert to DT schema first. 

They all need vendor prefixes for starters.

> 
> Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
> Signed-off-by: Alifer Moraes <alifer.m@variscite.com>
> ---
>  .../devicetree/bindings/sound/wm8904.txt      |  53 ++++++++
>  sound/soc/codecs/wm8904.c                     | 113 +++++++++++++++++-

Binding changes go in their own patches.

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alifer Moraes <alifer.m@variscite.com>
Cc: pierluigi.p@variscite.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, nicoleotsuka@gmail.com,
	Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
	shengjiu.wang@gmail.com, tiwai@suse.com,
	linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
	eran.m@variscite.com, broonie@kernel.org,
	patches@opensource.cirrus.com, perex@perex.cz,
	festevam@gmail.com
Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support
Date: Thu, 10 Mar 2022 14:51:13 -0600	[thread overview]
Message-ID: <YipkwW6rUbWweXn7@robh.at.kernel.org> (raw)
In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com>

On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote:
> From: Pierluigi Passaro <pierluigi.p@variscite.com>
> 
> The platform_data structure is not populated when using device trees.
> This patch adds optional dts properties to allow populating it:
> - gpio-cfg
> - mic-cfg
> - num-drc-cfgs
> - drc-cfg-regs
> - drc-cfg-names
> - num-retune-mobile-cfgs
> - retune-mobile-cfg-regs
> - retune-mobile-cfg-names
> - retune-mobile-cfg-rates

If you want to add all this, convert to DT schema first. 

They all need vendor prefixes for starters.

> 
> Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
> Signed-off-by: Alifer Moraes <alifer.m@variscite.com>
> ---
>  .../devicetree/bindings/sound/wm8904.txt      |  53 ++++++++
>  sound/soc/codecs/wm8904.c                     | 113 +++++++++++++++++-

Binding changes go in their own patches.

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alifer Moraes <alifer.m@variscite.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	broonie@kernel.org, devicetree@vger.kernel.org,
	eran.m@variscite.com, festevam@gmail.com, lgirdwood@gmail.com,
	linuxppc-dev@lists.ozlabs.org, nicoleotsuka@gmail.com,
	patches@opensource.cirrus.com, perex@perex.cz,
	pierluigi.p@variscite.com, shengjiu.wang@gmail.com,
	tiwai@suse.com, Xiubo.Lee@gmail.com
Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support
Date: Thu, 10 Mar 2022 14:51:13 -0600	[thread overview]
Message-ID: <YipkwW6rUbWweXn7@robh.at.kernel.org> (raw)
In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com>

On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote:
> From: Pierluigi Passaro <pierluigi.p@variscite.com>
> 
> The platform_data structure is not populated when using device trees.
> This patch adds optional dts properties to allow populating it:
> - gpio-cfg
> - mic-cfg
> - num-drc-cfgs
> - drc-cfg-regs
> - drc-cfg-names
> - num-retune-mobile-cfgs
> - retune-mobile-cfg-regs
> - retune-mobile-cfg-names
> - retune-mobile-cfg-rates

If you want to add all this, convert to DT schema first. 

They all need vendor prefixes for starters.

> 
> Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
> Signed-off-by: Alifer Moraes <alifer.m@variscite.com>
> ---
>  .../devicetree/bindings/sound/wm8904.txt      |  53 ++++++++
>  sound/soc/codecs/wm8904.c                     | 113 +++++++++++++++++-

Binding changes go in their own patches.

  parent reply	other threads:[~2022-03-10 20:52 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 14:10 [PATCH 1/4] ASoC: fsl-asoc-card: add WM8904 support Alifer Moraes
2022-03-07 14:10 ` Alifer Moraes
2022-03-07 14:10 ` Alifer Moraes
2022-03-07 14:10 ` [PATCH 2/4] ASoC: bindings: fsl-asoc-card: Add compatible string for wm8904 Alifer Moraes
2022-03-07 14:10   ` Alifer Moraes
2022-03-07 14:10   ` Alifer Moraes
2022-03-07 14:10 ` [PATCH 3/4] ASoC: wm8904: extend device tree support Alifer Moraes
2022-03-07 14:10   ` Alifer Moraes
2022-03-07 14:10   ` Alifer Moraes
2022-03-07 16:16   ` Mark Brown
2022-03-07 16:16     ` Mark Brown
2022-03-07 16:16     ` Mark Brown
2022-03-10 20:51   ` Rob Herring [this message]
2022-03-10 20:51     ` Rob Herring
2022-03-10 20:51     ` Rob Herring
2022-06-20 14:39     ` Pierluigi Passaro
2022-06-20 14:39       ` Pierluigi Passaro
2022-06-20 14:39       ` Pierluigi Passaro
2022-03-07 14:10 ` [PATCH 4/4] ASoC: wm8904: add DMIC support Alifer Moraes
2022-03-07 14:10   ` Alifer Moraes
2022-03-07 14:10   ` Alifer Moraes
2022-03-07 16:25   ` Mark Brown
2022-03-07 16:25     ` Mark Brown
2022-03-07 16:25     ` Mark Brown
2022-06-20 19:53   ` Pierluigi Passaro
2022-06-20 19:53     ` Pierluigi Passaro
2022-06-20 19:53     ` Pierluigi Passaro
2022-06-21 13:11     ` Mark Brown
2022-06-21 13:11       ` Mark Brown
2022-06-21 13:11       ` Mark Brown
2022-03-11 17:16 ` [PATCH 1/4] ASoC: fsl-asoc-card: add WM8904 support Mark Brown
2022-03-11 17:16   ` Mark Brown
2022-03-11 17:16   ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2022-06-20 14:32 [PATCH 3/4] ASoC: wm8904: extend device tree support Pierluigi Passaro
2022-06-20 14:32 ` Pierluigi Passaro
2022-06-20 14:32 ` Pierluigi Passaro
2022-06-20 15:12 ` Mark Brown
2022-06-20 15:12   ` Mark Brown
2022-06-20 15:12   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YipkwW6rUbWweXn7@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alifer.m@variscite.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eran.m@variscite.com \
    --cc=festevam@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=pierluigi.p@variscite.com \
    --cc=shengjiu.wang@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.