From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
tiwai@suse.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org,
broonie@kernel.org, linux-mediatek@lists.infradead.org,
yc.hung@mediatek.com, matthias.bgg@gmail.com, aaronyu@google.com,
linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682
Date: Mon, 21 Mar 2022 23:12:52 +0800 [thread overview]
Message-ID: <YjiV9DfLC7T1uweb@google.com> (raw)
In-Reply-To: <20220321072312.14972-6-trevor.wu@mediatek.com>
On Mon, Mar 21, 2022 at 03:23:11PM +0800, Trevor Wu wrote:
> diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c
[...]
> #define RT1011_SPEAKER_AMP_PRESENT BIT(0)
> #define RT1019_SPEAKER_AMP_PRESENT BIT(1)
> +#define MAX98390_SPEAKER_AMP_PRESENT BIT(2)
> +
> +#define MAX98390_CODEC_DAI "max98390-aif1"
> +#define MAX98390_DEV0_NAME "max98390.2-0038" /* right */
> +#define MAX98390_DEV1_NAME "max98390.2-0039" /* left */
>
> #define RT1011_CODEC_DAI "rt1011-aif"
> #define RT1011_DEV0_NAME "rt1011.2-0038"
The quirk bit order: RT1011, RT1019, and MAX98390. To be neat, move
MAX98390_CODEC_DAI, MAX98390_DEV0_NAME, and MAX98390_DEV1_NAME after
RT1019_DEV0_NAME to maintain the order.
> +static int mt8195_max98390_init(struct snd_soc_pcm_runtime *rtd)
[...]
> +
> + ret = snd_soc_dapm_add_routes(&card->dapm, mt8195_max98390_routes,
> + ARRAY_SIZE(mt8195_max98390_routes));
> +
> + if (ret)
Remove the extra blank line.
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org,
matthias.bgg@gmail.com, alsa-devel@alsa-project.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
aaronyu@google.com, angelogioacchino.delregno@collabora.com,
yc.hung@mediatek.com
Subject: Re: [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682
Date: Mon, 21 Mar 2022 23:12:52 +0800 [thread overview]
Message-ID: <YjiV9DfLC7T1uweb@google.com> (raw)
In-Reply-To: <20220321072312.14972-6-trevor.wu@mediatek.com>
On Mon, Mar 21, 2022 at 03:23:11PM +0800, Trevor Wu wrote:
> diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c
[...]
> #define RT1011_SPEAKER_AMP_PRESENT BIT(0)
> #define RT1019_SPEAKER_AMP_PRESENT BIT(1)
> +#define MAX98390_SPEAKER_AMP_PRESENT BIT(2)
> +
> +#define MAX98390_CODEC_DAI "max98390-aif1"
> +#define MAX98390_DEV0_NAME "max98390.2-0038" /* right */
> +#define MAX98390_DEV1_NAME "max98390.2-0039" /* left */
>
> #define RT1011_CODEC_DAI "rt1011-aif"
> #define RT1011_DEV0_NAME "rt1011.2-0038"
The quirk bit order: RT1011, RT1019, and MAX98390. To be neat, move
MAX98390_CODEC_DAI, MAX98390_DEV0_NAME, and MAX98390_DEV1_NAME after
RT1019_DEV0_NAME to maintain the order.
> +static int mt8195_max98390_init(struct snd_soc_pcm_runtime *rtd)
[...]
> +
> + ret = snd_soc_dapm_add_routes(&card->dapm, mt8195_max98390_routes,
> + ARRAY_SIZE(mt8195_max98390_routes));
> +
> + if (ret)
Remove the extra blank line.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org,
matthias.bgg@gmail.com, alsa-devel@alsa-project.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
aaronyu@google.com, angelogioacchino.delregno@collabora.com,
yc.hung@mediatek.com
Subject: Re: [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682
Date: Mon, 21 Mar 2022 23:12:52 +0800 [thread overview]
Message-ID: <YjiV9DfLC7T1uweb@google.com> (raw)
In-Reply-To: <20220321072312.14972-6-trevor.wu@mediatek.com>
On Mon, Mar 21, 2022 at 03:23:11PM +0800, Trevor Wu wrote:
> diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c
[...]
> #define RT1011_SPEAKER_AMP_PRESENT BIT(0)
> #define RT1019_SPEAKER_AMP_PRESENT BIT(1)
> +#define MAX98390_SPEAKER_AMP_PRESENT BIT(2)
> +
> +#define MAX98390_CODEC_DAI "max98390-aif1"
> +#define MAX98390_DEV0_NAME "max98390.2-0038" /* right */
> +#define MAX98390_DEV1_NAME "max98390.2-0039" /* left */
>
> #define RT1011_CODEC_DAI "rt1011-aif"
> #define RT1011_DEV0_NAME "rt1011.2-0038"
The quirk bit order: RT1011, RT1019, and MAX98390. To be neat, move
MAX98390_CODEC_DAI, MAX98390_DEV0_NAME, and MAX98390_DEV1_NAME after
RT1019_DEV0_NAME to maintain the order.
> +static int mt8195_max98390_init(struct snd_soc_pcm_runtime *rtd)
[...]
> +
> + ret = snd_soc_dapm_add_routes(&card->dapm, mt8195_max98390_routes,
> + ARRAY_SIZE(mt8195_max98390_routes));
> +
> + if (ret)
Remove the extra blank line.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org,
matthias.bgg@gmail.com, alsa-devel@alsa-project.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
aaronyu@google.com, angelogioacchino.delregno@collabora.com,
yc.hung@mediatek.com
Subject: Re: [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682
Date: Mon, 21 Mar 2022 23:12:52 +0800 [thread overview]
Message-ID: <YjiV9DfLC7T1uweb@google.com> (raw)
In-Reply-To: <20220321072312.14972-6-trevor.wu@mediatek.com>
On Mon, Mar 21, 2022 at 03:23:11PM +0800, Trevor Wu wrote:
> diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c
[...]
> #define RT1011_SPEAKER_AMP_PRESENT BIT(0)
> #define RT1019_SPEAKER_AMP_PRESENT BIT(1)
> +#define MAX98390_SPEAKER_AMP_PRESENT BIT(2)
> +
> +#define MAX98390_CODEC_DAI "max98390-aif1"
> +#define MAX98390_DEV0_NAME "max98390.2-0038" /* right */
> +#define MAX98390_DEV1_NAME "max98390.2-0039" /* left */
>
> #define RT1011_CODEC_DAI "rt1011-aif"
> #define RT1011_DEV0_NAME "rt1011.2-0038"
The quirk bit order: RT1011, RT1019, and MAX98390. To be neat, move
MAX98390_CODEC_DAI, MAX98390_DEV0_NAME, and MAX98390_DEV1_NAME after
RT1019_DEV0_NAME to maintain the order.
> +static int mt8195_max98390_init(struct snd_soc_pcm_runtime *rtd)
[...]
> +
> + ret = snd_soc_dapm_add_routes(&card->dapm, mt8195_max98390_routes,
> + ARRAY_SIZE(mt8195_max98390_routes));
> +
> + if (ret)
Remove the extra blank line.
next prev parent reply other threads:[~2022-03-21 15:14 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 7:23 [PATCH v3 0/6] ASoC: mediatek: Add support for MT8195 sound card with max98390 and rt5682 Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` [PATCH v3 1/6] ASoC: mediatek: mt8195: revise mt8195-mt6359-rt1019-rt5682.c Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 15:10 ` Tzung-Bi Shih
2022-03-21 15:10 ` Tzung-Bi Shih
2022-03-21 15:10 ` Tzung-Bi Shih
2022-03-21 15:10 ` Tzung-Bi Shih
2022-03-21 7:23 ` [PATCH v3 2/6] ASoC: mediatek: mt8195: merge machine driver Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-23 8:15 ` Trevor Wu
2022-03-23 8:15 ` Trevor Wu
2022-03-23 8:15 ` Trevor Wu
2022-03-23 8:15 ` Trevor Wu
2022-03-21 7:23 ` [PATCH v3 3/6] ASoC: dt-bindings: mediatek: mt8195: merge mt8195 machine yaml Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 23:30 ` Miles Chen
2022-03-21 23:30 ` Miles Chen
2022-03-21 23:30 ` Miles Chen
2022-03-21 23:30 ` Miles Chen
2022-03-23 7:27 ` Trevor Wu
2022-03-23 7:27 ` Trevor Wu
2022-03-23 7:27 ` Trevor Wu
2022-03-23 7:27 ` Trevor Wu
2022-03-21 7:23 ` [PATCH v3 4/6] ASoC: mediatek: mt8195: rename card controls Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-21 7:23 ` [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682 Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 15:12 ` Tzung-Bi Shih [this message]
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-21 15:12 ` Tzung-Bi Shih
2022-03-23 7:29 ` Trevor Wu
2022-03-23 7:29 ` Trevor Wu
2022-03-23 7:29 ` Trevor Wu
2022-03-23 7:29 ` Trevor Wu
2022-03-21 7:23 ` [PATCH v3 6/6] ASoC: dt-bindings: mediatek: mt8195: support mt8195-mt6359-max98390-rt5682 Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
2022-03-21 7:23 ` Trevor Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjiV9DfLC7T1uweb@google.com \
--to=tzungbi@kernel.org \
--cc=aaronyu@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.