All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings
Date: Thu, 31 Mar 2022 14:12:33 +0800	[thread overview]
Message-ID: <YkVGUbDCCCdn3vUH@03a72f3fb6af> (raw)
In-Reply-To: <202203311416.FRqOJZon-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Huan Feng <huan.feng@starfivetech.com>
CC: Emil Renner Berthing <kernel@esmil.dk>

From: kernel test robot <lkp@intel.com>

drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

CC: Huan Feng <huan.feng@starfivetech.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/esmil/linux visionfive
head:   6c7cd35771680c033c40b4af48cbe7e3093eab3d
commit: 1d3f42fdd786e76c5138aff9663180a7f17c68bd [28/62] drivers/hw_random: Add StarFive JH7100 Random Number Generator driver
:::::: branch date: 14 hours ago
:::::: commit date: 9 days ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/char/hw_random/starfive-vic-rng.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/hw_random/starfive-vic-rng.c
+++ b/drivers/char/hw_random/starfive-vic-rng.c
@@ -206,7 +206,6 @@ static int vic_rng_probe(struct platform
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq <= 0) {
-		dev_err(&pdev->dev, "Couldn't get irq %d\n", irq);
 		return irq;
 	}
 

  reply	other threads:[~2022-03-31  6:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  6:21 [esmil:visionfive 28/62] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error kernel test robot
2022-03-31  6:12 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-06-10 13:57 [esmil:visionfive 21/54] " kernel test robot
2022-06-10 13:52 ` [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings kernel test robot
2022-03-10 15:22 [esmil:visionfive 28/64] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error kernel test robot
2022-03-10 15:12 ` [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkVGUbDCCCdn3vUH@03a72f3fb6af \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.