* [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings
2022-03-10 15:22 [esmil:visionfive 28/64] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error kernel test robot
@ 2022-03-10 15:12 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-03-10 15:12 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Huan Feng <huan.feng@starfivetech.com>
CC: Emil Renner Berthing <kernel@esmil.dk>
From: kernel test robot <lkp@intel.com>
drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
CC: Huan Feng <huan.feng@starfivetech.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/esmil/linux visionfive
head: 996f88ea65b2f557926d7fe73d69fdc2da92430a
commit: 43592cbfb311e82075d50641a6359ed6c0a28ea1 [28/64] drivers/hw_random: Add StarFive JH7100 Random Number Generator driver
:::::: branch date: 19 hours ago
:::::: commit date: 4 days ago
Please take the patch only if it's a positive warning. Thanks!
drivers/char/hw_random/starfive-vic-rng.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/char/hw_random/starfive-vic-rng.c
+++ b/drivers/char/hw_random/starfive-vic-rng.c
@@ -206,7 +206,6 @@ static int vic_rng_probe(struct platform
irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
- dev_err(&pdev->dev, "Couldn't get irq %d\n", irq);
return irq;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings
2022-03-31 6:21 [esmil:visionfive 28/62] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error kernel test robot
@ 2022-03-31 6:12 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-03-31 6:12 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Huan Feng <huan.feng@starfivetech.com>
CC: Emil Renner Berthing <kernel@esmil.dk>
From: kernel test robot <lkp@intel.com>
drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
CC: Huan Feng <huan.feng@starfivetech.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/esmil/linux visionfive
head: 6c7cd35771680c033c40b4af48cbe7e3093eab3d
commit: 1d3f42fdd786e76c5138aff9663180a7f17c68bd [28/62] drivers/hw_random: Add StarFive JH7100 Random Number Generator driver
:::::: branch date: 14 hours ago
:::::: commit date: 9 days ago
Please take the patch only if it's a positive warning. Thanks!
drivers/char/hw_random/starfive-vic-rng.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/char/hw_random/starfive-vic-rng.c
+++ b/drivers/char/hw_random/starfive-vic-rng.c
@@ -206,7 +206,6 @@ static int vic_rng_probe(struct platform
irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
- dev_err(&pdev->dev, "Couldn't get irq %d\n", irq);
return irq;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* [esmil:visionfive 28/62] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error
@ 2022-03-31 6:21 kernel test robot
2022-03-31 6:12 ` [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings kernel test robot
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2022-03-31 6:21 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Huan Feng <huan.feng@starfivetech.com>
CC: Emil Renner Berthing <kernel@esmil.dk>
tree: https://github.com/esmil/linux visionfive
head: 6c7cd35771680c033c40b4af48cbe7e3093eab3d
commit: 1d3f42fdd786e76c5138aff9663180a7f17c68bd [28/62] drivers/hw_random: Add StarFive JH7100 Random Number Generator driver
:::::: branch date: 14 hours ago
:::::: commit date: 9 days ago
config: nios2-randconfig-c003-20220331 (https://download.01.org/0day-ci/archive/20220331/202203311416.FRqOJZon-lkp(a)intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error
Please review and possibly fold the followup patch.
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings
2022-06-10 13:57 [esmil:visionfive 21/54] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error kernel test robot
@ 2022-06-10 13:52 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-06-10 13:52 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Huan Feng <huan.feng@starfivetech.com>
CC: Emil Renner Berthing <kernel@esmil.dk>
From: kernel test robot <lkp@intel.com>
drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
CC: Huan Feng <huan.feng@starfivetech.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/esmil/linux visionfive
head: 906be7ef2fb9e2f1fcb740d3d506768cddfc52ca
commit: b422a122c72a7448306ad60808c748d57b98da71 [21/54] drivers/hw_random: Add StarFive JH7100 Random Number Generator driver
:::::: branch date: 3 days ago
:::::: commit date: 4 days ago
Please take the patch only if it's a positive warning. Thanks!
drivers/char/hw_random/starfive-vic-rng.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/char/hw_random/starfive-vic-rng.c
+++ b/drivers/char/hw_random/starfive-vic-rng.c
@@ -206,7 +206,6 @@ static int vic_rng_probe(struct platform
irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
- dev_err(&pdev->dev, "Couldn't get irq %d\n", irq);
return irq;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-10 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-31 6:21 [esmil:visionfive 28/62] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error kernel test robot
2022-03-31 6:12 ` [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-06-10 13:57 [esmil:visionfive 21/54] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error kernel test robot
2022-06-10 13:52 ` [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings kernel test robot
2022-03-10 15:22 [esmil:visionfive 28/64] drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant because platform_get_irq() already prints an error kernel test robot
2022-03-10 15:12 ` [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.