From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Austin Kim <austindh.kim@gmail.com>
Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, austin.kim@lge.com,
p4ranlee@gmail.com
Subject: Re: [PATCH] arm: kdump: add invalid value check for 'crashkernel='
Date: Thu, 31 Mar 2022 08:10:23 +0100 [thread overview]
Message-ID: <YkVT3z4ksYStau85@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220330110715.GA1534@raspberrypi>
On Wed, Mar 30, 2022 at 12:07:15PM +0100, Austin Kim wrote:
> From: Austin Kim <austin.kim@lge.com>
>
> Add invalid value check expression when no crashkernel= or invalid value
> specified using kdump.
Hi,
I think you mean when "crashkernel=0" is specified, as other invalid
input should result in -EINVAL being returned. Please update the
patch description and comment.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Austin Kim <austindh.kim@gmail.com>
Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, austin.kim@lge.com,
p4ranlee@gmail.com
Subject: Re: [PATCH] arm: kdump: add invalid value check for 'crashkernel='
Date: Thu, 31 Mar 2022 08:10:23 +0100 [thread overview]
Message-ID: <YkVT3z4ksYStau85@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220330110715.GA1534@raspberrypi>
On Wed, Mar 30, 2022 at 12:07:15PM +0100, Austin Kim wrote:
> From: Austin Kim <austin.kim@lge.com>
>
> Add invalid value check expression when no crashkernel= or invalid value
> specified using kdump.
Hi,
I think you mean when "crashkernel=0" is specified, as other invalid
input should result in -EINVAL being returned. Please update the
patch description and comment.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-03-31 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 11:07 [PATCH] arm: kdump: add invalid value check for 'crashkernel=' Austin Kim
2022-03-30 11:07 ` Austin Kim
2022-03-31 7:10 ` Russell King (Oracle) [this message]
2022-03-31 7:10 ` Russell King (Oracle)
2022-03-31 9:49 ` Austin Kim
2022-03-31 9:49 ` Austin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkVT3z4ksYStau85@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=austin.kim@lge.com \
--cc=austindh.kim@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p4ranlee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.