From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: "Pali Rohár" <pali@kernel.org>, "Rob Herring" <robh+dt@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Marek Behún" <kabel@kernel.org>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property
Date: Fri, 8 Apr 2022 11:31:52 +0100 [thread overview]
Message-ID: <YlAPGCSQraPJA3bV@lpieralisi> (raw)
In-Reply-To: <20220325093827.4983-3-pali@kernel.org>
On Fri, Mar 25, 2022 at 10:38:25AM +0100, Pali Rohár wrote:
> This property specifies slot power limit in mW unit. It is a form-factor
> and board specific value and must be initialized by hardware.
>
> Some PCIe controllers delegate this work to software to allow hardware
> flexibility and therefore this property basically specifies what should
> host bridge program into PCIe Slot Capabilities registers.
>
> The property needs to be specified in mW unit instead of the special format
> defined by Slot Capabilities (which encodes scaling factor or different
> unit). Host drivers should convert the value from mW to needed format.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <kabel@kernel.org>
>
> ---
> This change was already accepted into dt-schema repo by Rob Herring:
> https://github.com/devicetree-org/dt-schema/pull/66
Is there a way I can check a DT binding was pulled into the schema
without having to read the patch (eg just checking Rob's Acked/Reviewed
tags ?)
I think this patch should have been posted to
devicetree@vger.kernel.org, by the way.
Lorenzo
> Documentation/devicetree/bindings/pci/pci.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
> index 6a8f2874a24d..b0cc133ed00d 100644
> --- a/Documentation/devicetree/bindings/pci/pci.txt
> +++ b/Documentation/devicetree/bindings/pci/pci.txt
> @@ -32,6 +32,12 @@ driver implementation may support the following properties:
> root port to downstream device and host bridge drivers can do programming
> which depends on CLKREQ signal existence. For example, programming root port
> not to advertise ASPM L1 Sub-States support if there is no CLKREQ signal.
> +- slot-power-limit-milliwatt:
> + If present, this property specifies slot power limit in milliwatts. Host
> + drivers can parse this property and use it for programming Root Port or host
> + bridge, or for composing and sending PCIe Set_Slot_Power_Limit messages
> + through the Root Port or host bridge when transitioning PCIe link from a
> + non-DL_Up Status to a DL_Up Status.
>
> PCI-PCI Bridge properties
> -------------------------
> --
> 2.20.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: "Pali Rohár" <pali@kernel.org>, "Rob Herring" <robh+dt@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Marek Behún" <kabel@kernel.org>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property
Date: Fri, 8 Apr 2022 11:31:52 +0100 [thread overview]
Message-ID: <YlAPGCSQraPJA3bV@lpieralisi> (raw)
In-Reply-To: <20220325093827.4983-3-pali@kernel.org>
On Fri, Mar 25, 2022 at 10:38:25AM +0100, Pali Rohár wrote:
> This property specifies slot power limit in mW unit. It is a form-factor
> and board specific value and must be initialized by hardware.
>
> Some PCIe controllers delegate this work to software to allow hardware
> flexibility and therefore this property basically specifies what should
> host bridge program into PCIe Slot Capabilities registers.
>
> The property needs to be specified in mW unit instead of the special format
> defined by Slot Capabilities (which encodes scaling factor or different
> unit). Host drivers should convert the value from mW to needed format.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <kabel@kernel.org>
>
> ---
> This change was already accepted into dt-schema repo by Rob Herring:
> https://github.com/devicetree-org/dt-schema/pull/66
Is there a way I can check a DT binding was pulled into the schema
without having to read the patch (eg just checking Rob's Acked/Reviewed
tags ?)
I think this patch should have been posted to
devicetree@vger.kernel.org, by the way.
Lorenzo
> Documentation/devicetree/bindings/pci/pci.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
> index 6a8f2874a24d..b0cc133ed00d 100644
> --- a/Documentation/devicetree/bindings/pci/pci.txt
> +++ b/Documentation/devicetree/bindings/pci/pci.txt
> @@ -32,6 +32,12 @@ driver implementation may support the following properties:
> root port to downstream device and host bridge drivers can do programming
> which depends on CLKREQ signal existence. For example, programming root port
> not to advertise ASPM L1 Sub-States support if there is no CLKREQ signal.
> +- slot-power-limit-milliwatt:
> + If present, this property specifies slot power limit in milliwatts. Host
> + drivers can parse this property and use it for programming Root Port or host
> + bridge, or for composing and sending PCIe Set_Slot_Power_Limit messages
> + through the Root Port or host bridge when transitioning PCIe link from a
> + non-DL_Up Status to a DL_Up Status.
>
> PCI-PCI Bridge properties
> -------------------------
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-08 10:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 9:38 [PATCH v3 0/4] PCI: mvebu: Slot support Pali Rohár
2022-03-25 9:38 ` Pali Rohár
2022-03-25 9:38 ` [PATCH v3 1/4] PCI: Add PCI_EXP_SLTCTL_ASPL_DISABLE macro Pali Rohár
2022-03-25 9:38 ` Pali Rohár
2022-03-25 9:38 ` [PATCH v3 2/4] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property Pali Rohár
2022-03-25 9:38 ` Pali Rohár
2022-04-08 10:31 ` Lorenzo Pieralisi [this message]
2022-04-08 10:31 ` Lorenzo Pieralisi
2022-03-25 9:38 ` [PATCH v3 3/4] PCI: Add function for parsing 'slot-power-limit-milliwatt' DT property Pali Rohár
2022-03-25 9:38 ` Pali Rohár
2022-04-08 15:27 ` Bjorn Helgaas
2022-04-08 15:27 ` Bjorn Helgaas
2022-04-11 11:14 ` Pali Rohár
2022-04-11 11:14 ` Pali Rohár
2022-04-11 19:02 ` Pali Rohár
2022-04-11 19:02 ` Pali Rohár
2022-04-11 19:54 ` Bjorn Helgaas
2022-04-11 19:54 ` Bjorn Helgaas
2022-10-27 19:05 ` Bjorn Helgaas
2022-10-27 19:05 ` Bjorn Helgaas
2022-03-25 9:38 ` [PATCH v3 4/4] PCI: mvebu: Add support for sending Set_Slot_Power_Limit message Pali Rohár
2022-03-25 9:38 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlAPGCSQraPJA3bV@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=kabel@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pali@kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.