From: Christoph Hellwig <hch@infradead.org>
To: Mike Snitzer <snitzer@kernel.org>
Cc: axboe@kernel.dk, Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, dm-devel@redhat.com, tj@kernel.org,
Dennis Zhou <dennis@kernel.org>
Subject: Re: [dm-devel] [PATCH] block: remove redundant blk-cgroup init from __bio_clone
Date: Mon, 11 Apr 2022 22:27:54 -0700 [thread overview]
Message-ID: <YlUN2pVsIn1dbzHg@infradead.org> (raw)
In-Reply-To: <YlRmhlL8TtQow0W0@redhat.com>
On Mon, Apr 11, 2022 at 01:33:58PM -0400, Mike Snitzer wrote:
> When bio_{alloc,init}_clone are passed a bdev, bio_init() will call
> bio_associate_blkg() so the __bio_clone() work to initialize blkcg
> isn't needed.
No, unfortunately it isn't as simple as that. There are bios that do
not use the default cgroup and thus blkg, e.g. those that come from
cgroup writeback.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Mike Snitzer <snitzer@kernel.org>
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Dennis Zhou <dennis@kernel.org>,
tj@kernel.org, axboe@kernel.dk, dm-devel@redhat.com
Subject: Re: [PATCH] block: remove redundant blk-cgroup init from __bio_clone
Date: Mon, 11 Apr 2022 22:27:54 -0700 [thread overview]
Message-ID: <YlUN2pVsIn1dbzHg@infradead.org> (raw)
In-Reply-To: <YlRmhlL8TtQow0W0@redhat.com>
On Mon, Apr 11, 2022 at 01:33:58PM -0400, Mike Snitzer wrote:
> When bio_{alloc,init}_clone are passed a bdev, bio_init() will call
> bio_associate_blkg() so the __bio_clone() work to initialize blkcg
> isn't needed.
No, unfortunately it isn't as simple as that. There are bios that do
not use the default cgroup and thus blkg, e.g. those that come from
cgroup writeback.
next prev parent reply other threads:[~2022-04-12 5:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 16:52 [dm-devel] can we reduce bio_set_dev overhead due to bio_associate_blkg? Mike Snitzer
2022-03-30 16:52 ` Mike Snitzer
2022-03-30 12:28 ` [dm-devel] " Dennis Zhou
2022-03-30 12:28 ` Dennis Zhou
2022-03-31 4:39 ` [dm-devel] " Christoph Hellwig
2022-03-31 4:39 ` Christoph Hellwig
2022-03-31 5:52 ` [dm-devel] " Dennis Zhou
2022-03-31 5:52 ` Dennis Zhou
2022-03-31 9:15 ` [dm-devel] " Christoph Hellwig
2022-03-31 9:15 ` Christoph Hellwig
2022-04-08 15:42 ` [dm-devel] " Mike Snitzer
2022-04-08 15:42 ` Mike Snitzer
2022-04-09 5:15 ` [dm-devel] " Christoph Hellwig
2022-04-09 5:15 ` Christoph Hellwig
2022-04-11 16:58 ` [dm-devel] " Mike Snitzer
2022-04-11 16:58 ` Mike Snitzer
2022-04-11 17:16 ` [dm-devel] " Mike Snitzer
2022-04-11 17:16 ` Mike Snitzer
2022-04-11 17:33 ` [dm-devel] [PATCH] block: remove redundant blk-cgroup init from __bio_clone Mike Snitzer
2022-04-11 17:33 ` Mike Snitzer
2022-04-12 5:27 ` Christoph Hellwig [this message]
2022-04-12 5:27 ` Christoph Hellwig
2022-04-12 7:52 ` [dm-devel] " Dennis Zhou
2022-04-12 7:52 ` Dennis Zhou
2022-04-23 16:55 ` [dm-devel] " Christoph Hellwig
2022-04-23 16:55 ` Christoph Hellwig
2022-04-26 17:30 ` [dm-devel] " Mike Snitzer
2022-04-26 17:30 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlUN2pVsIn1dbzHg@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dennis@kernel.org \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.