All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	dm-devel@redhat.com, Dennis Zhou <dennis@kernel.org>,
	tj@kernel.org
Subject: Re: [dm-devel] block: remove redundant blk-cgroup init from __bio_clone
Date: Tue, 26 Apr 2022 13:30:08 -0400	[thread overview]
Message-ID: <YmgsIA9asIxxpRlt@redhat.com> (raw)
In-Reply-To: <YmQvgdqHlsQVpxR+@infradead.org>

On Sat, Apr 23 2022 at 12:55P -0400,
Christoph Hellwig <hch@infradead.org> wrote:

> So while I'm still diving into the somewhat invasive changes to
> optimize some of the cloning all we might relaly need for your
> use case should be this:
> 
> http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/blk-clone-no-bdev
> 
> Can you check if this helps you?

Passing NULL will be useful for targets that do call bio_set_dev() but
there are some that inherit the original bdev.  I'll audit all targets
and sort out how best to handle the conditional initialization to
avoid needless work.

This change is useful and a requirement for relevant follow-on DM
changes:

Reviewed-by: Mike Snitzer <snitzer@kernel.org>

Thanks.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	dm-devel@redhat.com, tj@kernel.org,
	Dennis Zhou <dennis@kernel.org>
Subject: Re: block: remove redundant blk-cgroup init from __bio_clone
Date: Tue, 26 Apr 2022 13:30:08 -0400	[thread overview]
Message-ID: <YmgsIA9asIxxpRlt@redhat.com> (raw)
In-Reply-To: <YmQvgdqHlsQVpxR+@infradead.org>

On Sat, Apr 23 2022 at 12:55P -0400,
Christoph Hellwig <hch@infradead.org> wrote:

> So while I'm still diving into the somewhat invasive changes to
> optimize some of the cloning all we might relaly need for your
> use case should be this:
> 
> http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/blk-clone-no-bdev
> 
> Can you check if this helps you?

Passing NULL will be useful for targets that do call bio_set_dev() but
there are some that inherit the original bdev.  I'll audit all targets
and sort out how best to handle the conditional initialization to
avoid needless work.

This change is useful and a requirement for relevant follow-on DM
changes:

Reviewed-by: Mike Snitzer <snitzer@kernel.org>

Thanks.

  reply	other threads:[~2022-04-26 17:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30 16:52 [dm-devel] can we reduce bio_set_dev overhead due to bio_associate_blkg? Mike Snitzer
2022-03-30 16:52 ` Mike Snitzer
2022-03-30 12:28 ` [dm-devel] " Dennis Zhou
2022-03-30 12:28   ` Dennis Zhou
2022-03-31  4:39   ` [dm-devel] " Christoph Hellwig
2022-03-31  4:39     ` Christoph Hellwig
2022-03-31  5:52     ` [dm-devel] " Dennis Zhou
2022-03-31  5:52       ` Dennis Zhou
2022-03-31  9:15       ` [dm-devel] " Christoph Hellwig
2022-03-31  9:15         ` Christoph Hellwig
2022-04-08 15:42         ` [dm-devel] " Mike Snitzer
2022-04-08 15:42           ` Mike Snitzer
2022-04-09  5:15           ` [dm-devel] " Christoph Hellwig
2022-04-09  5:15             ` Christoph Hellwig
2022-04-11 16:58             ` [dm-devel] " Mike Snitzer
2022-04-11 16:58               ` Mike Snitzer
2022-04-11 17:16               ` [dm-devel] " Mike Snitzer
2022-04-11 17:16                 ` Mike Snitzer
2022-04-11 17:33                 ` [dm-devel] [PATCH] block: remove redundant blk-cgroup init from __bio_clone Mike Snitzer
2022-04-11 17:33                   ` Mike Snitzer
2022-04-12  5:27                   ` [dm-devel] " Christoph Hellwig
2022-04-12  5:27                     ` Christoph Hellwig
2022-04-12  7:52                     ` [dm-devel] " Dennis Zhou
2022-04-12  7:52                       ` Dennis Zhou
2022-04-23 16:55                   ` [dm-devel] " Christoph Hellwig
2022-04-23 16:55                     ` Christoph Hellwig
2022-04-26 17:30                     ` Mike Snitzer [this message]
2022-04-26 17:30                       ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmgsIA9asIxxpRlt@redhat.com \
    --to=snitzer@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dennis@kernel.org \
    --cc=dm-devel@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.