All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "qinjian[覃健]" <qinjian@cqplus1.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"maz@kernel.org" <maz@kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
Date: Thu, 14 Apr 2022 10:18:58 -0500	[thread overview]
Message-ID: <Ylg7Yl9GmgpOFipk@robh.at.kernel.org> (raw)
In-Reply-To: <b1b85440f7d647a0adf014b091e31c10@cqplus1.com>

On Thu, Apr 14, 2022 at 07:06:12AM +0000, qinjian[覃健] wrote:
> 
> > > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> > > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> > > +
> > > +#define XTAL            27000000
> > 
> > This looks like frequency which usually does not belong to bindings. Why
> > do you need it here?
> > 
> 
> OK, I'll remove it.

If that's the input frequency to the clock controller and it could 
possibly change, then it should be defined in DT with a 'fixed-clock' 
node and 'clocks' property in the clock controller.

Rob


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "qinjian[覃健]" <qinjian@cqplus1.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"maz@kernel.org" <maz@kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
Date: Thu, 14 Apr 2022 10:18:58 -0500	[thread overview]
Message-ID: <Ylg7Yl9GmgpOFipk@robh.at.kernel.org> (raw)
In-Reply-To: <b1b85440f7d647a0adf014b091e31c10@cqplus1.com>

On Thu, Apr 14, 2022 at 07:06:12AM +0000, qinjian[覃健] wrote:
> 
> > > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> > > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> > > +
> > > +#define XTAL            27000000
> > 
> > This looks like frequency which usually does not belong to bindings. Why
> > do you need it here?
> > 
> 
> OK, I'll remove it.

If that's the input frequency to the clock controller and it could 
possibly change, then it should be defined in DT with a 'fixed-clock' 
node and 'clocks' property in the clock controller.

Rob


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-14 16:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11  6:49 [PATCH v13 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-04-11  6:49 ` Qin Jian
2022-04-11  6:49 ` [PATCH v13 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-04-11  6:49   ` Qin Jian
2022-04-13  6:34   ` Krzysztof Kozlowski
2022-04-13  6:34     ` Krzysztof Kozlowski
2022-04-11  6:49 ` [PATCH v13 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-04-11  6:49   ` Qin Jian
2022-04-12 22:06   ` Rob Herring
2022-04-12 22:06     ` Rob Herring
2022-04-13  6:35   ` Krzysztof Kozlowski
2022-04-13  6:35     ` Krzysztof Kozlowski
2022-04-11  6:49 ` [PATCH v13 3/9] reset: Add Sunplus " Qin Jian
2022-04-11  6:49   ` Qin Jian
2022-04-11  6:49 ` [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-04-11  6:49   ` Qin Jian
2022-04-13  6:37   ` Krzysztof Kozlowski
2022-04-13  6:37     ` Krzysztof Kozlowski
2022-04-14  7:06     ` qinjian[覃健]
2022-04-14  7:06       ` qinjian[覃健]
2022-04-14 15:18       ` Rob Herring [this message]
2022-04-14 15:18         ` Rob Herring
2022-04-11  6:49 ` [PATCH v13 5/9] clk: Add Sunplus " Qin Jian
2022-04-11  6:49   ` Qin Jian
2022-04-11 22:57   ` kernel test robot
2022-04-11 22:57     ` kernel test robot
2022-04-11  6:49 ` [PATCH v13 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-04-11  6:49   ` Qin Jian
2022-04-11  6:49 ` [PATCH v13 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-04-11  6:49   ` Qin Jian
2022-04-12  9:28   ` kernel test robot
2022-04-12  9:28     ` kernel test robot
2022-04-11  6:49 ` [PATCH v13 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-04-11  6:49   ` Qin Jian
2022-04-11  6:49 ` [PATCH v13 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-04-11  6:49   ` Qin Jian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ylg7Yl9GmgpOFipk@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maz@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=qinjian@cqplus1.com \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.