All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Mike Snitzer <msnitzer@redhat.com>,
	dm-devel@redhat.com, stable@vger.kernel.org
Subject: Re: [dm-devel] [PATCH v5.10] dm: fix mempool NULL pointer race when completing IO
Date: Tue, 26 Apr 2022 08:42:36 +0200	[thread overview]
Message-ID: <YmeUXC3DZGLPJlWw@kroah.com> (raw)
In-Reply-To: <alpine.LRH.2.02.2204211407220.761@file01.intranet.prod.int.rdu2.redhat.com>

On Thu, Apr 21, 2022 at 02:08:30PM -0400, Mikulas Patocka wrote:
> Hi

Not really needed in a changelog text :)

> This is backport of patches d208b89401e0 ("dm: fix mempool NULL pointer
> race when completing IO") and 9f6dc6337610 ("dm: interlock pending dm_io
> and dm_wait_for_bios_completion") for the kernel 5.10.

Can you just make these 2 different patches?

> 
> The bugs fixed by these patches can cause random crashing when reloading
> dm table, so it is eligible for stable backport.
> 
> This patch is different from the upstream patches because the code
> diverged significantly.
> 

This change is _VERY_ different.  I would need acks from the maintainers
of this code before I could accept this, along with a much more detailed
description of why the original commits will not work here as well.

Same for the other backports.

thanks,

greg k-h

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org, Mike Snitzer <msnitzer@redhat.com>,
	dm-devel@redhat.com
Subject: Re: [PATCH v5.10] dm: fix mempool NULL pointer race when completing IO
Date: Tue, 26 Apr 2022 08:42:36 +0200	[thread overview]
Message-ID: <YmeUXC3DZGLPJlWw@kroah.com> (raw)
In-Reply-To: <alpine.LRH.2.02.2204211407220.761@file01.intranet.prod.int.rdu2.redhat.com>

On Thu, Apr 21, 2022 at 02:08:30PM -0400, Mikulas Patocka wrote:
> Hi

Not really needed in a changelog text :)

> This is backport of patches d208b89401e0 ("dm: fix mempool NULL pointer
> race when completing IO") and 9f6dc6337610 ("dm: interlock pending dm_io
> and dm_wait_for_bios_completion") for the kernel 5.10.

Can you just make these 2 different patches?

> 
> The bugs fixed by these patches can cause random crashing when reloading
> dm table, so it is eligible for stable backport.
> 
> This patch is different from the upstream patches because the code
> diverged significantly.
> 

This change is _VERY_ different.  I would need acks from the maintainers
of this code before I could accept this, along with a much more detailed
description of why the original commits will not work here as well.

Same for the other backports.

thanks,

greg k-h

  reply	other threads:[~2022-04-26  6:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 18:08 [dm-devel] [PATCH v5.10] dm: fix mempool NULL pointer race when completing IO Mikulas Patocka
2022-04-21 18:08 ` Mikulas Patocka
2022-04-26  6:42 ` Greg Kroah-Hartman [this message]
2022-04-26  6:42   ` Greg Kroah-Hartman
2022-04-28 16:22   ` [dm-devel] " Mikulas Patocka
2022-04-28 16:22     ` Mikulas Patocka
2022-04-29  8:37     ` Greg Kroah-Hartman
2022-04-29  8:37       ` Greg Kroah-Hartman
2022-05-03 18:32       ` Mike Snitzer
2022-05-03 18:32         ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmeUXC3DZGLPJlWw@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=msnitzer@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.