From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples
Date: Wed, 27 Apr 2022 13:44:52 -0500 [thread overview]
Message-ID: <YmmPJLcI7PnsBtXn@robh.at.kernel.org> (raw)
In-Reply-To: <CACPK8XcQNJNyzqdjMQuCP+z-L-A9mcMqs-HJJrh9MscasV+D=A@mail.gmail.com>
On Wed, Apr 27, 2022 at 08:40:31AM +0000, Joel Stanley wrote:
> On Fri, 22 Apr 2022 at 19:21, Rob Herring <robh@kernel.org> wrote:
> >
> > The additional nodes in the example referenced from the pinctrl node
> > 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc)
> > or not documented with a schema (aspeed,ast2500-gfx). There's no need to
> > show these nodes as part of the pinctrl example, so just remove them.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Nak.
I welcome patches that add schemas for the undocumented compatibles
instead. Otherwise, I will be turning on this check by default and
nagging people to fix them.
> This removes the information on how to use the bindings. Surely we
> prefer to over document rather than under document?
How is what the 'gfx' and 'lpc' nodes contain relevant to how the
pinctrl binding works? If a user wants to know, then they should go look
at the aspeed,ast2500-lpc/aspeed,ast2500-gfx bindings and their
examples. Which brings up my secondary issue which is having the same
example multiple times. It is multiple chances for errors (that I end
up fixing).
How do we know the example is even correct without any schema checks?
The 'framebuffer' node is not in a valid location is the most obvious
thing I see.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples
Date: Wed, 27 Apr 2022 13:44:52 -0500 [thread overview]
Message-ID: <YmmPJLcI7PnsBtXn@robh.at.kernel.org> (raw)
In-Reply-To: <CACPK8XcQNJNyzqdjMQuCP+z-L-A9mcMqs-HJJrh9MscasV+D=A@mail.gmail.com>
On Wed, Apr 27, 2022 at 08:40:31AM +0000, Joel Stanley wrote:
> On Fri, 22 Apr 2022 at 19:21, Rob Herring <robh@kernel.org> wrote:
> >
> > The additional nodes in the example referenced from the pinctrl node
> > 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc)
> > or not documented with a schema (aspeed,ast2500-gfx). There's no need to
> > show these nodes as part of the pinctrl example, so just remove them.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Nak.
I welcome patches that add schemas for the undocumented compatibles
instead. Otherwise, I will be turning on this check by default and
nagging people to fix them.
> This removes the information on how to use the bindings. Surely we
> prefer to over document rather than under document?
How is what the 'gfx' and 'lpc' nodes contain relevant to how the
pinctrl binding works? If a user wants to know, then they should go look
at the aspeed,ast2500-lpc/aspeed,ast2500-gfx bindings and their
examples. Which brings up my secondary issue which is having the same
example multiple times. It is multiple chances for errors (that I end
up fixing).
How do we know the example is even correct without any schema checks?
The 'framebuffer' node is not in a valid location is the most obvious
thing I see.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Joel Stanley <joel@jms.id.au>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Andrew Jeffery <andrew@aj.id.au>,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples
Date: Wed, 27 Apr 2022 13:44:52 -0500 [thread overview]
Message-ID: <YmmPJLcI7PnsBtXn@robh.at.kernel.org> (raw)
In-Reply-To: <CACPK8XcQNJNyzqdjMQuCP+z-L-A9mcMqs-HJJrh9MscasV+D=A@mail.gmail.com>
On Wed, Apr 27, 2022 at 08:40:31AM +0000, Joel Stanley wrote:
> On Fri, 22 Apr 2022 at 19:21, Rob Herring <robh@kernel.org> wrote:
> >
> > The additional nodes in the example referenced from the pinctrl node
> > 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc)
> > or not documented with a schema (aspeed,ast2500-gfx). There's no need to
> > show these nodes as part of the pinctrl example, so just remove them.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Nak.
I welcome patches that add schemas for the undocumented compatibles
instead. Otherwise, I will be turning on this check by default and
nagging people to fix them.
> This removes the information on how to use the bindings. Surely we
> prefer to over document rather than under document?
How is what the 'gfx' and 'lpc' nodes contain relevant to how the
pinctrl binding works? If a user wants to know, then they should go look
at the aspeed,ast2500-lpc/aspeed,ast2500-gfx bindings and their
examples. Which brings up my secondary issue which is having the same
example multiple times. It is multiple chances for errors (that I end
up fixing).
How do we know the example is even correct without any schema checks?
The 'framebuffer' node is not in a valid location is the most obvious
thing I see.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples
Date: Wed, 27 Apr 2022 13:44:52 -0500 [thread overview]
Message-ID: <YmmPJLcI7PnsBtXn@robh.at.kernel.org> (raw)
In-Reply-To: <CACPK8XcQNJNyzqdjMQuCP+z-L-A9mcMqs-HJJrh9MscasV+D=A@mail.gmail.com>
On Wed, Apr 27, 2022 at 08:40:31AM +0000, Joel Stanley wrote:
> On Fri, 22 Apr 2022 at 19:21, Rob Herring <robh@kernel.org> wrote:
> >
> > The additional nodes in the example referenced from the pinctrl node
> > 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc)
> > or not documented with a schema (aspeed,ast2500-gfx). There's no need to
> > show these nodes as part of the pinctrl example, so just remove them.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Nak.
I welcome patches that add schemas for the undocumented compatibles
instead. Otherwise, I will be turning on this check by default and
nagging people to fix them.
> This removes the information on how to use the bindings. Surely we
> prefer to over document rather than under document?
How is what the 'gfx' and 'lpc' nodes contain relevant to how the
pinctrl binding works? If a user wants to know, then they should go look
at the aspeed,ast2500-lpc/aspeed,ast2500-gfx bindings and their
examples. Which brings up my secondary issue which is having the same
example multiple times. It is multiple chances for errors (that I end
up fixing).
How do we know the example is even correct without any schema checks?
The 'framebuffer' node is not in a valid location is the most obvious
thing I see.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-27 18:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 19:21 [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples Rob Herring
2022-04-22 19:21 ` Rob Herring
2022-04-22 19:21 ` Rob Herring
2022-04-22 19:21 ` Rob Herring
2022-04-27 8:40 ` Joel Stanley
2022-04-27 8:40 ` Joel Stanley
2022-04-27 8:40 ` Joel Stanley
2022-04-27 8:40 ` Joel Stanley
2022-04-27 18:44 ` Rob Herring [this message]
2022-04-27 18:44 ` Rob Herring
2022-04-27 18:44 ` Rob Herring
2022-04-27 18:44 ` Rob Herring
2022-04-28 6:53 ` Krzysztof Kozlowski
2022-04-28 6:53 ` Krzysztof Kozlowski
2022-04-28 6:53 ` Krzysztof Kozlowski
2022-04-28 6:53 ` Krzysztof Kozlowski
2022-05-04 21:25 ` Linus Walleij
2022-05-04 21:25 ` Linus Walleij
2022-05-04 21:25 ` Linus Walleij
2022-05-04 21:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmmPJLcI7PnsBtXn@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.