All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	DRI Devel <dri-devel@lists.freedesktop.org>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces
Date: Thu, 5 May 2022 15:27:35 +0200	[thread overview]
Message-ID: <YnPQxxaMRLXQ8O7u@intel.intel> (raw)
In-Reply-To: <b9651f2f-64dc-78a7-d100-0bd70d1a2493@linux.intel.com>

Hi Tvrtko,

[...]

> > +static ssize_t act_freq_mhz_show(struct device *dev,
> > +				 struct device_attribute *attr, char *buff)
> > +{
> > +	u32 actual_freq = sysfs_gt_attribute_r_max_func(dev, attr,
> > +						    __act_freq_mhz_show);
> 
> Because sysfs_gt_attribute_r_max_func is only defined if CONFIG_PM is set,
> the !CONFIG_PM builds are broken. I guess just move it to be always
> available.

oh, right! Thanks for letting me know, will fix it.

Thanks,
Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	DRI Devel <dri-devel@lists.freedesktop.org>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Matthew Auld <matthew.auld@intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces
Date: Thu, 5 May 2022 15:27:35 +0200	[thread overview]
Message-ID: <YnPQxxaMRLXQ8O7u@intel.intel> (raw)
In-Reply-To: <b9651f2f-64dc-78a7-d100-0bd70d1a2493@linux.intel.com>

Hi Tvrtko,

[...]

> > +static ssize_t act_freq_mhz_show(struct device *dev,
> > +				 struct device_attribute *attr, char *buff)
> > +{
> > +	u32 actual_freq = sysfs_gt_attribute_r_max_func(dev, attr,
> > +						    __act_freq_mhz_show);
> 
> Because sysfs_gt_attribute_r_max_func is only defined if CONFIG_PM is set,
> the !CONFIG_PM builds are broken. I guess just move it to be always
> available.

oh, right! Thanks for letting me know, will fix it.

Thanks,
Andi

  reply	other threads:[~2022-05-05 13:27 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 23:39 [Intel-gfx] [PATCH v7 0/7] Introduce multitile support Andi Shyti
2022-03-18 23:39 ` Andi Shyti
2022-03-18 23:39 ` [Intel-gfx] [PATCH v7 1/7] drm/i915: Rename INTEL_REGION_LMEM with INTEL_REGION_LMEM_0 Andi Shyti
2022-03-18 23:39   ` Andi Shyti
2022-03-18 23:39 ` [Intel-gfx] [PATCH v7 2/7] drm/i915/gt: add gt_is_root() helper Andi Shyti
2022-03-18 23:39   ` Andi Shyti
2022-03-18 23:39 ` [Intel-gfx] [PATCH v7 3/7] drm/i915: Prepare for multiple GTs Andi Shyti
2022-03-18 23:39   ` Andi Shyti
2022-03-19 12:08   ` [Intel-gfx] " Michal Wajdeczko
2022-03-19 12:08     ` Michal Wajdeczko
2022-03-20 15:51     ` [Intel-gfx] " Andi Shyti
2022-03-20 15:51       ` Andi Shyti
2022-05-11 19:11   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-05-11 19:11     ` Ceraolo Spurio, Daniele
2022-05-19 14:53     ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-05-19 14:53       ` Ceraolo Spurio, Daniele
2022-05-19 22:03       ` [Intel-gfx] " Andi Shyti
2022-05-19 22:03         ` Andi Shyti
2022-03-18 23:39 ` [Intel-gfx] [PATCH v7 4/7] drm/i915/gt: create per-tile sysfs interface Andi Shyti
2022-03-18 23:39   ` Andi Shyti
2022-03-18 23:39 ` [Intel-gfx] [PATCH v7 5/7] drm/i915/gt: Create per-tile RC6 " Andi Shyti
2022-03-18 23:39   ` Andi Shyti
2022-03-18 23:39 ` [Intel-gfx] [PATCH v7 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces Andi Shyti
2022-03-18 23:39   ` Andi Shyti
2022-05-05 13:14   ` [Intel-gfx] " Tvrtko Ursulin
2022-05-05 13:27     ` Andi Shyti [this message]
2022-05-05 13:27       ` Andi Shyti
2022-05-06 11:53   ` Jani Nikula
2022-05-06 15:21     ` Andi Shyti
2022-05-06 15:21       ` Andi Shyti
2022-03-18 23:39 ` [Intel-gfx] [PATCH v7 7/7] drm/i915/gt: Add sysfs throttle frequency interfaces Andi Shyti
2022-03-18 23:39   ` Andi Shyti
2022-03-18 23:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support Patchwork
2022-03-18 23:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-19  0:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-19  2:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-21 10:05   ` Matthew Auld
2022-03-21 16:44     ` Vudum, Lakshminarayana
2022-03-21 16:28 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2022-03-21 16:43 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnPQxxaMRLXQ8O7u@intel.intel \
    --to=andi.shyti@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.auld@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.