From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, jon.grimm@amd.com,
linux-kernel@vger.kernel.org, vasant.hegde@amd.com
Subject: Re: [PATCH v2] iommu/amd: Set translation valid bit only when IO page tables are in used
Date: Fri, 20 May 2022 10:58:53 +0200 [thread overview]
Message-ID: <YodYTZzSd9fZucLT@8bytes.org> (raw)
In-Reply-To: <794e13dd-8eae-481d-711d-b5462fdbfb18@arm.com>
On Fri, May 20, 2022 at 09:54:51AM +0100, Robin Murphy wrote:
> The .def_domain type op already allows drivers to do exactly this sort of
> override. You could also conditionally reject IOMMU_DOMAIN_PASSTHROUGH in
> .domain_alloc for good measure, provided that (for now at least*) SNP is a
> global thing rather than per-instance.
Yeah, that could work. I am just not sure the IOMMU core behaves well in
all situations when allocation IOMMU_DOMAIN_PASSTHROUGH suddenly starts
to fail. I would feel better if this is checked and tested :)
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
iommu@lists.linux-foundation.org, jon.grimm@amd.com,
linux-kernel@vger.kernel.org, vasant.hegde@amd.com
Subject: Re: [PATCH v2] iommu/amd: Set translation valid bit only when IO page tables are in used
Date: Fri, 20 May 2022 10:58:53 +0200 [thread overview]
Message-ID: <YodYTZzSd9fZucLT@8bytes.org> (raw)
In-Reply-To: <794e13dd-8eae-481d-711d-b5462fdbfb18@arm.com>
On Fri, May 20, 2022 at 09:54:51AM +0100, Robin Murphy wrote:
> The .def_domain type op already allows drivers to do exactly this sort of
> override. You could also conditionally reject IOMMU_DOMAIN_PASSTHROUGH in
> .domain_alloc for good measure, provided that (for now at least*) SNP is a
> global thing rather than per-instance.
Yeah, that could work. I am just not sure the IOMMU core behaves well in
all situations when allocation IOMMU_DOMAIN_PASSTHROUGH suddenly starts
to fail. I would feel better if this is checked and tested :)
Regards,
Joerg
next prev parent reply other threads:[~2022-05-20 8:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 7:48 [PATCH v2] iommu/amd: Set translation valid bit only when IO page tables are in used Suravee Suthikulpanit via iommu
2022-05-09 7:48 ` Suravee Suthikulpanit
2022-05-13 13:07 ` Joerg Roedel
2022-05-13 13:07 ` Joerg Roedel
2022-05-16 12:27 ` Suravee Suthikulpanit via iommu
2022-05-16 12:27 ` Suravee Suthikulpanit
2022-05-20 8:09 ` Joerg Roedel
2022-05-20 8:09 ` Joerg Roedel
2022-05-20 8:54 ` Robin Murphy
2022-05-20 8:54 ` Robin Murphy
2022-05-20 8:58 ` Joerg Roedel [this message]
2022-05-20 8:58 ` Joerg Roedel
2022-05-20 9:18 ` Robin Murphy
2022-05-20 9:18 ` Robin Murphy
2022-05-26 3:29 ` Suravee Suthikulpanit via iommu
2022-05-26 3:29 ` Suravee Suthikulpanit
2022-06-07 8:00 ` Joerg Roedel
2022-06-07 8:00 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YodYTZzSd9fZucLT@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jon.grimm@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.