From: Catalin Marinas <catalin.marinas@arm.com>
To: Marco Elver <elver@google.com>
Cc: paulmck@kernel.org, Kefeng Wang <wangkefeng.wang@huawei.com>,
will@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mark.rutland@arm.com,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, arnd@arndb.de,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v4 1/2] asm-generic: Add memory barrier dma_mb()
Date: Sun, 19 Jun 2022 10:45:22 +0100 [thread overview]
Message-ID: <Yq7wMj30T/mJp+FZ@arm.com> (raw)
In-Reply-To: <CANpmjNMnA0VtExcvpV=Sr57RQ3xxVkHxhrTkvEKeHZ27bhud+w@mail.gmail.com>
On Fri, Jun 17, 2022 at 12:18:41PM +0200, Marco Elver wrote:
> On Fri, 17 Jun 2022 at 01:13, Paul E. McKenney <paulmck@kernel.org> wrote:
> > On Mon, May 23, 2022 at 01:35:27PM +0200, Marco Elver wrote:
> > > On Mon, 23 May 2022 at 13:21, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> > > >
> > > > The memory barrier dma_mb() is introduced by commit a76a37777f2c
> > > > ("iommu/arm-smmu-v3: Ensure queue is read after updating prod pointer"),
> > > > which is used to ensure that prior (both reads and writes) accesses
> > > > to memory by a CPU are ordered w.r.t. a subsequent MMIO write.
> > > >
> > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> # for asm-generic
> > > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > >
> > > Reviewed-by: Marco Elver <elver@google.com>
> >
> > Just checking... Did these ever get picked up? It was suggested
> > that they go up via the arm64 tree, if I remember correctly.
>
> I don't see them in -next, and as far as I can tell, they're not in
> the arm64 tree.
Since v4 was posted during the merging window, it hasn't been queued for
5.19-rc1. I normally only merge patches with a Fixes tag during the -rc
period (though there are some exceptions). Mark commented in v1 that
such tag isn't necessary, so I thought I'd leave it for the 5.20 merging
window.
That said, the diffstat is small, so if it helps having this in 5.19, I
can queue it for -rc4.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Marco Elver <elver@google.com>
Cc: paulmck@kernel.org, Kefeng Wang <wangkefeng.wang@huawei.com>,
will@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mark.rutland@arm.com,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, arnd@arndb.de,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v4 1/2] asm-generic: Add memory barrier dma_mb()
Date: Sun, 19 Jun 2022 10:45:22 +0100 [thread overview]
Message-ID: <Yq7wMj30T/mJp+FZ@arm.com> (raw)
In-Reply-To: <CANpmjNMnA0VtExcvpV=Sr57RQ3xxVkHxhrTkvEKeHZ27bhud+w@mail.gmail.com>
On Fri, Jun 17, 2022 at 12:18:41PM +0200, Marco Elver wrote:
> On Fri, 17 Jun 2022 at 01:13, Paul E. McKenney <paulmck@kernel.org> wrote:
> > On Mon, May 23, 2022 at 01:35:27PM +0200, Marco Elver wrote:
> > > On Mon, 23 May 2022 at 13:21, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> > > >
> > > > The memory barrier dma_mb() is introduced by commit a76a37777f2c
> > > > ("iommu/arm-smmu-v3: Ensure queue is read after updating prod pointer"),
> > > > which is used to ensure that prior (both reads and writes) accesses
> > > > to memory by a CPU are ordered w.r.t. a subsequent MMIO write.
> > > >
> > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> # for asm-generic
> > > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > >
> > > Reviewed-by: Marco Elver <elver@google.com>
> >
> > Just checking... Did these ever get picked up? It was suggested
> > that they go up via the arm64 tree, if I remember correctly.
>
> I don't see them in -next, and as far as I can tell, they're not in
> the arm64 tree.
Since v4 was posted during the merging window, it hasn't been queued for
5.19-rc1. I normally only merge patches with a Fixes tag during the -rc
period (though there are some exceptions). Mark commented in v1 that
such tag isn't necessary, so I thought I'd leave it for the 5.20 merging
window.
That said, the diffstat is small, so if it helps having this in 5.19, I
can queue it for -rc4.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-19 9:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 11:31 [PATCH v4 0/2] arm64: Fix kcsan test_barrier fail and panic Kefeng Wang
2022-05-23 11:31 ` Kefeng Wang
2022-05-23 11:31 ` [PATCH v4 1/2] asm-generic: Add memory barrier dma_mb() Kefeng Wang
2022-05-23 11:31 ` Kefeng Wang
2022-05-23 11:35 ` Marco Elver
2022-05-23 11:35 ` Marco Elver
2022-06-16 23:13 ` Paul E. McKenney
2022-06-16 23:13 ` Paul E. McKenney
2022-06-17 10:18 ` Marco Elver
2022-06-17 10:18 ` Marco Elver
2022-06-19 9:45 ` Catalin Marinas [this message]
2022-06-19 9:45 ` Catalin Marinas
2022-06-20 21:02 ` Paul E. McKenney
2022-06-20 21:02 ` Paul E. McKenney
2022-05-23 11:38 ` Mark Rutland
2022-05-23 11:38 ` Mark Rutland
2022-05-23 11:31 ` [PATCH v4 2/2] arm64: kcsan: Support detecting more missing memory barriers Kefeng Wang
2022-05-23 11:31 ` Kefeng Wang
2022-05-23 14:16 ` Mark Rutland
2022-05-23 14:16 ` Mark Rutland
2022-06-14 3:20 ` Kefeng Wang
2022-06-14 3:20 ` Kefeng Wang
2022-06-21 10:46 ` Catalin Marinas
2022-06-21 10:46 ` Catalin Marinas
2022-06-23 19:31 ` [PATCH v4 0/2] arm64: Fix kcsan test_barrier fail and panic Will Deacon
2022-06-23 19:31 ` Will Deacon
-- strict thread matches above, loose matches on Subject: below --
2022-05-23 11:26 Kefeng Wang
2022-05-23 11:26 ` [PATCH v4 1/2] asm-generic: Add memory barrier dma_mb() Kefeng Wang
2022-05-23 11:26 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yq7wMj30T/mJp+FZ@arm.com \
--to=catalin.marinas@arm.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=elver@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.