From: Brian Norris <briannorris@chromium.org>
To: Judy Hsiao <judyhsiao@chromium.org>
Cc: alsa-devel@alsa-project.org, Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-rockchip@lists.infradead.org,
Mark Brown <broonie@kernel.org>,
Chen-Yu Tsai <wenst@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s
Date: Thu, 16 Jun 2022 13:39:14 -0700 [thread overview]
Message-ID: <YquU8hN+9ETu8tB2@google.com> (raw)
In-Reply-To: <20220616155836.3401420-4-judyhsiao@chromium.org>
On Thu, Jun 16, 2022 at 03:58:36PM +0000, Judy Hsiao wrote:
> This patch documents pinctrl-names for i2s.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> index 5ea16b8ef93f..af1069278623 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> @@ -61,6 +61,13 @@ properties:
> - const: tx
> - const: rx
>
> + pinctrl-names:
> + oneOf:
> + - const: default
> + - items:
I'm far from a YAML expert, but I think you have the indentation wrong?
You want the "const: default" and the "items:" schema to be on the same
level of indentation, right?
If you haven't already, you might run through the 'make
dt_binding_check' process.
Brian
> + - const: bclk_on
> + - const: bclk_off
> +
> power-domains:
> maxItems: 1
>
> --
> 2.36.1.476.g0c4daa206d-goog
>
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Judy Hsiao <judyhsiao@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Chen-Yu Tsai <wenst@chromium.org>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s
Date: Thu, 16 Jun 2022 13:39:14 -0700 [thread overview]
Message-ID: <YquU8hN+9ETu8tB2@google.com> (raw)
In-Reply-To: <20220616155836.3401420-4-judyhsiao@chromium.org>
On Thu, Jun 16, 2022 at 03:58:36PM +0000, Judy Hsiao wrote:
> This patch documents pinctrl-names for i2s.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> index 5ea16b8ef93f..af1069278623 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> @@ -61,6 +61,13 @@ properties:
> - const: tx
> - const: rx
>
> + pinctrl-names:
> + oneOf:
> + - const: default
> + - items:
I'm far from a YAML expert, but I think you have the indentation wrong?
You want the "const: default" and the "items:" schema to be on the same
level of indentation, right?
If you haven't already, you might run through the 'make
dt_binding_check' process.
Brian
> + - const: bclk_on
> + - const: bclk_off
> +
> power-domains:
> maxItems: 1
>
> --
> 2.36.1.476.g0c4daa206d-goog
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Judy Hsiao <judyhsiao@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Chen-Yu Tsai <wenst@chromium.org>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s
Date: Thu, 16 Jun 2022 13:39:14 -0700 [thread overview]
Message-ID: <YquU8hN+9ETu8tB2@google.com> (raw)
In-Reply-To: <20220616155836.3401420-4-judyhsiao@chromium.org>
On Thu, Jun 16, 2022 at 03:58:36PM +0000, Judy Hsiao wrote:
> This patch documents pinctrl-names for i2s.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> index 5ea16b8ef93f..af1069278623 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> @@ -61,6 +61,13 @@ properties:
> - const: tx
> - const: rx
>
> + pinctrl-names:
> + oneOf:
> + - const: default
> + - items:
I'm far from a YAML expert, but I think you have the indentation wrong?
You want the "const: default" and the "items:" schema to be on the same
level of indentation, right?
If you haven't already, you might run through the 'make
dt_binding_check' process.
Brian
> + - const: bclk_on
> + - const: bclk_off
> +
> power-domains:
> maxItems: 1
>
> --
> 2.36.1.476.g0c4daa206d-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Judy Hsiao <judyhsiao@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Chen-Yu Tsai <wenst@chromium.org>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s
Date: Thu, 16 Jun 2022 13:39:14 -0700 [thread overview]
Message-ID: <YquU8hN+9ETu8tB2@google.com> (raw)
In-Reply-To: <20220616155836.3401420-4-judyhsiao@chromium.org>
On Thu, Jun 16, 2022 at 03:58:36PM +0000, Judy Hsiao wrote:
> This patch documents pinctrl-names for i2s.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> index 5ea16b8ef93f..af1069278623 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> @@ -61,6 +61,13 @@ properties:
> - const: tx
> - const: rx
>
> + pinctrl-names:
> + oneOf:
> + - const: default
> + - items:
I'm far from a YAML expert, but I think you have the indentation wrong?
You want the "const: default" and the "items:" schema to be on the same
level of indentation, right?
If you haven't already, you might run through the 'make
dt_binding_check' process.
Brian
> + - const: bclk_on
> + - const: bclk_off
> +
> power-domains:
> maxItems: 1
>
> --
> 2.36.1.476.g0c4daa206d-goog
>
next prev parent reply other threads:[~2022-06-16 20:40 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 15:58 [PATCH v2 0/3] ASoC: rockchip: i2s: switch BCLK to GPIO Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 15:58 ` [PATCH v2 1/3] " Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 19:03 ` kernel test robot
2022-06-16 19:03 ` kernel test robot
2022-06-16 19:03 ` kernel test robot
2022-06-16 19:03 ` kernel test robot
2022-06-16 20:48 ` Brian Norris
2022-06-16 20:48 ` Brian Norris
2022-06-16 20:48 ` Brian Norris
2022-06-16 20:48 ` Brian Norris
2022-06-17 4:21 ` Judy Hsiao
2022-06-17 4:21 ` Judy Hsiao
2022-06-17 4:21 ` Judy Hsiao
2022-06-17 4:21 ` Judy Hsiao
2022-06-16 15:58 ` [PATCH v2 2/3] arm64: dts: rk3399: " Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 20:39 ` Brian Norris
2022-06-16 20:39 ` Brian Norris
2022-06-16 20:39 ` Brian Norris
2022-06-16 20:39 ` Brian Norris
2022-06-16 15:58 ` [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 15:58 ` Judy Hsiao
2022-06-16 20:39 ` Brian Norris [this message]
2022-06-16 20:39 ` Brian Norris
2022-06-16 20:39 ` Brian Norris
2022-06-16 20:39 ` Brian Norris
2022-06-17 4:42 ` [PATCH v3 0/3] ASoC: rockchip: i2s: switch BCLK to GPIO Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` [PATCH v3 1/3] " Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 20:46 ` Brian Norris
2022-06-17 20:46 ` Brian Norris
2022-06-17 20:46 ` Brian Norris
2022-06-17 20:46 ` Brian Norris
2022-06-17 4:42 ` [PATCH v3 2/3] arm64: dts: rk3399: " Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` [PATCH v3 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 4:42 ` Judy Hsiao
2022-06-17 8:45 ` [PATCH v3 0/3] ASoC: rockchip: i2s: switch BCLK to GPIO Mark Brown
2022-06-17 8:45 ` Mark Brown
2022-06-17 8:45 ` Mark Brown
2022-06-17 8:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YquU8hN+9ETu8tB2@google.com \
--to=briannorris@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.