From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: alsa-devel@alsa-project.org,
Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
Arnd Bergmann <arnd@arndb.de>, Grond <grond66@riseup.net>,
Stefan Leichter <sle85276@gmx.de>,
Mark Brown <broonie@kernel.org>,
Grazvydas Ignotas <notasas@gmail.com>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: Pandora audio using machine_is_omap3_pandora() check
Date: Mon, 27 Jun 2022 16:53:58 +0300 [thread overview]
Message-ID: <Yrm2dl9EtIb5IYhi@atomide.com> (raw)
In-Reply-To: <B6EFBA88-2311-4455-82CB-3E5382C92B4E@goldelico.com>
* H. Nikolaus Schaller <hns@goldelico.com> [220627 11:36]:
> Hi Tony,
>
> > Am 27.06.2022 um 11:52 schrieb Tony Lindgren <tony@atomide.com>:
> >
> > Hi Grazvydas,
> >
> > Arnd noticed that pandora audio is using machine_is_omap3_pandora() check
> > that never succeeds for devicetree booting machines. Looks like this has
> > been broken at some point many years ago with the devicetree conversion.
> >
> > Does anybody have an interest in fixing this driver?
>
> we already have fixes by Stefan Leichter and Grond here (incl. removing any call to machine_is_omap3_pandora):
>
> https://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux/sound-soc
OK :)
> But I don't know who can volunteer to run this series through the upstreaming discussions
> and do regression tests (AFAIR the Pandora of Grond is broken and he has no replacement).
Probably best that Stefan and Grond do it :) Not sure what the minimal fix
for the mainline kernel might be to get things at least try to probe.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Grazvydas Ignotas <notasas@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org,
linux-omap <linux-omap@vger.kernel.org>,
Stefan Leichter <sle85276@gmx.de>, Grond <grond66@riseup.net>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>
Subject: Re: Pandora audio using machine_is_omap3_pandora() check
Date: Mon, 27 Jun 2022 16:53:58 +0300 [thread overview]
Message-ID: <Yrm2dl9EtIb5IYhi@atomide.com> (raw)
In-Reply-To: <B6EFBA88-2311-4455-82CB-3E5382C92B4E@goldelico.com>
* H. Nikolaus Schaller <hns@goldelico.com> [220627 11:36]:
> Hi Tony,
>
> > Am 27.06.2022 um 11:52 schrieb Tony Lindgren <tony@atomide.com>:
> >
> > Hi Grazvydas,
> >
> > Arnd noticed that pandora audio is using machine_is_omap3_pandora() check
> > that never succeeds for devicetree booting machines. Looks like this has
> > been broken at some point many years ago with the devicetree conversion.
> >
> > Does anybody have an interest in fixing this driver?
>
> we already have fixes by Stefan Leichter and Grond here (incl. removing any call to machine_is_omap3_pandora):
>
> https://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux/sound-soc
OK :)
> But I don't know who can volunteer to run this series through the upstreaming discussions
> and do regression tests (AFAIR the Pandora of Grond is broken and he has no replacement).
Probably best that Stefan and Grond do it :) Not sure what the minimal fix
for the mainline kernel might be to get things at least try to probe.
Regards,
Tony
next prev parent reply other threads:[~2022-06-27 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 9:52 Pandora audio using machine_is_omap3_pandora() check Tony Lindgren
2022-06-27 9:52 ` Tony Lindgren
2022-06-27 11:40 ` H. Nikolaus Schaller
2022-06-27 11:40 ` H. Nikolaus Schaller
2022-06-27 13:53 ` Tony Lindgren [this message]
2022-06-27 13:53 ` Tony Lindgren
2022-07-05 21:39 ` Stefan Leichter
2022-07-11 10:05 ` H. Nikolaus Schaller
2022-07-11 10:05 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrm2dl9EtIb5IYhi@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=grond66@riseup.net \
--cc=hns@goldelico.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=sle85276@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.