All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	Zefan Li <lizefan.x@bytedance.com>, Marc Zyngier <maz@kernel.org>,
	James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt <shakeelb@google.com>,
	Oliver Upton <oupton@google.com>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.ker
Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats.
Date: Mon, 27 Jun 2022 16:22:46 +0000	[thread overview]
Message-ID: <YrnZVgq1E/u1nYm0@google.com> (raw)
In-Reply-To: <20220606222058.86688-4-yosryahmed@google.com>

On Mon, Jun 06, 2022, Yosry Ahmed wrote:
> Count the pages used by KVM mmu on x86 for in secondary pagetable stats.

"for in" is funky.  And it's worth providing a brief explanation of what the
secondary pagetable stats actually are.  "secondary" is confusingly close to
"second level pagetables", e.g. might be misconstrued as KVM counters for the
number of stage-2 / two-dimension paging page (TDP) tables.

Code looks good, though it needs a rebased on kvm/queue.

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Wanpeng Li <wanpengli@tencent.com>,
	kvm@vger.kernel.org, Roman Gushchin <roman.gushchin@linux.dev>,
	Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org, Zefan Li <lizefan.x@bytedance.com>,
	kvmarm@lists.cs.columbia.edu, Marc Zyngier <maz@kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	Shakeel Butt <shakeelb@google.com>,
	cgroups@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org,
	Jim Mattson <jmattson@google.com>,
	linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats.
Date: Mon, 27 Jun 2022 16:22:46 +0000	[thread overview]
Message-ID: <YrnZVgq1E/u1nYm0@google.com> (raw)
In-Reply-To: <20220606222058.86688-4-yosryahmed@google.com>

On Mon, Jun 06, 2022, Yosry Ahmed wrote:
> Count the pages used by KVM mmu on x86 for in secondary pagetable stats.

"for in" is funky.  And it's worth providing a brief explanation of what the
secondary pagetable stats actually are.  "secondary" is confusingly close to
"second level pagetables", e.g. might be misconstrued as KVM counters for the
number of stage-2 / two-dimension paging page (TDP) tables.

Code looks good, though it needs a rebased on kvm/queue.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	Zefan Li <lizefan.x@bytedance.com>, Marc Zyngier <maz@kernel.org>,
	James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt <shakeelb@google.com>,
	Oliver Upton <oupton@google.com>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats.
Date: Mon, 27 Jun 2022 16:22:46 +0000	[thread overview]
Message-ID: <YrnZVgq1E/u1nYm0@google.com> (raw)
In-Reply-To: <20220606222058.86688-4-yosryahmed@google.com>

On Mon, Jun 06, 2022, Yosry Ahmed wrote:
> Count the pages used by KVM mmu on x86 for in secondary pagetable stats.

"for in" is funky.  And it's worth providing a brief explanation of what the
secondary pagetable stats actually are.  "secondary" is confusingly close to
"second level pagetables", e.g. might be misconstrued as KVM counters for the
number of stage-2 / two-dimension paging page (TDP) tables.

Code looks good, though it needs a rebased on kvm/queue.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	Zefan Li <lizefan.x@bytedance.com>, Marc Zyngier <maz@kernel.org>,
	James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt <shakeelb@google.com>,
	Oliver Upton <oupton@google.com>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats.
Date: Mon, 27 Jun 2022 16:22:46 +0000	[thread overview]
Message-ID: <YrnZVgq1E/u1nYm0@google.com> (raw)
In-Reply-To: <20220606222058.86688-4-yosryahmed@google.com>

On Mon, Jun 06, 2022, Yosry Ahmed wrote:
> Count the pages used by KVM mmu on x86 for in secondary pagetable stats.

"for in" is funky.  And it's worth providing a brief explanation of what the
secondary pagetable stats actually are.  "secondary" is confusingly close to
"second level pagetables", e.g. might be misconstrued as KVM counters for the
number of stage-2 / two-dimension paging page (TDP) tables.

Code looks good, though it needs a rebased on kvm/queue.

  reply	other threads:[~2022-06-27 16:22 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 22:20 [PATCH v5 0/4] KVM: mm: count KVM mmu usage in memory stats Yosry Ahmed
2022-06-06 22:20 ` Yosry Ahmed
2022-06-06 22:20 ` Yosry Ahmed
     [not found] ` <20220606222058.86688-1-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-06-06 22:20   ` [PATCH v5 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses Yosry Ahmed
2022-06-06 22:20     ` Yosry Ahmed
2022-06-06 22:20     ` Yosry Ahmed
2022-06-06 22:20     ` Yosry Ahmed
     [not found]     ` <20220606222058.86688-2-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-06-10 19:55       ` Shakeel Butt
2022-06-10 19:55         ` Shakeel Butt
2022-06-10 19:55         ` Shakeel Butt
2022-06-10 19:55         ` Shakeel Butt
2022-06-13  3:18     ` Huang, Shaoqin
2022-06-13  3:18       ` Huang, Shaoqin
2022-06-13  3:18       ` Huang, Shaoqin
2022-06-13  3:18       ` Huang, Shaoqin
2022-06-13 17:11       ` Yosry Ahmed
2022-06-13 17:11         ` Yosry Ahmed
2022-06-13 17:11         ` Yosry Ahmed
2022-06-13 17:11         ` Yosry Ahmed
2022-06-27 16:07     ` Sean Christopherson
2022-06-27 16:07       ` Sean Christopherson
2022-06-27 16:07       ` Sean Christopherson
2022-06-27 16:07       ` Sean Christopherson
     [not found]       ` <YrnVxM/5KjVhkOnn-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-06-27 16:23         ` Yosry Ahmed
2022-06-27 16:23           ` Yosry Ahmed
2022-06-27 16:23           ` Yosry Ahmed
2022-06-27 16:23           ` Yosry Ahmed
2022-06-27 16:27     ` Sean Christopherson
2022-06-27 16:27       ` Sean Christopherson
2022-06-27 16:27       ` Sean Christopherson
2022-06-27 16:27       ` Sean Christopherson
2022-06-06 22:20   ` [PATCH v5 2/4] KVM: mmu: add a helper to account memory used by KVM MMU Yosry Ahmed
2022-06-06 22:20     ` Yosry Ahmed
2022-06-06 22:20     ` Yosry Ahmed
2022-06-06 22:20     ` Yosry Ahmed
     [not found]     ` <20220606222058.86688-3-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-06-27 16:20       ` Sean Christopherson
2022-06-27 16:20         ` Sean Christopherson
2022-06-27 16:20         ` Sean Christopherson
2022-06-27 16:20         ` Sean Christopherson
     [not found]         ` <YrnYtMGmGDxCrwdv-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-06-27 16:28           ` Yosry Ahmed
2022-06-27 16:28             ` Yosry Ahmed
2022-06-27 16:28             ` Yosry Ahmed
2022-06-27 16:28             ` Yosry Ahmed
2022-06-06 22:20   ` [PATCH v5 4/4] KVM: arm64/mmu: count KVM s2 mmu usage in secondary pagetable stats Yosry Ahmed
2022-06-06 22:20     ` Yosry Ahmed
2022-06-06 22:20     ` Yosry Ahmed
2022-06-06 22:20     ` Yosry Ahmed
     [not found]     ` <20220606222058.86688-5-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-06-28 18:53       ` Oliver Upton
2022-06-28 18:53         ` Oliver Upton
2022-06-28 18:53         ` Oliver Upton
2022-06-28 18:53         ` Oliver Upton
2022-06-06 22:20 ` [PATCH v5 3/4] KVM: x86/mmu: count KVM " Yosry Ahmed
2022-06-06 22:20   ` Yosry Ahmed
2022-06-06 22:20   ` Yosry Ahmed
2022-06-27 16:22   ` Sean Christopherson [this message]
2022-06-27 16:22     ` Sean Christopherson
2022-06-27 16:22     ` Sean Christopherson
2022-06-27 16:22     ` Sean Christopherson
2022-06-27 16:29     ` Yosry Ahmed
2022-06-27 16:29       ` Yosry Ahmed
2022-06-27 16:29       ` Yosry Ahmed
2022-06-27 16:29       ` Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrnZVgq1E/u1nYm0@google.com \
    --to=seanjc@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexandru.elisei@arm.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=james.morse@arm.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.ker \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=maz@kernel.org \
    --cc=mhocko@kernel.org \
    --cc=oupton@google.com \
    --cc=pbonzini@redhat.com \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeelb@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tj@kernel.org \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.