From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Liu <chaoliu719@gmail.com>
Cc: Chao Liu <liuchao@coolpad.com>,
linux-kernel@vger.kernel.org, Wayne Zhang <zhangwen@coolpad.com>,
Yue Hu <huyue2@coolpad.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: allow compression of files without blocks
Date: Mon, 11 Jul 2022 18:36:15 -0700 [thread overview]
Message-ID: <YszQD8Pk3YTvPgpn@google.com> (raw)
In-Reply-To: <20220707090924.4183376-1-chaoliu719@gmail.com>
On 07/07, Chao Liu wrote:
> From: Chao Liu <liuchao@coolpad.com>
>
> Files created by truncate(1) have a size but no blocks, so
> they can be allowed to enable compression.
>
> Signed-off-by: Chao Liu <liuchao@coolpad.com>
> ---
> v2:
> - update commit message: truncate -> truncate(1)
>
> fs/f2fs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 0f29af7876a6..f7a82858486a 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
> if (iflags & F2FS_COMPR_FL) {
> if (!f2fs_may_compress(inode))
> return -EINVAL;
> - if (S_ISREG(inode->i_mode) && inode->i_size)
> + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
What about inline_data case?
> return -EINVAL;
>
> set_compress_context(inode);
> --
> 2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Liu <chaoliu719@gmail.com>
Cc: Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Yue Hu <huyue2@coolpad.com>,
Wayne Zhang <zhangwen@coolpad.com>,
Chao Liu <liuchao@coolpad.com>
Subject: Re: [PATCH v2] f2fs: allow compression of files without blocks
Date: Mon, 11 Jul 2022 18:36:15 -0700 [thread overview]
Message-ID: <YszQD8Pk3YTvPgpn@google.com> (raw)
In-Reply-To: <20220707090924.4183376-1-chaoliu719@gmail.com>
On 07/07, Chao Liu wrote:
> From: Chao Liu <liuchao@coolpad.com>
>
> Files created by truncate(1) have a size but no blocks, so
> they can be allowed to enable compression.
>
> Signed-off-by: Chao Liu <liuchao@coolpad.com>
> ---
> v2:
> - update commit message: truncate -> truncate(1)
>
> fs/f2fs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 0f29af7876a6..f7a82858486a 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
> if (iflags & F2FS_COMPR_FL) {
> if (!f2fs_may_compress(inode))
> return -EINVAL;
> - if (S_ISREG(inode->i_mode) && inode->i_size)
> + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
What about inline_data case?
> return -EINVAL;
>
> set_compress_context(inode);
> --
> 2.36.1
next prev parent reply other threads:[~2022-07-12 1:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 9:09 [f2fs-dev] [PATCH v2] f2fs: allow compression of files without blocks Chao Liu
2022-07-07 9:09 ` Chao Liu
2022-07-07 13:32 ` [f2fs-dev] " Chao Yu
2022-07-07 13:32 ` Chao Yu
2022-07-12 1:36 ` Jaegeuk Kim [this message]
2022-07-12 1:36 ` Jaegeuk Kim
2022-07-12 3:20 ` [f2fs-dev] " Chao Yu
2022-07-12 3:20 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YszQD8Pk3YTvPgpn@google.com \
--to=jaegeuk@kernel.org \
--cc=chaoliu719@gmail.com \
--cc=huyue2@coolpad.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=liuchao@coolpad.com \
--cc=zhangwen@coolpad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.