From: Mark Brown <broonie@kernel.org>
To: "chunxu.li" <chunxu.li@mediatek.com>
Cc: alsa-devel@alsa-project.org, peter.ujfalusi@linux.intel.com,
tinghan.shen@mediatek.com, pierre-louis.bossart@linux.intel.com,
lgirdwood@gmail.com,
project_global_chrome_upstream_group@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, yc.hung@mediatek.com,
matthias.bgg@gmail.com, sound-open-firmware@alsa-project.org,
daniel.baluta@nxp.com, linux-kernel@vger.kernel.org,
angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select
Date: Thu, 4 Aug 2022 15:59:26 +0100 [thread overview]
Message-ID: <YuvezrxOnAJTLKt9@sirena.org.uk> (raw)
In-Reply-To: <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
On Thu, Aug 04, 2022 at 10:36:07PM +0800, chunxu.li wrote:
> Thanks for you advice, I'll remove the callback function, and directly
> call sof_of_machine_select() in sof_machine_check() as following.
>
> int sof_machine_check(struct snd_sof_dev *sdev)
> {
> }
>
>
> + of_mach = sof_of_machine_select(sdev);
> + if (of_mach) {
> + sof_pdata->of_machine = of_mach;
> + return 0;
> + }
Looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "chunxu.li" <chunxu.li@mediatek.com>
Cc: pierre-louis.bossart@linux.intel.com,
peter.ujfalusi@linux.intel.com, lgirdwood@gmail.com,
angelogioacchino.delregno@collabora.com, daniel.baluta@nxp.com,
matthias.bgg@gmail.com, yc.hung@mediatek.com,
tinghan.shen@mediatek.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org,
sound-open-firmware@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
project_global_chrome_upstream_group@mediatek.com
Subject: Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select
Date: Thu, 4 Aug 2022 15:59:26 +0100 [thread overview]
Message-ID: <YuvezrxOnAJTLKt9@sirena.org.uk> (raw)
In-Reply-To: <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
On Thu, Aug 04, 2022 at 10:36:07PM +0800, chunxu.li wrote:
> Thanks for you advice, I'll remove the callback function, and directly
> call sof_of_machine_select() in sof_machine_check() as following.
>
> int sof_machine_check(struct snd_sof_dev *sdev)
> {
> }
>
>
> + of_mach = sof_of_machine_select(sdev);
> + if (of_mach) {
> + sof_pdata->of_machine = of_mach;
> + return 0;
> + }
Looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "chunxu.li" <chunxu.li@mediatek.com>
Cc: pierre-louis.bossart@linux.intel.com,
peter.ujfalusi@linux.intel.com, lgirdwood@gmail.com,
angelogioacchino.delregno@collabora.com, daniel.baluta@nxp.com,
matthias.bgg@gmail.com, yc.hung@mediatek.com,
tinghan.shen@mediatek.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org,
sound-open-firmware@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
project_global_chrome_upstream_group@mediatek.com
Subject: Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select
Date: Thu, 4 Aug 2022 15:59:26 +0100 [thread overview]
Message-ID: <YuvezrxOnAJTLKt9@sirena.org.uk> (raw)
In-Reply-To: <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 421 bytes --]
On Thu, Aug 04, 2022 at 10:36:07PM +0800, chunxu.li wrote:
> Thanks for you advice, I'll remove the callback function, and directly
> call sof_of_machine_select() in sof_machine_check() as following.
>
> int sof_machine_check(struct snd_sof_dev *sdev)
> {
> }
>
>
> + of_mach = sof_of_machine_select(sdev);
> + if (of_mach) {
> + sof_pdata->of_machine = of_mach;
> + return 0;
> + }
Looks good.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-04 15:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:13 [PATCH 0/2] ASoC: SOF: Introduce of_machine_select Chunxu Li
2022-08-04 9:13 ` Chunxu Li
2022-08-04 9:13 ` Chunxu Li
2022-08-04 9:13 ` [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select Chunxu Li
2022-08-04 9:13 ` Chunxu Li
2022-08-04 9:13 ` Chunxu Li
2022-08-04 9:13 ` Chunxu Li
2022-08-04 13:17 ` Mark Brown
2022-08-04 13:17 ` Mark Brown
2022-08-04 13:17 ` Mark Brown
2022-08-04 14:36 ` chunxu.li
2022-08-04 14:36 ` chunxu.li
2022-08-04 14:36 ` chunxu.li
2022-08-04 14:59 ` Mark Brown [this message]
2022-08-04 14:59 ` Mark Brown
2022-08-04 14:59 ` Mark Brown
2022-08-04 9:13 ` [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine_select field for mt8186 Chunxu Li
2022-08-04 9:13 ` Chunxu Li
2022-08-04 9:13 ` Chunxu Li
2022-08-04 9:13 ` Chunxu Li
2022-08-04 12:41 ` Mark Brown
2022-08-04 12:41 ` Mark Brown
2022-08-04 12:41 ` Mark Brown
2022-08-04 13:21 ` chunxu.li
2022-08-04 13:21 ` chunxu.li
2022-08-04 13:21 ` chunxu.li
2022-08-04 13:33 ` Mark Brown
2022-08-04 13:33 ` Mark Brown
2022-08-04 13:33 ` Mark Brown
2022-08-04 14:47 ` chunxu.li
2022-08-04 14:47 ` chunxu.li
2022-08-04 14:47 ` chunxu.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuvezrxOnAJTLKt9@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunxu.li@mediatek.com \
--cc=daniel.baluta@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=project_global_chrome_upstream_group@mediatek.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tinghan.shen@mediatek.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.