All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	Jason Wang <jasowang@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	Nadav Amit <namit@vmware.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	kernel@openvz.org, Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/4] Make place for common balloon code
Date: Tue, 16 Aug 2022 13:56:32 +0200	[thread overview]
Message-ID: <YvuF8CsP0M1TAK1a@kroah.com> (raw)
In-Reply-To: <f88fe469-d4a4-3240-b325-a745255bf01c@virtuozzo.com>

On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote:
> Hello,
> 
> On 16.08.22 12:49, Greg Kroah-Hartman wrote:
> > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote:
> 
> > >   rename include/linux/{balloon_compaction.h => balloon_common.h} (99%)
> > 
> > Why rename the .h file?  It still handles the "balloon compaction"
> > logic.
> 
> File contains code that is common to balloon drivers,
> compaction is only part of it. Series add more code to it.
> Since it was suggested to use it for such common code.
> I find that common becomes a better name for it so the rename.
> I can drop the rename easy on next iteration if you suggest to.

"balloon_common.h" is very vague, you should only need one balloon.h
file in the include/linux/ directory, right, so of course it is "common"
:)

thanks,

greg "naming is hard" k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-kernel@vger.kernel.org,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	Nadav Amit <namit@vmware.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	kernel@openvz.org, Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/4] Make place for common balloon code
Date: Tue, 16 Aug 2022 13:56:32 +0200	[thread overview]
Message-ID: <YvuF8CsP0M1TAK1a@kroah.com> (raw)
In-Reply-To: <f88fe469-d4a4-3240-b325-a745255bf01c@virtuozzo.com>

On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote:
> Hello,
> 
> On 16.08.22 12:49, Greg Kroah-Hartman wrote:
> > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote:
> 
> > >   rename include/linux/{balloon_compaction.h => balloon_common.h} (99%)
> > 
> > Why rename the .h file?  It still handles the "balloon compaction"
> > logic.
> 
> File contains code that is common to balloon drivers,
> compaction is only part of it. Series add more code to it.
> Since it was suggested to use it for such common code.
> I find that common becomes a better name for it so the rename.
> I can drop the rename easy on next iteration if you suggest to.

"balloon_common.h" is very vague, you should only need one balloon.h
file in the include/linux/ directory, right, so of course it is "common"
:)

thanks,

greg "naming is hard" k-h
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Nadav Amit <namit@vmware.com>,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	kernel@openvz.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/4] Make place for common balloon code
Date: Tue, 16 Aug 2022 13:56:32 +0200	[thread overview]
Message-ID: <YvuF8CsP0M1TAK1a@kroah.com> (raw)
In-Reply-To: <f88fe469-d4a4-3240-b325-a745255bf01c@virtuozzo.com>

On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote:
> Hello,
> 
> On 16.08.22 12:49, Greg Kroah-Hartman wrote:
> > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote:
> 
> > >   rename include/linux/{balloon_compaction.h => balloon_common.h} (99%)
> > 
> > Why rename the .h file?  It still handles the "balloon compaction"
> > logic.
> 
> File contains code that is common to balloon drivers,
> compaction is only part of it. Series add more code to it.
> Since it was suggested to use it for such common code.
> I find that common becomes a better name for it so the rename.
> I can drop the rename easy on next iteration if you suggest to.

"balloon_common.h" is very vague, you should only need one balloon.h
file in the include/linux/ directory, right, so of course it is "common"
:)

thanks,

greg "naming is hard" k-h


  reply	other threads:[~2022-08-16 11:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16  9:41 [PATCH v2 0/4] Make balloon drivers memory changes known to the rest of the kernel Alexander Atanasov
2022-08-16  9:41 ` Alexander Atanasov
2022-08-16  9:41 ` [PATCH v2 1/4] Make place for common balloon code Alexander Atanasov
2022-08-16  9:41   ` Alexander Atanasov
2022-08-16  9:49   ` Greg Kroah-Hartman
2022-08-16  9:49     ` Greg Kroah-Hartman
2022-08-16  9:49     ` Greg Kroah-Hartman
2022-08-16 11:47     ` Alexander Atanasov
2022-08-16 11:47       ` Alexander Atanasov
2022-08-16 11:56       ` Greg Kroah-Hartman [this message]
2022-08-16 11:56         ` Greg Kroah-Hartman
2022-08-16 11:56         ` Greg Kroah-Hartman
2022-08-16 12:00         ` Michael S. Tsirkin
2022-08-16 12:00           ` Michael S. Tsirkin
2022-08-16 12:00           ` Michael S. Tsirkin
2022-08-18  4:41   ` Ritesh Harjani
2022-08-18  4:41     ` Ritesh Harjani
2022-08-18  6:43     ` Alexander Atanasov
2022-08-18  6:43       ` Alexander Atanasov
2022-08-16  9:41 ` [PATCH v2 2/4] Enable balloon drivers to report inflated memory Alexander Atanasov
2022-08-16  9:41 ` [PATCH v2 3/4] Display inflated memory to users Alexander Atanasov
2022-08-16  9:41 ` [PATCH v2 4/4] drivers: virtio: balloon - update inflated memory Alexander Atanasov
2022-08-16 22:17   ` kernel test robot
2022-08-16 22:17     ` kernel test robot
2022-08-17  5:09   ` kernel test robot
2022-08-17  5:09     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvuF8CsP0M1TAK1a@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.atanasov@virtuozzo.com \
    --cc=arnd@arndb.de \
    --cc=david@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kernel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mst@redhat.com \
    --cc=namit@vmware.com \
    --cc=npiggin@gmail.com \
    --cc=pv-drivers@vmware.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.