From: Baoquan He <bhe@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, agordeev@linux.ibm.com,
wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/11] mm: ioremap: fixup the physical address and page prot
Date: Tue, 23 Aug 2022 09:13:13 +0800 [thread overview]
Message-ID: <YwQpqTlsMx0mX26a@MiWiFi-R3L-srv> (raw)
In-Reply-To: <YwHWvjoZF1V4FSlW@infradead.org>
On 08/20/22 at 11:54pm, Christoph Hellwig wrote:
> > -void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot);
> > +void __iomem *
> > +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val);
>
> It seems a bit odd to do this in two steps vs just doing the entire
> change in the first patch. Any good reason for that?
I will merge patch 1~2 or 1~3 into patch 1. Earlier, I wrote the reason
as below paragraph in cover letter of v1 post. Now it seems not so hard
to tell and understand.
====
For patch 1~3, I don't merge them because I made them in different
rounds of changing. And splitting them makes me easily describe the
intention and make review easier. I can merge them after v1 reviewing
if anyone thinks they should be merged.
====
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, agordeev@linux.ibm.com,
wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/11] mm: ioremap: fixup the physical address and page prot
Date: Tue, 23 Aug 2022 09:13:13 +0800 [thread overview]
Message-ID: <YwQpqTlsMx0mX26a@MiWiFi-R3L-srv> (raw)
In-Reply-To: <YwHWvjoZF1V4FSlW@infradead.org>
On 08/20/22 at 11:54pm, Christoph Hellwig wrote:
> > -void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot);
> > +void __iomem *
> > +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val);
>
> It seems a bit odd to do this in two steps vs just doing the entire
> change in the first patch. Any good reason for that?
I will merge patch 1~2 or 1~3 into patch 1. Earlier, I wrote the reason
as below paragraph in cover letter of v1 post. Now it seems not so hard
to tell and understand.
====
For patch 1~3, I don't merge them because I made them in different
rounds of changing. And splitting them makes me easily describe the
intention and make review easier. I can merge them after v1 reviewing
if anyone thinks they should be merged.
====
next prev parent reply other threads:[~2022-08-23 1:14 UTC|newest]
Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 0:31 [PATCH v2 00/11] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 01/11] mm/ioremap: change the return value of io[re|un]map_allowed and rename Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-21 6:53 ` Christoph Hellwig
2022-08-21 6:53 ` Christoph Hellwig
2022-08-22 23:55 ` Baoquan He
2022-08-22 23:55 ` Baoquan He
2022-08-22 6:25 ` Christophe Leroy
2022-08-22 6:25 ` Christophe Leroy
2022-08-23 0:20 ` Baoquan He
2022-08-23 0:20 ` Baoquan He
2022-08-23 5:24 ` Christophe Leroy
2022-08-23 5:24 ` Christophe Leroy
2022-08-23 15:14 ` Baoquan He
2022-08-23 15:14 ` Baoquan He
2022-08-23 15:26 ` Christophe Leroy
2022-08-23 15:26 ` Christophe Leroy
2022-08-24 8:16 ` David Laight
2022-08-24 8:16 ` David Laight
2022-08-28 14:44 ` Baoquan He
2022-08-28 14:44 ` Baoquan He
2022-08-28 8:36 ` Alexander Gordeev
2022-08-28 8:36 ` Alexander Gordeev
2022-08-28 9:55 ` Baoquan He
2022-08-28 9:55 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 02/11] mm: ioremap: fixup the physical address and page prot Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-21 6:54 ` Christoph Hellwig
2022-08-21 6:54 ` Christoph Hellwig
2022-08-23 1:13 ` Baoquan He [this message]
2022-08-23 1:13 ` Baoquan He
2022-08-22 6:30 ` Christophe Leroy
2022-08-22 6:30 ` Christophe Leroy
2022-08-23 1:19 ` Baoquan He
2022-08-23 1:19 ` Baoquan He
2022-08-23 5:33 ` Christophe Leroy
2022-08-23 5:33 ` Christophe Leroy
2022-08-23 12:32 ` Baoquan He
2022-08-23 12:32 ` Baoquan He
2022-08-23 19:03 ` Christophe Leroy
2022-08-23 19:03 ` Christophe Leroy
2022-08-28 11:10 ` Baoquan He
2022-08-28 11:10 ` Baoquan He
2022-09-12 2:55 ` Baoquan He
2022-09-12 2:55 ` Baoquan He
2022-09-12 7:10 ` Christophe Leroy
2022-09-12 7:10 ` Christophe Leroy
2022-09-13 15:11 ` Baoquan He
2022-09-13 15:11 ` Baoquan He
2022-09-21 16:40 ` Christophe Leroy
2022-09-21 16:40 ` Christophe Leroy
2022-09-22 13:23 ` Baoquan He
2022-09-22 13:23 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 03/11] mm: ioremap: allow ARCH to have its own ioremap definition Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-21 6:57 ` Christoph Hellwig
2022-08-21 6:57 ` Christoph Hellwig
2022-08-23 2:42 ` Baoquan He
2022-08-23 2:42 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 04/11] arc: mm: Convert to GENERIC_IOREMAP Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 05/11] hexagon: " Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-20 1:23 ` Brian Cain
2022-08-20 1:23 ` Brian Cain
2022-08-21 7:00 ` Christoph Hellwig
2022-08-21 7:00 ` Christoph Hellwig
2022-08-28 15:08 ` Baoquan He
2022-08-28 15:08 ` Baoquan He
2022-08-22 6:38 ` Christophe Leroy
2022-08-22 6:38 ` Christophe Leroy
2022-08-28 15:12 ` Baoquan He
2022-08-28 15:12 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 06/11] ia64: " Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-21 6:58 ` Christoph Hellwig
2022-08-21 7:02 ` Christoph Hellwig
2022-08-21 7:02 ` Christoph Hellwig
2022-08-28 15:12 ` Baoquan He
2022-08-28 15:12 ` Baoquan He
2022-08-28 15:12 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 07/11] openrisc: " Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-21 7:03 ` Christoph Hellwig
2022-08-21 7:03 ` Christoph Hellwig
2022-08-21 7:03 ` Christoph Hellwig
2022-08-29 1:40 ` Baoquan He
2022-08-29 1:40 ` Baoquan He
2022-08-29 1:40 ` Baoquan He
2022-08-29 6:42 ` Stafford Horne
2022-08-29 6:42 ` Stafford Horne
2022-08-29 6:42 ` Stafford Horne
2022-08-29 8:18 ` Baoquan He
2022-08-29 8:18 ` Baoquan He
2022-08-29 8:18 ` Baoquan He
2022-08-30 6:05 ` Christophe Leroy
2022-08-30 6:05 ` Christophe Leroy
2022-08-30 6:05 ` Christophe Leroy
2022-08-29 6:32 ` Stafford Horne
2022-08-29 6:32 ` Stafford Horne
2022-08-29 6:32 ` Stafford Horne
2022-08-29 8:19 ` Baoquan He
2022-08-29 8:19 ` Baoquan He
2022-08-29 8:19 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 08/11] parisc: " Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-20 4:03 ` kernel test robot
2022-08-20 4:03 ` kernel test robot
2022-08-21 10:26 ` Baoquan He
2022-08-21 10:26 ` Baoquan He
2022-08-21 14:18 ` Helge Deller
2022-08-21 14:18 ` Helge Deller
2022-08-30 13:00 ` Baoquan He
2022-08-30 13:00 ` Baoquan He
2022-08-30 13:00 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 09/11] s390: " Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-21 7:05 ` Christoph Hellwig
2022-08-21 7:05 ` Christoph Hellwig
2022-08-22 15:08 ` Niklas Schnelle
2022-08-22 15:08 ` Niklas Schnelle
2022-08-31 8:59 ` Baoquan He
2022-08-31 8:59 ` Baoquan He
2022-08-22 15:19 ` Niklas Schnelle
2022-08-22 15:19 ` Niklas Schnelle
2022-08-31 8:58 ` Baoquan He
2022-08-31 8:58 ` Baoquan He
2022-08-23 12:30 ` Niklas Schnelle
2022-08-23 12:30 ` Niklas Schnelle
2022-08-31 8:50 ` Baoquan He
2022-08-31 8:50 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 10/11] sh: " Baoquan He
2022-08-20 0:31 ` Baoquan He
2022-08-20 3:41 ` kernel test robot
2022-09-01 10:39 ` Baoquan He
2022-09-01 10:39 ` Baoquan He
2022-09-01 10:39 ` Baoquan He
2022-09-01 12:11 ` [kbuild-all] " Chen, Rong A
2022-09-01 12:11 ` Chen, Rong A
2022-09-01 12:31 ` Baoquan He
2022-09-01 12:31 ` Baoquan He
2022-09-01 12:31 ` [kbuild-all] " Baoquan He
2022-09-02 9:48 ` Baoquan He
2022-09-02 9:48 ` Baoquan He
2022-09-02 9:48 ` Baoquan He
2022-08-21 7:06 ` Christoph Hellwig
2022-08-21 7:06 ` Christoph Hellwig
2022-09-01 7:36 ` Baoquan He
2022-09-01 7:36 ` Baoquan He
2022-08-20 0:31 ` [PATCH v2 11/11] xtensa: " Baoquan He
2022-08-20 0:31 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwQpqTlsMx0mX26a@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.