Re: [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Oliver Upton <oliver.upton@linux.dev>
To: Reiji Watanabe <reijiw@google.com>
Cc: kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	Andrew Jones <andrew.jones@linux.dev>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions
Date: Thu, 25 Aug 2022 10:21:49 -0700	[thread overview]
Message-ID: <YwevrW4YrHQQOyew@google.com> (raw)
In-Reply-To: <20220825050846.3418868-5-reijiw@google.com>

On Wed, Aug 24, 2022 at 10:08:41PM -0700, Reiji Watanabe wrote:
> Add helpers to enable breakpoint and watchpoint exceptions.
> 
> Signed-off-by: Reiji Watanabe <reijiw@google.com>
> ---
>  .../selftests/kvm/aarch64/debug-exceptions.c  | 25 ++++++++++---------
>  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> index 183ee16acb7d..713c7240b680 100644
> --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> @@ -128,10 +128,20 @@ static void enable_os_lock(void)
>  	GUEST_ASSERT(read_sysreg(oslsr_el1) & 2);
>  }
>  
> +static void enable_debug_bwp_exception(void)

uber-nit: enable_monitor_debug_exceptions()

(more closely matches the definition of MDSCR_EL1.MDE)

With that:

Reviewed-by: Oliver Upton <oliver.upton@linux.dev>

--
Thanks,
Oliver
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)

From: Oliver Upton <oliver.upton@linux.dev>
To: Reiji Watanabe <reijiw@google.com>
Cc: Marc Zyngier <maz@kernel.org>,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	Andrew Jones <andrew.jones@linux.dev>,
	Paolo Bonzini <pbonzini@redhat.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions
Date: Thu, 25 Aug 2022 10:21:49 -0700	[thread overview]
Message-ID: <YwevrW4YrHQQOyew@google.com> (raw)
In-Reply-To: <20220825050846.3418868-5-reijiw@google.com>

On Wed, Aug 24, 2022 at 10:08:41PM -0700, Reiji Watanabe wrote:
> Add helpers to enable breakpoint and watchpoint exceptions.
> 
> Signed-off-by: Reiji Watanabe <reijiw@google.com>
> ---
>  .../selftests/kvm/aarch64/debug-exceptions.c  | 25 ++++++++++---------
>  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> index 183ee16acb7d..713c7240b680 100644
> --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> @@ -128,10 +128,20 @@ static void enable_os_lock(void)
>  	GUEST_ASSERT(read_sysreg(oslsr_el1) & 2);
>  }
>  
> +static void enable_debug_bwp_exception(void)

uber-nit: enable_monitor_debug_exceptions()

(more closely matches the definition of MDSCR_EL1.MDE)

With that:

Reviewed-by: Oliver Upton <oliver.upton@linux.dev>

--
Thanks,
Oliver

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)

From: Oliver Upton <oliver.upton@linux.dev>
To: Reiji Watanabe <reijiw@google.com>
Cc: Marc Zyngier <maz@kernel.org>,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	Andrew Jones <andrew.jones@linux.dev>,
	Paolo Bonzini <pbonzini@redhat.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions
Date: Thu, 25 Aug 2022 10:21:49 -0700	[thread overview]
Message-ID: <YwevrW4YrHQQOyew@google.com> (raw)
In-Reply-To: <20220825050846.3418868-5-reijiw@google.com>

On Wed, Aug 24, 2022 at 10:08:41PM -0700, Reiji Watanabe wrote:
> Add helpers to enable breakpoint and watchpoint exceptions.
> 
> Signed-off-by: Reiji Watanabe <reijiw@google.com>
> ---
>  .../selftests/kvm/aarch64/debug-exceptions.c  | 25 ++++++++++---------
>  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> index 183ee16acb7d..713c7240b680 100644
> --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c
> @@ -128,10 +128,20 @@ static void enable_os_lock(void)
>  	GUEST_ASSERT(read_sysreg(oslsr_el1) & 2);
>  }
>  
> +static void enable_debug_bwp_exception(void)

uber-nit: enable_monitor_debug_exceptions()

(more closely matches the definition of MDSCR_EL1.MDE)

With that:

Reviewed-by: Oliver Upton <oliver.upton@linux.dev>

--
Thanks,
Oliver

next prev parent reply	other threads:[~2022-08-25 17:22 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25  5:08 [PATCH 0/9] KVM: arm64: selftests: Test linked {break,watch}points Reiji Watanabe
2022-08-25  5:08 ` Reiji Watanabe
2022-08-25  5:08 ` Reiji Watanabe
2022-08-25  5:08 ` [PATCH 1/9] KVM: arm64: selftests: Add helpers to extract a field of an ID register Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25 16:48   ` Oliver Upton
2022-08-25 16:48     ` Oliver Upton
2022-08-25 16:48     ` Oliver Upton
2022-08-25 16:52     ` Ricardo Koller
2022-08-25 16:52       ` Ricardo Koller
2022-08-25 16:52       ` Ricardo Koller
2022-08-25 16:58       ` Oliver Upton
2022-08-25 16:58         ` Oliver Upton
2022-08-25 16:58         ` Oliver Upton
2022-08-26  0:50         ` Reiji Watanabe
2022-08-26  0:50           ` Reiji Watanabe
2022-08-26  0:50           ` Reiji Watanabe
2022-08-25  5:08 ` [PATCH 2/9] KVM: arm64: selftests: Add write_dbg{b,w}{c,v}r helpers in debug-exceptions Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-09-09 19:40   ` Ricardo Koller
2022-09-09 19:40     ` Ricardo Koller
2022-09-09 19:40     ` Ricardo Koller
2022-08-25  5:08 ` [PATCH 3/9] KVM: arm64: selftests: Remove the hard-coded {b,w}pn#0 from debug-exceptions Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25 16:55   ` Oliver Upton
2022-08-25 16:55     ` Oliver Upton
2022-08-25 16:55     ` Oliver Upton
2022-08-26  0:53     ` Reiji Watanabe
2022-08-26  0:53       ` Reiji Watanabe
2022-08-26  0:53       ` Reiji Watanabe
2022-09-09 19:46   ` Ricardo Koller
2022-09-09 19:46     ` Ricardo Koller
2022-09-09 19:46     ` Ricardo Koller
2022-09-10  4:15     ` Reiji Watanabe
2022-09-10  4:15       ` Reiji Watanabe
2022-09-10  4:15       ` Reiji Watanabe
2022-08-25  5:08 ` [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25 17:21   ` Oliver Upton [this message]
2022-08-25 17:21     ` Oliver Upton
2022-08-25 17:21     ` Oliver Upton
2022-08-26  0:55     ` Reiji Watanabe
2022-08-26  0:55       ` Reiji Watanabe
2022-08-26  0:55       ` Reiji Watanabe
2022-09-09 19:57     ` Ricardo Koller
2022-09-09 19:57       ` Ricardo Koller
2022-09-09 19:57       ` Ricardo Koller
2022-08-25  5:08 ` [PATCH 5/9] KVM: arm64: selftests: Have debug_version() use cpuid_get_ufield() helper Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25 17:29   ` Oliver Upton
2022-08-25 17:29     ` Oliver Upton
2022-08-25 17:29     ` Oliver Upton
2022-08-26  0:59     ` Reiji Watanabe
2022-08-26  0:59       ` Reiji Watanabe
2022-08-26  0:59       ` Reiji Watanabe
2022-08-25  5:08 ` [PATCH 6/9] KVM: arm64: selftests: Change debug_version() to take ID_AA64DFR0_EL1 Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08 ` [PATCH 7/9] KVM: arm64: selftests: Add a test case for a linked breakpoint Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-26  1:29   ` Reiji Watanabe
2022-08-26  1:29     ` Reiji Watanabe
2022-08-26  1:29     ` Reiji Watanabe
2022-09-09 20:18     ` Ricardo Koller
2022-09-09 20:18       ` Ricardo Koller
2022-09-09 20:18       ` Ricardo Koller
2022-09-09 20:26       ` Ricardo Koller
2022-09-09 20:26         ` Ricardo Koller
2022-09-09 20:26         ` Ricardo Koller
2022-09-10  5:22         ` Reiji Watanabe
2022-09-10  5:22           ` Reiji Watanabe
2022-09-10  5:22           ` Reiji Watanabe
2022-09-09 21:01   ` Ricardo Koller
2022-09-09 21:01     ` Ricardo Koller
2022-09-09 21:01     ` Ricardo Koller
2022-09-10  5:19     ` Reiji Watanabe
2022-09-10  5:19       ` Reiji Watanabe
2022-09-10  5:19       ` Reiji Watanabe
2022-08-25  5:08 ` [PATCH 8/9] KVM: arm64: selftests: Add a test case for a linked watchpoint Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08 ` [PATCH 9/9] KVM: arm64: selftests: Test with every breakpoint/watchpoint Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe
2022-08-25  5:08   ` Reiji Watanabe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwevrW4YrHQQOyew@google.com \
    --to=oliver.upton@linux.dev \
    --cc=andrew.jones@linux.dev \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=reijiw@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.