From: Jason Gunthorpe <jgg@nvidia.com>
To: Oded Gabbay <ogabbay@kernel.org>
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
"Christian König" <christian.koenig@amd.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"KVM list" <kvm@vger.kernel.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Leon Romanovsky" <leon@kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
"Maor Gottlieb" <maorg@nvidia.com>
Subject: Re: Fwd: [PATCH 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf
Date: Fri, 26 Aug 2022 15:10:32 -0300 [thread overview]
Message-ID: <YwkMmFjpsKuJroBz@nvidia.com> (raw)
In-Reply-To: <CAFCwf13kOBri3NDO=6SGHOXq-M=wndbdcMxik9bf8H1AUCE1tQ@mail.gmail.com>
On Sun, Aug 21, 2022 at 04:51:34PM +0300, Oded Gabbay wrote:
> > +static void vfio_pci_dma_buf_unmap(struct dma_buf_attachment *attachment,
> > + struct sg_table *sgt,
> > + enum dma_data_direction dir)
> > +{
> > + struct vfio_pci_dma_buf *priv = attachment->dmabuf->priv;
> > +
> > + dma_unmap_resource(attachment->dev, sg_dma_address(sgt->sgl),
> > + priv->dmabuf->size, dir, DMA_ATTR_SKIP_CPU_SYNC);
> > + sg_free_table(sgt);
> Before calling sg_free_table(), you need to restore the orig_nents as
> it is used in that function to free the allocated memory of the sgt.
Oops, right, thanks good catch
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Oded Gabbay <ogabbay@kernel.org>
Cc: "Leon Romanovsky" <leon@kernel.org>,
"KVM list" <kvm@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Cornelia Huck" <cohuck@redhat.com>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Maor Gottlieb" <maorg@nvidia.com>,
"Christian König" <christian.koenig@amd.com>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: Fwd: [PATCH 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf
Date: Fri, 26 Aug 2022 15:10:32 -0300 [thread overview]
Message-ID: <YwkMmFjpsKuJroBz@nvidia.com> (raw)
In-Reply-To: <CAFCwf13kOBri3NDO=6SGHOXq-M=wndbdcMxik9bf8H1AUCE1tQ@mail.gmail.com>
On Sun, Aug 21, 2022 at 04:51:34PM +0300, Oded Gabbay wrote:
> > +static void vfio_pci_dma_buf_unmap(struct dma_buf_attachment *attachment,
> > + struct sg_table *sgt,
> > + enum dma_data_direction dir)
> > +{
> > + struct vfio_pci_dma_buf *priv = attachment->dmabuf->priv;
> > +
> > + dma_unmap_resource(attachment->dev, sg_dma_address(sgt->sgl),
> > + priv->dmabuf->size, dir, DMA_ATTR_SKIP_CPU_SYNC);
> > + sg_free_table(sgt);
> Before calling sg_free_table(), you need to restore the orig_nents as
> it is used in that function to free the allocated memory of the sgt.
Oops, right, thanks good catch
Jason
next prev parent reply other threads:[~2022-08-26 18:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 16:11 [PATCH 0/4] Allow MMIO regions to be exported through dma-buf Jason Gunthorpe
2022-08-17 16:11 ` Jason Gunthorpe
2022-08-17 16:11 ` [PATCH 1/4] dma-buf: Add dma_buf_try_get() Jason Gunthorpe
2022-08-17 16:11 ` Jason Gunthorpe
2022-08-17 16:11 ` [PATCH 2/4] vfio: Add vfio_device_get() Jason Gunthorpe
2022-08-17 16:11 ` Jason Gunthorpe
2022-08-17 16:11 ` [PATCH 3/4] vfio_pci: Do not open code pci_try_reset_function() Jason Gunthorpe
2022-08-17 16:11 ` Jason Gunthorpe
2022-08-17 16:11 ` [PATCH 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf Jason Gunthorpe
2022-08-17 16:11 ` Jason Gunthorpe
2022-08-21 13:51 ` Fwd: " Oded Gabbay
2022-08-21 13:51 ` Oded Gabbay
2022-08-26 18:10 ` Jason Gunthorpe [this message]
2022-08-26 18:10 ` Jason Gunthorpe
2022-08-29 5:04 ` Yan Zhao
2022-08-29 5:04 ` Yan Zhao
2022-08-29 12:26 ` Jason Gunthorpe
2022-08-29 12:26 ` Jason Gunthorpe
2022-08-18 11:07 ` [PATCH 0/4] " Christian König
2022-08-18 11:07 ` Christian König
2022-08-18 12:03 ` Jason Gunthorpe
2022-08-18 12:03 ` Jason Gunthorpe
2022-08-18 12:58 ` Christian König
2022-08-18 12:58 ` Christian König
2022-08-18 13:16 ` Jason Gunthorpe
2022-08-18 13:16 ` Jason Gunthorpe
2022-08-18 13:37 ` Christian König
2022-08-18 13:37 ` Christian König
2022-08-19 13:11 ` Jason Gunthorpe
2022-08-19 13:11 ` Jason Gunthorpe
2022-08-19 13:33 ` Christian König
2022-08-19 13:33 ` Christian König
2022-08-19 13:39 ` Jason Gunthorpe
2022-08-19 13:39 ` Jason Gunthorpe
2022-08-19 13:47 ` Christian König
2022-08-19 13:47 ` Christian König
2022-08-18 12:05 ` Jason Gunthorpe
2022-08-18 12:05 ` Jason Gunthorpe
2022-08-22 21:58 ` Alex Williamson
2022-08-22 21:58 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwkMmFjpsKuJroBz@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=christian.koenig@amd.com \
--cc=cohuck@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=ogabbay@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.