From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
Cc: "Sean Paul" <seanpaul@chromium.org>,
"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
"Leo Li" <sunpeng.li@amd.com>,
dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com,
"Wenjing Liu" <wenjing.liu@amd.com>,
linux-kernel@vger.kernel.org,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"Fangzhi Zuo" <Jerry.Zuo@amd.com>,
"hersen wu" <hersenxs.wu@amd.com>,
amd-gfx@lists.freedesktop.org, "Daniel Vetter" <daniel@ffwll.ch>,
"Wayne Lin" <Wayne.Lin@amd.com>,
"Alex Deuc her" <alexander.deucher@amd.com>,
"Bhanuprakash Modem" <bhanuprakash.modem@intel.com>,
"Yongzhi Liu" <lyz_cs@pku.edu.cn>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Thelford Williams" <tdwilliamsiv@gmail.com>
Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()
Date: Tue, 6 Sep 2022 17:06:45 +0200 [thread overview]
Message-ID: <YxdiBRCmhlrRxAz5@kroah.com> (raw)
In-Reply-To: <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com>
On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs_lookup() the result must have dput() called on it,
> > > otherwise the memory will leak over time. Fix this up by properly
> > > calling dput().
> > >
> > > Cc: Harry Wentland <harry.wentland@amd.com>
> > > Cc: Leo Li <sunpeng.li@amd.com>
> > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: David Airlie <airlied@linux.ie>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Wayne Lin <Wayne.Lin@amd.com>
> > > Cc: hersen wu <hersenxs.wu@amd.com>
> > > Cc: Wenjing Liu <wenjing.liu@amd.com>
> > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > > Cc: Thelford Williams <tdwilliamsiv@gmail.com>
> > > Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
> > > Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
> > > Cc: Mikita Lipski <mikita.lipski@amd.com>
> > > Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > > Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > > Cc: Sean Paul <seanpaul@chromium.org>
> > > Cc: amd-gfx@lists.freedesktop.org
> > > Cc: dri-devel@lists.freedesktop.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> >
> > Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> > maintainer add that here, or do you all want me to resend it with that
> > item added?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
> Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I
> merge it into amd-staging-drm-next.
Yes, please add the cc: stable@ line to the body of the patch, sorry I
forgot that.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
Cc: "Sean Paul" <seanpaul@chromium.org>,
"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
"Leo Li" <sunpeng.li@amd.com>,
dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com,
"Wenjing Liu" <wenjing.liu@amd.com>,
linux-kernel@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
"Fangzhi Zuo" <Jerry.Zuo@amd.com>,
"hersen wu" <hersenxs.wu@amd.com>,
amd-gfx@lists.freedesktop.org, "Wayne Lin" <Wayne.Lin@amd.com>,
"Alex Deuc her" <alexander.deucher@amd.com>,
"Bhanuprakash Modem" <bhanuprakash.modem@intel.com>,
"Yongzhi Liu" <lyz_cs@pku.edu.cn>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Thelford Williams" <tdwilliamsiv@gmail.com>
Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()
Date: Tue, 6 Sep 2022 17:06:45 +0200 [thread overview]
Message-ID: <YxdiBRCmhlrRxAz5@kroah.com> (raw)
In-Reply-To: <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com>
On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs_lookup() the result must have dput() called on it,
> > > otherwise the memory will leak over time. Fix this up by properly
> > > calling dput().
> > >
> > > Cc: Harry Wentland <harry.wentland@amd.com>
> > > Cc: Leo Li <sunpeng.li@amd.com>
> > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: David Airlie <airlied@linux.ie>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Wayne Lin <Wayne.Lin@amd.com>
> > > Cc: hersen wu <hersenxs.wu@amd.com>
> > > Cc: Wenjing Liu <wenjing.liu@amd.com>
> > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > > Cc: Thelford Williams <tdwilliamsiv@gmail.com>
> > > Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
> > > Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
> > > Cc: Mikita Lipski <mikita.lipski@amd.com>
> > > Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > > Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > > Cc: Sean Paul <seanpaul@chromium.org>
> > > Cc: amd-gfx@lists.freedesktop.org
> > > Cc: dri-devel@lists.freedesktop.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> >
> > Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> > maintainer add that here, or do you all want me to resend it with that
> > item added?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
> Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I
> merge it into amd-staging-drm-next.
Yes, please add the cc: stable@ line to the body of the patch, sorry I
forgot that.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
Cc: "Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Alex Deuc her" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Wayne Lin" <Wayne.Lin@amd.com>,
"hersen wu" <hersenxs.wu@amd.com>,
"Wenjing Liu" <wenjing.liu@amd.com>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"Thelford Williams" <tdwilliamsiv@gmail.com>,
"Fangzhi Zuo" <Jerry.Zuo@amd.com>,
"Yongzhi Liu" <lyz_cs@pku.edu.cn>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
"Bhanuprakash Modem" <bhanuprakash.modem@intel.com>,
"Sean Paul" <seanpaul@chromium.org>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()
Date: Tue, 6 Sep 2022 17:06:45 +0200 [thread overview]
Message-ID: <YxdiBRCmhlrRxAz5@kroah.com> (raw)
In-Reply-To: <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com>
On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs_lookup() the result must have dput() called on it,
> > > otherwise the memory will leak over time. Fix this up by properly
> > > calling dput().
> > >
> > > Cc: Harry Wentland <harry.wentland@amd.com>
> > > Cc: Leo Li <sunpeng.li@amd.com>
> > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: David Airlie <airlied@linux.ie>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Wayne Lin <Wayne.Lin@amd.com>
> > > Cc: hersen wu <hersenxs.wu@amd.com>
> > > Cc: Wenjing Liu <wenjing.liu@amd.com>
> > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > > Cc: Thelford Williams <tdwilliamsiv@gmail.com>
> > > Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
> > > Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
> > > Cc: Mikita Lipski <mikita.lipski@amd.com>
> > > Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > > Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > > Cc: Sean Paul <seanpaul@chromium.org>
> > > Cc: amd-gfx@lists.freedesktop.org
> > > Cc: dri-devel@lists.freedesktop.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> >
> > Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> > maintainer add that here, or do you all want me to resend it with that
> > item added?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
> Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I
> merge it into amd-staging-drm-next.
Yes, please add the cc: stable@ line to the body of the patch, sorry I
forgot that.
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-06 16:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 13:01 [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup() Greg Kroah-Hartman
2022-09-02 13:01 ` Greg Kroah-Hartman
2022-09-02 13:01 ` Greg Kroah-Hartman
2022-09-02 13:10 ` Greg Kroah-Hartman
2022-09-02 13:10 ` Greg Kroah-Hartman
2022-09-02 13:10 ` Greg Kroah-Hartman
2022-09-06 14:52 ` Rodrigo Siqueira Jordao
2022-09-06 14:52 ` Rodrigo Siqueira Jordao
2022-09-06 14:52 ` Rodrigo Siqueira Jordao
2022-09-06 15:06 ` Greg Kroah-Hartman [this message]
2022-09-06 15:06 ` Greg Kroah-Hartman
2022-09-06 15:06 ` Greg Kroah-Hartman
2022-09-06 15:39 ` Rodrigo Siqueira Jordao
2022-09-06 15:39 ` Rodrigo Siqueira Jordao
2022-09-06 15:39 ` Rodrigo Siqueira Jordao
2022-09-06 15:49 ` Greg Kroah-Hartman
2022-09-06 15:49 ` Greg Kroah-Hartman
2022-09-06 15:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxdiBRCmhlrRxAz5@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jerry.Zuo@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhanuprakash.modem@intel.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=hersenxs.wu@amd.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyz_cs@pku.edu.cn \
--cc=mikita.lipski@amd.com \
--cc=patrik.r.jakobsson@gmail.com \
--cc=seanpaul@chromium.org \
--cc=sunpeng.li@amd.com \
--cc=tdwilliamsiv@gmail.com \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.