[PATCH 0/2] Remove unused declarations

[PATCH 0/2] Remove unused declarations

[Gaosheng Cui]

This series contains a few cleanup patches, to remove unused
declarations which have been removed. Thanks!

Gaosheng Cui (2):
  perf sort: remove hist_entry__sort_list and sort__first_dimension
    declaration
  perf tools: remove perf_pmu_lex declaration

 tools/perf/util/pmu.y  | 2 --
 tools/perf/util/sort.h | 2 --
 2 files changed, 4 deletions(-)

-- 
2.25.1

[PATCH 1/2] perf sort: remove hist_entry__sort_list and sort__first_dimension declaration

[Gaosheng Cui]

hist_entry__sort_list and sort__first_dimension have been removed
since commit cfaa154b2335 ("perf tools: Get rid of obsolete
hist_entry__sort_list"), so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 tools/perf/util/sort.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index 2ddc00d1c464..af14eb46c2b6 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -34,7 +34,6 @@ extern struct sort_entry sort_dso_to;
 extern struct sort_entry sort_sym_from;
 extern struct sort_entry sort_sym_to;
 extern struct sort_entry sort_srcline;
-extern enum sort_type sort__first_dimension;
 extern const char default_mem_sort_order[];
 
 struct res_sample {
@@ -295,7 +294,6 @@ struct block_hist {
 };
 
 extern struct sort_entry sort_thread;
-extern struct list_head hist_entry__sort_list;
 
 struct evlist;
 struct tep_handle;
-- 
2.25.1

[PATCH 2/2] perf tools: remove perf_pmu_lex declaration

[Gaosheng Cui]

perf_pmu_lex has been removed since
commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 tools/perf/util/pmu.y | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
index bfd7e8509869..0dab0ec2eff7 100644
--- a/tools/perf/util/pmu.y
+++ b/tools/perf/util/pmu.y
@@ -10,8 +10,6 @@
 #include <string.h>
 #include "pmu.h"
 
-extern int perf_pmu_lex (void);
-
 #define ABORT_ON(val) \
 do { \
         if (val) \
-- 
2.25.1

Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration

[James Clark]

On 09/09/2022 05:45, Gaosheng Cui wrote:
> perf_pmu_lex has been removed since
> commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> so remove it.

Not 100% sure if that is the right commit to reference because it didn't
touch pmu.y.

perf_pmu_lex is still used and there are plenty of references to it, but
maybe the extern declaration isn't needed anymore because it still
builds for me with this change.

> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  tools/perf/util/pmu.y | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
> index bfd7e8509869..0dab0ec2eff7 100644
> --- a/tools/perf/util/pmu.y
> +++ b/tools/perf/util/pmu.y
> @@ -10,8 +10,6 @@
>  #include <string.h>
>  #include "pmu.h"
>  
> -extern int perf_pmu_lex (void);
> -
>  #define ABORT_ON(val) \
>  do { \
>          if (val) \

Re: [PATCH 0/2] Remove unused declarations

[Arnaldo Carvalho de Melo]

Em Fri, Sep 09, 2022 at 12:45:40PM +0800, Gaosheng Cui escreveu:
> This series contains a few cleanup patches, to remove unused
> declarations which have been removed. Thanks!

Thanks, applied.

- Arnaldo

 
> Gaosheng Cui (2):
>   perf sort: remove hist_entry__sort_list and sort__first_dimension
>     declaration
>   perf tools: remove perf_pmu_lex declaration
> 
>  tools/perf/util/pmu.y  | 2 --
>  tools/perf/util/sort.h | 2 --
>  2 files changed, 4 deletions(-)
> 
> -- 
> 2.25.1

-- 

- Arnaldo

Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration

[Arnaldo Carvalho de Melo]

Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
> 
> 
> On 09/09/2022 05:45, Gaosheng Cui wrote:
> > perf_pmu_lex has been removed since
> > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > so remove it.
> 
> Not 100% sure if that is the right commit to reference because it didn't
> touch pmu.y.

Yeah, indeed, unsure if at that time the declaration was needed.
 
> perf_pmu_lex is still used and there are plenty of references to it, but
> maybe the extern declaration isn't needed anymore because it still
> builds for me with this change.

Ditto here, I'll remove the reference and rewrite the cset log a bit.

- Arnaldo

Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration

[Arnaldo Carvalho de Melo]

Em Fri, Sep 09, 2022 at 10:43:52AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
> > 
> > 
> > On 09/09/2022 05:45, Gaosheng Cui wrote:
> > > perf_pmu_lex has been removed since
> > > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > > so remove it.
> > 
> > Not 100% sure if that is the right commit to reference because it didn't
> > touch pmu.y.
> 
> Yeah, indeed, unsure if at that time the declaration was needed.
>  
> > perf_pmu_lex is still used and there are plenty of references to it, but
> > maybe the extern declaration isn't needed anymore because it still
> > builds for me with this change.
> 
> Ditto here, I'll remove the reference and rewrite the cset log a bit.

I left it as:

perf pmu: Remove perf_pmu_lex() needless declaration

It builds without it, perhaps with some older combination of flex/bison
we needed this, clean it up a bit removing this.