* [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'
@ 2022-09-12 18:45 kernel test robot
2022-09-14 9:36 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: kernel test robot @ 2022-09-12 18:45 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: kbuild-all, Bjorn Helgaas, linux-pci, Lorenzo Pieralisi
tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
head: 2023f9c9190e657b9853a442899a52b14253aea3
commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
git fetch --no-tags lpieralisi-pci pci/dwc
git checkout 2023f9c9190e657b9853a442899a52b14253aea3
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
>> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
373 | ret = gpiod_count(dev, "hisilicon,clken");
| ^~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/gpiod_count +373 drivers/pci/controller/dwc/pcie-kirin.c
364
365 static int kirin_pcie_get_gpio_enable(struct kirin_pcie *pcie,
366 struct platform_device *pdev)
367 {
368 struct device *dev = &pdev->dev;
369 char name[32];
370 int ret, i;
371
372 /* This is an optional property */
> 373 ret = gpiod_count(dev, "hisilicon,clken");
374 if (ret < 0)
375 return 0;
376
377 if (ret > MAX_PCI_SLOTS) {
378 dev_err(dev, "Too many GPIO clock requests!\n");
379 return -EINVAL;
380 }
381
382 pcie->n_gpio_clkreq = ret;
383
384 for (i = 0; i < pcie->n_gpio_clkreq; i++) {
385 pcie->gpio_id_clkreq[i] = of_get_named_gpio(dev->of_node,
386 "hisilicon,clken-gpios", i);
387 if (pcie->gpio_id_clkreq[i] < 0)
388 return pcie->gpio_id_clkreq[i];
389
390 sprintf(name, "pcie_clkreq_%d", i);
391 pcie->clkreq_names[i] = devm_kstrdup_const(dev, name,
392 GFP_KERNEL);
393 if (!pcie->clkreq_names[i])
394 return -ENOMEM;
395 }
396
397 return 0;
398 }
399
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'
2022-09-12 18:45 [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' kernel test robot
@ 2022-09-14 9:36 ` Andy Shevchenko
2022-09-14 9:42 ` Linus Walleij
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2022-09-14 9:36 UTC (permalink / raw)
To: kernel test robot, Linus Walleij
Cc: kbuild-all, Bjorn Helgaas, linux-pci, Lorenzo Pieralisi
On Tue, Sep 13, 2022 at 02:45:12AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
> head: 2023f9c9190e657b9853a442899a52b14253aea3
> commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
> config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp@intel.com/config)
> compiler: xtensa-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
> git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> git fetch --no-tags lpieralisi-pci pci/dwc
> git checkout 2023f9c9190e657b9853a442899a52b14253aea3
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
> >> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
> 373 | ret = gpiod_count(dev, "hisilicon,clken");
> | ^~~~~~~~~~~
> cc1: some warnings being treated as errors
It's only possible if we miss to include gpio/consumer.h which is the case here
(at least on some architectures).
Lorenzo, what do you want me to do? I can add the missed include, but looking
at the code it needs conversion to GPIO descriptors altogether.
Linus, don't you have a patch for this driver already? (I don't remember
if I have seen a branch in your tree regarding this long-standing conversion
to GPIO descriptors all over the kernel.)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'
2022-09-14 9:36 ` Andy Shevchenko
@ 2022-09-14 9:42 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2022-09-14 9:42 UTC (permalink / raw)
To: Andy Shevchenko, Dmitry Torokhov
Cc: kernel test robot, kbuild-all, Bjorn Helgaas, linux-pci,
Lorenzo Pieralisi
On Wed, Sep 14, 2022 at 11:38 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Tue, Sep 13, 2022 at 02:45:12AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
> > head: 2023f9c9190e657b9853a442899a52b14253aea3
> > commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
> > config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp@intel.com/config)
> > compiler: xtensa-linux-gcc (GCC) 12.1.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
> > git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > git fetch --no-tags lpieralisi-pci pci/dwc
> > git checkout 2023f9c9190e657b9853a442899a52b14253aea3
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
> > >> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
> > 373 | ret = gpiod_count(dev, "hisilicon,clken");
> > | ^~~~~~~~~~~
> > cc1: some warnings being treated as errors
>
>
> It's only possible if we miss to include gpio/consumer.h which is the case here
> (at least on some architectures).
>
> Lorenzo, what do you want me to do? I can add the missed include, but looking
> at the code it needs conversion to GPIO descriptors altogether.
>
> Linus, don't you have a patch for this driver already? (I don't remember
> if I have seen a branch in your tree regarding this long-standing conversion
> to GPIO descriptors all over the kernel.)
Not me, by Dmitry T sent some really nice PCI host GPIOD conversions
recently, not this one though.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'
@ 2022-09-14 9:42 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2022-09-14 9:42 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2597 bytes --]
On Wed, Sep 14, 2022 at 11:38 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Tue, Sep 13, 2022 at 02:45:12AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
> > head: 2023f9c9190e657b9853a442899a52b14253aea3
> > commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
> > config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp(a)intel.com/config)
> > compiler: xtensa-linux-gcc (GCC) 12.1.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
> > git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > git fetch --no-tags lpieralisi-pci pci/dwc
> > git checkout 2023f9c9190e657b9853a442899a52b14253aea3
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
> > >> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
> > 373 | ret = gpiod_count(dev, "hisilicon,clken");
> > | ^~~~~~~~~~~
> > cc1: some warnings being treated as errors
>
>
> It's only possible if we miss to include gpio/consumer.h which is the case here
> (at least on some architectures).
>
> Lorenzo, what do you want me to do? I can add the missed include, but looking
> at the code it needs conversion to GPIO descriptors altogether.
>
> Linus, don't you have a patch for this driver already? (I don't remember
> if I have seen a branch in your tree regarding this long-standing conversion
> to GPIO descriptors all over the kernel.)
Not me, by Dmitry T sent some really nice PCI host GPIOD conversions
recently, not this one though.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'
2022-09-14 9:42 ` Linus Walleij
@ 2022-09-14 10:05 ` Dmitry Torokhov
-1 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2022-09-14 10:05 UTC (permalink / raw)
To: Linus Walleij
Cc: Andy Shevchenko, kernel test robot, kbuild-all, Bjorn Helgaas,
linux-pci, Lorenzo Pieralisi
On Wed, Sep 14, 2022 at 11:42:29AM +0200, Linus Walleij wrote:
> On Wed, Sep 14, 2022 at 11:38 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Sep 13, 2022 at 02:45:12AM +0800, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
> > > head: 2023f9c9190e657b9853a442899a52b14253aea3
> > > commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
> > > config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp@intel.com/config)
> > > compiler: xtensa-linux-gcc (GCC) 12.1.0
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
> > > git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > > git fetch --no-tags lpieralisi-pci pci/dwc
> > > git checkout 2023f9c9190e657b9853a442899a52b14253aea3
> > > # save the config file
> > > mkdir build_dir && cp config build_dir/.config
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
> > > >> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
> > > 373 | ret = gpiod_count(dev, "hisilicon,clken");
> > > | ^~~~~~~~~~~
> > > cc1: some warnings being treated as errors
> >
> >
> > It's only possible if we miss to include gpio/consumer.h which is the case here
> > (at least on some architectures).
> >
> > Lorenzo, what do you want me to do? I can add the missed include, but looking
> > at the code it needs conversion to GPIO descriptors altogether.
> >
> > Linus, don't you have a patch for this driver already? (I don't remember
> > if I have seen a branch in your tree regarding this long-standing conversion
> > to GPIO descriptors all over the kernel.)
>
> Not me, by Dmitry T sent some really nice PCI host GPIOD conversions
> recently, not this one though.
No, I do not have any outstanding changes for this driver. Maybe Andy
can finish the conversion to gpiod?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'
@ 2022-09-14 10:05 ` Dmitry Torokhov
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2022-09-14 10:05 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2858 bytes --]
On Wed, Sep 14, 2022 at 11:42:29AM +0200, Linus Walleij wrote:
> On Wed, Sep 14, 2022 at 11:38 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Sep 13, 2022 at 02:45:12AM +0800, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
> > > head: 2023f9c9190e657b9853a442899a52b14253aea3
> > > commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
> > > config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp(a)intel.com/config)
> > > compiler: xtensa-linux-gcc (GCC) 12.1.0
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
> > > git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > > git fetch --no-tags lpieralisi-pci pci/dwc
> > > git checkout 2023f9c9190e657b9853a442899a52b14253aea3
> > > # save the config file
> > > mkdir build_dir && cp config build_dir/.config
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
> > > >> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
> > > 373 | ret = gpiod_count(dev, "hisilicon,clken");
> > > | ^~~~~~~~~~~
> > > cc1: some warnings being treated as errors
> >
> >
> > It's only possible if we miss to include gpio/consumer.h which is the case here
> > (at least on some architectures).
> >
> > Lorenzo, what do you want me to do? I can add the missed include, but looking
> > at the code it needs conversion to GPIO descriptors altogether.
> >
> > Linus, don't you have a patch for this driver already? (I don't remember
> > if I have seen a branch in your tree regarding this long-standing conversion
> > to GPIO descriptors all over the kernel.)
>
> Not me, by Dmitry T sent some really nice PCI host GPIOD conversions
> recently, not this one though.
No, I do not have any outstanding changes for this driver. Maybe Andy
can finish the conversion to gpiod?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'
2022-09-14 10:05 ` Dmitry Torokhov
(?)
@ 2022-09-14 10:14 ` Andy Shevchenko
2022-09-14 15:01 ` Lorenzo Pieralisi
-1 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2022-09-14 10:14 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Linus Walleij, kernel test robot, kbuild-all, Bjorn Helgaas,
linux-pci, Lorenzo Pieralisi
On Wed, Sep 14, 2022 at 03:05:24AM -0700, Dmitry Torokhov wrote:
> On Wed, Sep 14, 2022 at 11:42:29AM +0200, Linus Walleij wrote:
> > On Wed, Sep 14, 2022 at 11:38 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Tue, Sep 13, 2022 at 02:45:12AM +0800, kernel test robot wrote:
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
> > > > head: 2023f9c9190e657b9853a442899a52b14253aea3
> > > > commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
> > > > config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp@intel.com/config)
> > > > compiler: xtensa-linux-gcc (GCC) 12.1.0
> > > > reproduce (this is a W=1 build):
> > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > chmod +x ~/bin/make.cross
> > > > # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
> > > > git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > > > git fetch --no-tags lpieralisi-pci pci/dwc
> > > > git checkout 2023f9c9190e657b9853a442899a52b14253aea3
> > > > # save the config file
> > > > mkdir build_dir && cp config build_dir/.config
> > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
> > > >
> > > > If you fix the issue, kindly add following tag where applicable
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
> > > > >> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
> > > > 373 | ret = gpiod_count(dev, "hisilicon,clken");
> > > > | ^~~~~~~~~~~
> > > > cc1: some warnings being treated as errors
> > >
> > >
> > > It's only possible if we miss to include gpio/consumer.h which is the case here
> > > (at least on some architectures).
> > >
> > > Lorenzo, what do you want me to do? I can add the missed include, but looking
> > > at the code it needs conversion to GPIO descriptors altogether.
> > >
> > > Linus, don't you have a patch for this driver already? (I don't remember
> > > if I have seen a branch in your tree regarding this long-standing conversion
> > > to GPIO descriptors all over the kernel.)
> >
> > Not me, by Dmitry T sent some really nice PCI host GPIOD conversions
> > recently, not this one though.
>
> No, I do not have any outstanding changes for this driver. Maybe Andy
> can finish the conversion to gpiod?
I can, but want to hear maintainer what is the best approach here.
My scope of the changes is to get rid of of_gpio_named_count() in
the exported namespace.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'
2022-09-14 10:14 ` Andy Shevchenko
@ 2022-09-14 15:01 ` Lorenzo Pieralisi
0 siblings, 0 replies; 9+ messages in thread
From: Lorenzo Pieralisi @ 2022-09-14 15:01 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dmitry Torokhov, Linus Walleij, kernel test robot, kbuild-all,
Bjorn Helgaas, linux-pci
On Wed, Sep 14, 2022 at 01:14:41PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 14, 2022 at 03:05:24AM -0700, Dmitry Torokhov wrote:
> > On Wed, Sep 14, 2022 at 11:42:29AM +0200, Linus Walleij wrote:
> > > On Wed, Sep 14, 2022 at 11:38 AM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Tue, Sep 13, 2022 at 02:45:12AM +0800, kernel test robot wrote:
> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
> > > > > head: 2023f9c9190e657b9853a442899a52b14253aea3
> > > > > commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
> > > > > config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp@intel.com/config)
> > > > > compiler: xtensa-linux-gcc (GCC) 12.1.0
> > > > > reproduce (this is a W=1 build):
> > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > > chmod +x ~/bin/make.cross
> > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
> > > > > git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > > > > git fetch --no-tags lpieralisi-pci pci/dwc
> > > > > git checkout 2023f9c9190e657b9853a442899a52b14253aea3
> > > > > # save the config file
> > > > > mkdir build_dir && cp config build_dir/.config
> > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
> > > > >
> > > > > If you fix the issue, kindly add following tag where applicable
> > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > >
> > > > > All errors (new ones prefixed by >>):
> > > > >
> > > > > drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
> > > > > >> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
> > > > > 373 | ret = gpiod_count(dev, "hisilicon,clken");
> > > > > | ^~~~~~~~~~~
> > > > > cc1: some warnings being treated as errors
> > > >
> > > >
> > > > It's only possible if we miss to include gpio/consumer.h which is the case here
> > > > (at least on some architectures).
> > > >
> > > > Lorenzo, what do you want me to do? I can add the missed include, but looking
> > > > at the code it needs conversion to GPIO descriptors altogether.
> > > >
> > > > Linus, don't you have a patch for this driver already? (I don't remember
> > > > if I have seen a branch in your tree regarding this long-standing conversion
> > > > to GPIO descriptors all over the kernel.)
> > >
> > > Not me, by Dmitry T sent some really nice PCI host GPIOD conversions
> > > recently, not this one though.
> >
> > No, I do not have any outstanding changes for this driver. Maybe Andy
> > can finish the conversion to gpiod?
>
> I can, but want to hear maintainer what is the best approach here.
> My scope of the changes is to get rid of of_gpio_named_count() in
> the exported namespace.
I can add the missed include to fix it and then you can apply the gpiod
changes on top of it.
Lorenzo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count'
@ 2022-09-14 15:01 ` Lorenzo Pieralisi
0 siblings, 0 replies; 9+ messages in thread
From: Lorenzo Pieralisi @ 2022-09-14 15:01 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3433 bytes --]
On Wed, Sep 14, 2022 at 01:14:41PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 14, 2022 at 03:05:24AM -0700, Dmitry Torokhov wrote:
> > On Wed, Sep 14, 2022 at 11:42:29AM +0200, Linus Walleij wrote:
> > > On Wed, Sep 14, 2022 at 11:38 AM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Tue, Sep 13, 2022 at 02:45:12AM +0800, kernel test robot wrote:
> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
> > > > > head: 2023f9c9190e657b9853a442899a52b14253aea3
> > > > > commit: 2023f9c9190e657b9853a442899a52b14253aea3 [3/3] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
> > > > > config: xtensa-randconfig-r023-20220911 (https://download.01.org/0day-ci/archive/20220913/202209130205.CPp5dG1q-lkp(a)intel.com/config)
> > > > > compiler: xtensa-linux-gcc (GCC) 12.1.0
> > > > > reproduce (this is a W=1 build):
> > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > > chmod +x ~/bin/make.cross
> > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=2023f9c9190e657b9853a442899a52b14253aea3
> > > > > git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > > > > git fetch --no-tags lpieralisi-pci pci/dwc
> > > > > git checkout 2023f9c9190e657b9853a442899a52b14253aea3
> > > > > # save the config file
> > > > > mkdir build_dir && cp config build_dir/.config
> > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/pci/controller/dwc/
> > > > >
> > > > > If you fix the issue, kindly add following tag where applicable
> > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > >
> > > > > All errors (new ones prefixed by >>):
> > > > >
> > > > > drivers/pci/controller/dwc/pcie-kirin.c: In function 'kirin_pcie_get_gpio_enable':
> > > > > >> drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' [-Werror=implicit-function-declaration]
> > > > > 373 | ret = gpiod_count(dev, "hisilicon,clken");
> > > > > | ^~~~~~~~~~~
> > > > > cc1: some warnings being treated as errors
> > > >
> > > >
> > > > It's only possible if we miss to include gpio/consumer.h which is the case here
> > > > (at least on some architectures).
> > > >
> > > > Lorenzo, what do you want me to do? I can add the missed include, but looking
> > > > at the code it needs conversion to GPIO descriptors altogether.
> > > >
> > > > Linus, don't you have a patch for this driver already? (I don't remember
> > > > if I have seen a branch in your tree regarding this long-standing conversion
> > > > to GPIO descriptors all over the kernel.)
> > >
> > > Not me, by Dmitry T sent some really nice PCI host GPIOD conversions
> > > recently, not this one though.
> >
> > No, I do not have any outstanding changes for this driver. Maybe Andy
> > can finish the conversion to gpiod?
>
> I can, but want to hear maintainer what is the best approach here.
> My scope of the changes is to get rid of of_gpio_named_count() in
> the exported namespace.
I can add the missed include to fix it and then you can apply the gpiod
changes on top of it.
Lorenzo
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-09-14 15:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-12 18:45 [lpieralisi-pci:pci/dwc 3/3] drivers/pci/controller/dwc/pcie-kirin.c:373:15: error: implicit declaration of function 'gpiod_count' kernel test robot
2022-09-14 9:36 ` Andy Shevchenko
2022-09-14 9:42 ` Linus Walleij
2022-09-14 9:42 ` Linus Walleij
2022-09-14 10:05 ` Dmitry Torokhov
2022-09-14 10:05 ` Dmitry Torokhov
2022-09-14 10:14 ` Andy Shevchenko
2022-09-14 15:01 ` Lorenzo Pieralisi
2022-09-14 15:01 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.