From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
stable@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call
Date: Thu, 6 Oct 2022 08:37:09 -0300 [thread overview]
Message-ID: <Yz695fy8hm0N9DvS@nvidia.com> (raw)
In-Reply-To: <20221005160356.52d6428c.alex.williamson@redhat.com>
On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote:
> We can't have a .remove callback that does nothing, this breaks
> removing the device while it's in use. Once we have the
> vfio_unregister_group_dev() fix below, we'll block until the device is
> unused, at which point vgpu->attached becomes false. Unless I'm
> missing something, I think we should also follow-up with a patch to
> remove that bogus warn-on branch, right? Thanks,
Yes, looks right to me.
I question all the logical arround attached, where is the locking?
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Christoph Hellwig <hch@lst.de>,
stable@vger.kernel.org, Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call
Date: Thu, 6 Oct 2022 08:37:09 -0300 [thread overview]
Message-ID: <Yz695fy8hm0N9DvS@nvidia.com> (raw)
In-Reply-To: <20221005160356.52d6428c.alex.williamson@redhat.com>
On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote:
> We can't have a .remove callback that does nothing, this breaks
> removing the device while it's in use. Once we have the
> vfio_unregister_group_dev() fix below, we'll block until the device is
> unused, at which point vgpu->attached becomes false. Unless I'm
> missing something, I think we should also follow-up with a patch to
> remove that bogus warn-on branch, right? Thanks,
Yes, looks right to me.
I question all the logical arround attached, where is the locking?
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
stable@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org,
Christoph Hellwig <hch@lst.de>, Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call
Date: Thu, 6 Oct 2022 08:37:09 -0300 [thread overview]
Message-ID: <Yz695fy8hm0N9DvS@nvidia.com> (raw)
In-Reply-To: <20221005160356.52d6428c.alex.williamson@redhat.com>
On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote:
> We can't have a .remove callback that does nothing, this breaks
> removing the device while it's in use. Once we have the
> vfio_unregister_group_dev() fix below, we'll block until the device is
> unused, at which point vgpu->attached becomes false. Unless I'm
> missing something, I think we should also follow-up with a patch to
> remove that bogus warn-on branch, right? Thanks,
Yes, looks right to me.
I question all the logical arround attached, where is the locking?
Jason
next prev parent reply other threads:[~2022-10-06 11:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 17:48 [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call Jason Gunthorpe
2022-09-29 17:48 ` Jason Gunthorpe
2022-09-29 17:48 ` Jason Gunthorpe
2022-09-29 20:04 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2022-09-30 1:47 ` [Intel-gfx] [PATCH] " Tian, Kevin
2022-09-30 1:47 ` Tian, Kevin
2022-09-30 1:47 ` Tian, Kevin
2022-09-30 6:46 ` [Intel-gfx] " Christoph Hellwig
2022-09-30 6:46 ` Christoph Hellwig
2022-09-30 21:31 ` [Intel-gfx] " Alex Williamson
2022-09-30 21:31 ` Alex Williamson
2022-09-30 21:31 ` Alex Williamson
2022-10-05 20:17 ` [Intel-gfx] " Alex Williamson
2022-10-05 20:17 ` Alex Williamson
2022-10-05 20:17 ` Alex Williamson
2022-10-05 22:03 ` [Intel-gfx] " Alex Williamson
2022-10-05 22:03 ` Alex Williamson
2022-10-05 22:03 ` Alex Williamson
2022-10-06 11:37 ` Jason Gunthorpe [this message]
2022-10-06 11:37 ` Jason Gunthorpe
2022-10-06 11:37 ` Jason Gunthorpe
2022-10-06 18:31 ` [Intel-gfx] " Alex Williamson
2022-10-06 18:31 ` Alex Williamson
2022-10-06 18:31 ` Alex Williamson
2022-10-10 23:14 ` [Intel-gfx] " Tian, Kevin
2022-10-10 23:14 ` Tian, Kevin
2022-10-10 23:14 ` Tian, Kevin
2022-10-19 9:40 ` [Intel-gfx] " Wang, Zhi A
2022-10-19 9:40 ` Wang, Zhi A
2022-10-19 9:40 ` Wang, Zhi A
2022-10-19 10:13 ` [Intel-gfx] " Tian, Kevin
2022-10-19 10:13 ` Tian, Kevin
2022-10-19 10:13 ` Tian, Kevin
2022-10-06 11:35 ` [Intel-gfx] " Jason Gunthorpe
2022-10-06 11:35 ` Jason Gunthorpe
2022-10-06 11:35 ` Jason Gunthorpe
2022-10-05 21:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Add missing vfio_unregister_group_dev() call (rev2) Patchwork
2022-10-05 21:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz695fy8hm0N9DvS@nvidia.com \
--to=jgg@nvidia.com \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.