From: Daniel Thompson <daniel.thompson@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API
Date: Thu, 6 Oct 2022 11:04:59 +0100 [thread overview]
Message-ID: <Yz6oS/zdNIOEtWxI@maple.lan> (raw)
In-Reply-To: <CACRpkdYecQPUd-evVpOpMLY1XUa87kP4i+E694QfTtDbEarJfQ@mail.gmail.com>
On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote:
> On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>
> > > Dmitry, could you fix this? Just patch away in gpiolib-of.c.
> >
> > Sure, I'll add a few quirks. I wonder what is the best way to merge
> > this? I can create a bunch of IBs to be pulled, or I can send quirks to
> > you/Bartosz and once they land send the patches to drivers...
>
> When I did it I was sufficiently convinced that I was the only one patching
> the quirks in gpiolib-of.c that merge window so I just included it as
> a hunk in the driver patch. If there will be some more patches to that
> file I guess some separate patch(es) for gpiolib-of.c is needed, maybe
> an immutable branch for those if it becomes a lot.
Are renames likely to be a common quirk on the road to libgpiod
conversion?
I admit I sort of expected it to be common enough that there would be
one rename quirk in the code supported by an alphabetized string table.
Such a table would certainly still provoke troublesome merges but ones
that are trivially resolved.
Daniel.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API
Date: Thu, 6 Oct 2022 11:04:59 +0100 [thread overview]
Message-ID: <Yz6oS/zdNIOEtWxI@maple.lan> (raw)
In-Reply-To: <CACRpkdYecQPUd-evVpOpMLY1XUa87kP4i+E694QfTtDbEarJfQ@mail.gmail.com>
On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote:
> On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>
> > > Dmitry, could you fix this? Just patch away in gpiolib-of.c.
> >
> > Sure, I'll add a few quirks. I wonder what is the best way to merge
> > this? I can create a bunch of IBs to be pulled, or I can send quirks to
> > you/Bartosz and once they land send the patches to drivers...
>
> When I did it I was sufficiently convinced that I was the only one patching
> the quirks in gpiolib-of.c that merge window so I just included it as
> a hunk in the driver patch. If there will be some more patches to that
> file I guess some separate patch(es) for gpiolib-of.c is needed, maybe
> an immutable branch for those if it becomes a lot.
Are renames likely to be a common quirk on the road to libgpiod
conversion?
I admit I sort of expected it to be common enough that there would be
one rename quirk in the code supported by an alphabetized string table.
Such a table would certainly still provoke troublesome merges but ones
that are trivially resolved.
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API
Date: Thu, 6 Oct 2022 11:04:59 +0100 [thread overview]
Message-ID: <Yz6oS/zdNIOEtWxI@maple.lan> (raw)
In-Reply-To: <CACRpkdYecQPUd-evVpOpMLY1XUa87kP4i+E694QfTtDbEarJfQ@mail.gmail.com>
On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote:
> On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>
> > > Dmitry, could you fix this? Just patch away in gpiolib-of.c.
> >
> > Sure, I'll add a few quirks. I wonder what is the best way to merge
> > this? I can create a bunch of IBs to be pulled, or I can send quirks to
> > you/Bartosz and once they land send the patches to drivers...
>
> When I did it I was sufficiently convinced that I was the only one patching
> the quirks in gpiolib-of.c that merge window so I just included it as
> a hunk in the driver patch. If there will be some more patches to that
> file I guess some separate patch(es) for gpiolib-of.c is needed, maybe
> an immutable branch for those if it becomes a lot.
Are renames likely to be a common quirk on the road to libgpiod
conversion?
I admit I sort of expected it to be common enough that there would be
one rename quirk in the code supported by an alphabetized string table.
Such a table would certainly still provoke troublesome merges but ones
that are trivially resolved.
Daniel.
next prev parent reply other threads:[~2022-10-06 10:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 22:32 [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API Dmitry Torokhov
2022-09-27 22:32 ` Dmitry Torokhov
2022-09-27 22:32 ` Dmitry Torokhov
2022-09-28 11:00 ` Daniel Thompson
2022-09-28 11:00 ` Daniel Thompson
2022-09-28 11:00 ` Daniel Thompson
2022-09-28 18:33 ` Dmitry Torokhov
2022-09-28 18:33 ` Dmitry Torokhov
2022-09-28 18:33 ` Dmitry Torokhov
2022-10-03 13:32 ` Daniel Thompson
2022-10-03 13:32 ` Daniel Thompson
2022-10-03 13:32 ` Daniel Thompson
2022-10-04 9:02 ` Linus Walleij
2022-10-04 9:02 ` Linus Walleij
2022-10-04 9:02 ` Linus Walleij
2022-10-04 12:54 ` Daniel Thompson
2022-10-04 12:54 ` Daniel Thompson
2022-10-04 12:54 ` Daniel Thompson
2022-10-04 19:50 ` Linus Walleij
2022-10-04 19:50 ` Linus Walleij
2022-10-04 19:50 ` Linus Walleij
2022-10-04 20:35 ` Dmitry Torokhov
2022-10-04 20:35 ` Dmitry Torokhov
2022-10-04 20:35 ` Dmitry Torokhov
2022-10-06 9:03 ` Linus Walleij
2022-10-06 9:03 ` Linus Walleij
2022-10-06 9:03 ` Linus Walleij
2022-10-06 10:04 ` Daniel Thompson [this message]
2022-10-06 10:04 ` Daniel Thompson
2022-10-06 10:04 ` Daniel Thompson
2022-10-10 20:36 ` Linus Walleij
2022-10-10 20:36 ` Linus Walleij
2022-10-10 20:36 ` Linus Walleij
2022-10-12 20:34 ` Dmitry Torokhov
2022-10-12 20:34 ` Dmitry Torokhov
2022-10-12 20:34 ` Dmitry Torokhov
2022-10-13 12:43 ` Daniel Thompson
2022-10-13 12:43 ` Daniel Thompson
2022-10-13 12:43 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz6oS/zdNIOEtWxI@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.