All of lore.kernel.org
 help / color / mirror / Atom feed
* [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
@ 2024-12-11 11:41 Marek Marczykowski-Górecki
  2024-12-11 11:53 ` Jürgen Groß
  0 siblings, 1 reply; 10+ messages in thread
From: Marek Marczykowski-Górecki @ 2024-12-11 11:41 UTC (permalink / raw)
  To: xen-devel
  Cc: Juergen Gross, Stefano Stabellini, Oleksandr Tyshchenko,
	regressions

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

Hi,

With Linux 6.6.64 I get the following crash on domU boot:

(XEN) d5v0 Triple fault - invoking HVM shutdown action 1
(XEN) *** Dumping Dom5 vcpu#0 state: ***
(XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
(XEN) CPU:    4
(XEN) RIP:    0008:[<ffffffff82b64050>]
(XEN) RFLAGS: 0000000000010086   CONTEXT: hvm guest (d5v0)
(XEN) rax: ffffffff82b64050   rbx: ffffffffffe00000   rcx: 00000000c0000101
(XEN) rdx: 0000000000000000   rsi: 0000000003a00038   rdi: 0000000002a9bc98
(XEN) rbp: 0000000000000000   rsp: 0000000002aa0ce8   r8:  0000000000000000
(XEN) r9:  0000000000000000   r10: 0000000000000000   r11: 0000000000000000
(XEN) r12: 0000000000000000   r13: 0000000000000000   r14: 0000000000000000
(XEN) r15: 0000000000000000   cr0: 0000000080000011   cr4: 0000000000000020
(XEN) cr3: 0000000002022000   cr2: 0000000000000000
(XEN) fsb: 0000000000000000   gsb: 0000000002a9ccc0   gss: 0000000000000000
(XEN) ds: 0010   es: 0010   fs: 0000   gs: 0000   ss: 0010   cs: 0008

Linux 6.6.63 works fine.

Looking at the changes, I suspect one of those:

    83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
    f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()

But I haven't tested this hypothesis yet.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
  2024-12-11 11:41 [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU Marek Marczykowski-Górecki
@ 2024-12-11 11:53 ` Jürgen Groß
  2024-12-11 12:24   ` Ard Biesheuvel
  0 siblings, 1 reply; 10+ messages in thread
From: Jürgen Groß @ 2024-12-11 11:53 UTC (permalink / raw)
  To: Jason Andryuk, Ard Biesheuvel
  Cc: Stefano Stabellini, Oleksandr Tyshchenko, regressions, xen-devel,
	Marek Marczykowski-Górecki


[-- Attachment #1.1.1: Type: text/plain, Size: 1501 bytes --]

Jason, Ard,

I guess there are some prereq patches missing in stable 6.6.y branch?


Juergen

On 11.12.24 12:41, Marek Marczykowski-Górecki wrote:
> Hi,
> 
> With Linux 6.6.64 I get the following crash on domU boot:
> 
> (XEN) d5v0 Triple fault - invoking HVM shutdown action 1
> (XEN) *** Dumping Dom5 vcpu#0 state: ***
> (XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
> (XEN) CPU:    4
> (XEN) RIP:    0008:[<ffffffff82b64050>]
> (XEN) RFLAGS: 0000000000010086   CONTEXT: hvm guest (d5v0)
> (XEN) rax: ffffffff82b64050   rbx: ffffffffffe00000   rcx: 00000000c0000101
> (XEN) rdx: 0000000000000000   rsi: 0000000003a00038   rdi: 0000000002a9bc98
> (XEN) rbp: 0000000000000000   rsp: 0000000002aa0ce8   r8:  0000000000000000
> (XEN) r9:  0000000000000000   r10: 0000000000000000   r11: 0000000000000000
> (XEN) r12: 0000000000000000   r13: 0000000000000000   r14: 0000000000000000
> (XEN) r15: 0000000000000000   cr0: 0000000080000011   cr4: 0000000000000020
> (XEN) cr3: 0000000002022000   cr2: 0000000000000000
> (XEN) fsb: 0000000000000000   gsb: 0000000002a9ccc0   gss: 0000000000000000
> (XEN) ds: 0010   es: 0010   fs: 0000   gs: 0000   ss: 0010   cs: 0008
> 
> Linux 6.6.63 works fine.
> 
> Looking at the changes, I suspect one of those:
> 
>      83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
>      f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()
> 
> But I haven't tested this hypothesis yet.
> 


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
  2024-12-11 11:53 ` Jürgen Groß
@ 2024-12-11 12:24   ` Ard Biesheuvel
  2024-12-11 12:30     ` Marek Marczykowski-Górecki
  0 siblings, 1 reply; 10+ messages in thread
From: Ard Biesheuvel @ 2024-12-11 12:24 UTC (permalink / raw)
  To: Jürgen Groß
  Cc: Jason Andryuk, Stefano Stabellini, Oleksandr Tyshchenko,
	regressions, xen-devel, Marek Marczykowski-Górecki

On Wed, 11 Dec 2024 at 12:53, Jürgen Groß <jgross@suse.com> wrote:
>
> Jason, Ard,
>
> I guess there are some prereq patches missing in stable 6.6.y branch?
>
>
> Juergen
>
> On 11.12.24 12:41, Marek Marczykowski-Górecki wrote:
> > Hi,
> >
> > With Linux 6.6.64 I get the following crash on domU boot:
> >
> > (XEN) d5v0 Triple fault - invoking HVM shutdown action 1
> > (XEN) *** Dumping Dom5 vcpu#0 state: ***
> > (XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
> > (XEN) CPU:    4
> > (XEN) RIP:    0008:[<ffffffff82b64050>]
> > (XEN) RFLAGS: 0000000000010086   CONTEXT: hvm guest (d5v0)
> > (XEN) rax: ffffffff82b64050   rbx: ffffffffffe00000   rcx: 00000000c0000101
> > (XEN) rdx: 0000000000000000   rsi: 0000000003a00038   rdi: 0000000002a9bc98
> > (XEN) rbp: 0000000000000000   rsp: 0000000002aa0ce8   r8:  0000000000000000
> > (XEN) r9:  0000000000000000   r10: 0000000000000000   r11: 0000000000000000
> > (XEN) r12: 0000000000000000   r13: 0000000000000000   r14: 0000000000000000
> > (XEN) r15: 0000000000000000   cr0: 0000000080000011   cr4: 0000000000000020
> > (XEN) cr3: 0000000002022000   cr2: 0000000000000000
> > (XEN) fsb: 0000000000000000   gsb: 0000000002a9ccc0   gss: 0000000000000000
> > (XEN) ds: 0010   es: 0010   fs: 0000   gs: 0000   ss: 0010   cs: 0008
> >
> > Linux 6.6.63 works fine.
> >
> > Looking at the changes, I suspect one of those:
> >
> >      83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
> >      f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()
> >

The second patch shouldn't have been backported. It is unnecessary,
given that in the old situation, the kernel image needs to be loaded
at a fixed address. And it assumes  that %rbp is set to the physical
load offset, but those patches were not backported.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
  2024-12-11 12:24   ` Ard Biesheuvel
@ 2024-12-11 12:30     ` Marek Marczykowski-Górecki
  2024-12-11 12:37       ` Ard Biesheuvel
  0 siblings, 1 reply; 10+ messages in thread
From: Marek Marczykowski-Górecki @ 2024-12-11 12:30 UTC (permalink / raw)
  To: Ard Biesheuvel
  Cc: Jürgen Groß, Jason Andryuk, Stefano Stabellini,
	Oleksandr Tyshchenko, regressions, xen-devel

[-- Attachment #1: Type: text/plain, Size: 2313 bytes --]

On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote:
> On Wed, 11 Dec 2024 at 12:53, Jürgen Groß <jgross@suse.com> wrote:
> >
> > Jason, Ard,
> >
> > I guess there are some prereq patches missing in stable 6.6.y branch?
> >
> >
> > Juergen
> >
> > On 11.12.24 12:41, Marek Marczykowski-Górecki wrote:
> > > Hi,
> > >
> > > With Linux 6.6.64 I get the following crash on domU boot:
> > >
> > > (XEN) d5v0 Triple fault - invoking HVM shutdown action 1
> > > (XEN) *** Dumping Dom5 vcpu#0 state: ***
> > > (XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
> > > (XEN) CPU:    4
> > > (XEN) RIP:    0008:[<ffffffff82b64050>]
> > > (XEN) RFLAGS: 0000000000010086   CONTEXT: hvm guest (d5v0)
> > > (XEN) rax: ffffffff82b64050   rbx: ffffffffffe00000   rcx: 00000000c0000101
> > > (XEN) rdx: 0000000000000000   rsi: 0000000003a00038   rdi: 0000000002a9bc98
> > > (XEN) rbp: 0000000000000000   rsp: 0000000002aa0ce8   r8:  0000000000000000
> > > (XEN) r9:  0000000000000000   r10: 0000000000000000   r11: 0000000000000000
> > > (XEN) r12: 0000000000000000   r13: 0000000000000000   r14: 0000000000000000
> > > (XEN) r15: 0000000000000000   cr0: 0000000080000011   cr4: 0000000000000020
> > > (XEN) cr3: 0000000002022000   cr2: 0000000000000000
> > > (XEN) fsb: 0000000000000000   gsb: 0000000002a9ccc0   gss: 0000000000000000
> > > (XEN) ds: 0010   es: 0010   fs: 0000   gs: 0000   ss: 0010   cs: 0008
> > >
> > > Linux 6.6.63 works fine.
> > >
> > > Looking at the changes, I suspect one of those:
> > >
> > >      83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
> > >      f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()
> > >
> 
> The second patch shouldn't have been backported. It is unnecessary,
> given that in the old situation, the kernel image needs to be loaded
> at a fixed address. And it assumes  that %rbp is set to the physical
> load offset, but those patches were not backported.

It has this tag:

    Stable-dep-of: e8fbc0d9cab6 ("x86/pvh: Call C code via the kernel virtual mapping")

Does it mean neither of them should be backported?

But then, the e8fbc0d9cab6 has "Fixes:" tag (pointing at very old
commit).

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
  2024-12-11 12:30     ` Marek Marczykowski-Górecki
@ 2024-12-11 12:37       ` Ard Biesheuvel
  2024-12-11 13:39         ` Marek Marczykowski-Górecki
  0 siblings, 1 reply; 10+ messages in thread
From: Ard Biesheuvel @ 2024-12-11 12:37 UTC (permalink / raw)
  To: Marek Marczykowski-Górecki, Greg Kroah-Hartman
  Cc: Jürgen Groß, Jason Andryuk, Stefano Stabellini,
	Oleksandr Tyshchenko, regressions, xen-devel

(cc Greg)

On Wed, 11 Dec 2024 at 13:30, Marek Marczykowski-Górecki
<marmarek@invisiblethingslab.com> wrote:
>
> On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote:
> > On Wed, 11 Dec 2024 at 12:53, Jürgen Groß <jgross@suse.com> wrote:
> > >
> > > Jason, Ard,
> > >
> > > I guess there are some prereq patches missing in stable 6.6.y branch?
> > >
> > >
> > > Juergen
> > >
> > > On 11.12.24 12:41, Marek Marczykowski-Górecki wrote:
> > > > Hi,
> > > >
> > > > With Linux 6.6.64 I get the following crash on domU boot:
> > > >
> > > > (XEN) d5v0 Triple fault - invoking HVM shutdown action 1
> > > > (XEN) *** Dumping Dom5 vcpu#0 state: ***
> > > > (XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
...
> > > >
> > > > Linux 6.6.63 works fine.
> > > >
> > > > Looking at the changes, I suspect one of those:
> > > >
> > > >      83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
> > > >      f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()
> > > >
> >
> > The second patch shouldn't have been backported. It is unnecessary,
> > given that in the old situation, the kernel image needs to be loaded
> > at a fixed address. And it assumes  that %rbp is set to the physical
> > load offset, but those patches were not backported.
>
> It has this tag:
>
>     Stable-dep-of: e8fbc0d9cab6 ("x86/pvh: Call C code via the kernel virtual mapping")
>

That was added by the stable maintainers - someone grabbed a patch
from the middle of an unrelated series to make e8fbc0d9cab6 apply
without lexical conflicts.

> Does it mean neither of them should be backported?
>
> But then, the e8fbc0d9cab6 has "Fixes:" tag (pointing at very old
> commit).
>

If someone thinks e8fbc0d9cab6 should be backported, they should
rebase it onto v6.6.y, not backport random other patches until
git-apply stops complaining. And ideally, someone would build and boot
the result to check whether it works.

For now, it would be better to revert both.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
  2024-12-11 12:37       ` Ard Biesheuvel
@ 2024-12-11 13:39         ` Marek Marczykowski-Górecki
  2024-12-11 13:46           ` Greg Kroah-Hartman
  0 siblings, 1 reply; 10+ messages in thread
From: Marek Marczykowski-Górecki @ 2024-12-11 13:39 UTC (permalink / raw)
  To: Ard Biesheuvel
  Cc: Greg Kroah-Hartman, Jürgen Groß, Jason Andryuk,
	Stefano Stabellini, Oleksandr Tyshchenko, regressions, xen-devel

[-- Attachment #1: Type: text/plain, Size: 2362 bytes --]

On Wed, Dec 11, 2024 at 01:37:52PM +0100, Ard Biesheuvel wrote:
> (cc Greg)
> 
> On Wed, 11 Dec 2024 at 13:30, Marek Marczykowski-Górecki
> <marmarek@invisiblethingslab.com> wrote:
> >
> > On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote:
> > > On Wed, 11 Dec 2024 at 12:53, Jürgen Groß <jgross@suse.com> wrote:
> > > >
> > > > Jason, Ard,
> > > >
> > > > I guess there are some prereq patches missing in stable 6.6.y branch?
> > > >
> > > >
> > > > Juergen
> > > >
> > > > On 11.12.24 12:41, Marek Marczykowski-Górecki wrote:
> > > > > Hi,
> > > > >
> > > > > With Linux 6.6.64 I get the following crash on domU boot:
> > > > >
> > > > > (XEN) d5v0 Triple fault - invoking HVM shutdown action 1
> > > > > (XEN) *** Dumping Dom5 vcpu#0 state: ***
> > > > > (XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
> ...
> > > > >
> > > > > Linux 6.6.63 works fine.
> > > > >
> > > > > Looking at the changes, I suspect one of those:
> > > > >
> > > > >      83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
> > > > >      f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()
> > > > >
> > >
> > > The second patch shouldn't have been backported. It is unnecessary,
> > > given that in the old situation, the kernel image needs to be loaded
> > > at a fixed address. And it assumes  that %rbp is set to the physical
> > > load offset, but those patches were not backported.
> >
> > It has this tag:
> >
> >     Stable-dep-of: e8fbc0d9cab6 ("x86/pvh: Call C code via the kernel virtual mapping")
> >
> 
> That was added by the stable maintainers - someone grabbed a patch
> from the middle of an unrelated series to make e8fbc0d9cab6 apply
> without lexical conflicts.
> 
> > Does it mean neither of them should be backported?
> >
> > But then, the e8fbc0d9cab6 has "Fixes:" tag (pointing at very old
> > commit).
> >
> 
> If someone thinks e8fbc0d9cab6 should be backported, they should
> rebase it onto v6.6.y, not backport random other patches until
> git-apply stops complaining. And ideally, someone would build and boot
> the result to check whether it works.
> 
> For now, it would be better to revert both.

I can confirm that reverting both commits fixes the issue.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
  2024-12-11 13:39         ` Marek Marczykowski-Górecki
@ 2024-12-11 13:46           ` Greg Kroah-Hartman
  2024-12-11 15:10             ` Ard Biesheuvel
  0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-11 13:46 UTC (permalink / raw)
  To: Marek Marczykowski-Górecki
  Cc: Ard Biesheuvel, Jürgen Groß, Jason Andryuk,
	Stefano Stabellini, Oleksandr Tyshchenko, regressions, xen-devel

On Wed, Dec 11, 2024 at 02:39:33PM +0100, Marek Marczykowski-Górecki wrote:
> On Wed, Dec 11, 2024 at 01:37:52PM +0100, Ard Biesheuvel wrote:
> > (cc Greg)
> > 
> > On Wed, 11 Dec 2024 at 13:30, Marek Marczykowski-Górecki
> > <marmarek@invisiblethingslab.com> wrote:
> > >
> > > On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote:
> > > > On Wed, 11 Dec 2024 at 12:53, Jürgen Groß <jgross@suse.com> wrote:
> > > > >
> > > > > Jason, Ard,
> > > > >
> > > > > I guess there are some prereq patches missing in stable 6.6.y branch?
> > > > >
> > > > >
> > > > > Juergen
> > > > >
> > > > > On 11.12.24 12:41, Marek Marczykowski-Górecki wrote:
> > > > > > Hi,
> > > > > >
> > > > > > With Linux 6.6.64 I get the following crash on domU boot:
> > > > > >
> > > > > > (XEN) d5v0 Triple fault - invoking HVM shutdown action 1
> > > > > > (XEN) *** Dumping Dom5 vcpu#0 state: ***
> > > > > > (XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
> > ...
> > > > > >
> > > > > > Linux 6.6.63 works fine.
> > > > > >
> > > > > > Looking at the changes, I suspect one of those:
> > > > > >
> > > > > >      83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
> > > > > >      f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()
> > > > > >
> > > >
> > > > The second patch shouldn't have been backported. It is unnecessary,
> > > > given that in the old situation, the kernel image needs to be loaded
> > > > at a fixed address. And it assumes  that %rbp is set to the physical
> > > > load offset, but those patches were not backported.
> > >
> > > It has this tag:
> > >
> > >     Stable-dep-of: e8fbc0d9cab6 ("x86/pvh: Call C code via the kernel virtual mapping")
> > >
> > 
> > That was added by the stable maintainers - someone grabbed a patch
> > from the middle of an unrelated series to make e8fbc0d9cab6 apply
> > without lexical conflicts.
> > 
> > > Does it mean neither of them should be backported?
> > >
> > > But then, the e8fbc0d9cab6 has "Fixes:" tag (pointing at very old
> > > commit).
> > >
> > 
> > If someone thinks e8fbc0d9cab6 should be backported, they should
> > rebase it onto v6.6.y, not backport random other patches until
> > git-apply stops complaining. And ideally, someone would build and boot
> > the result to check whether it works.
> > 
> > For now, it would be better to revert both.
> 
> I can confirm that reverting both commits fixes the issue.

Ok, thanks, let me go rip all of these out and do a new release now to
fix the issue.  Sorry about that, and thanks so much for the testing and
letting us know!

greg k-h

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
  2024-12-11 13:46           ` Greg Kroah-Hartman
@ 2024-12-11 15:10             ` Ard Biesheuvel
  2024-12-11 15:22               ` Greg Kroah-Hartman
  2024-12-11 23:21               ` Christian Heusel
  0 siblings, 2 replies; 10+ messages in thread
From: Ard Biesheuvel @ 2024-12-11 15:10 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Marek Marczykowski-Górecki, Jürgen Groß,
	Jason Andryuk, Stefano Stabellini, Oleksandr Tyshchenko,
	regressions, xen-devel

On Wed, 11 Dec 2024 at 14:46, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Dec 11, 2024 at 02:39:33PM +0100, Marek Marczykowski-Górecki wrote:
> > On Wed, Dec 11, 2024 at 01:37:52PM +0100, Ard Biesheuvel wrote:
> > > (cc Greg)
> > >
> > > On Wed, 11 Dec 2024 at 13:30, Marek Marczykowski-Górecki
> > > <marmarek@invisiblethingslab.com> wrote:
> > > >
> > > > On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote:
> > > > > On Wed, 11 Dec 2024 at 12:53, Jürgen Groß <jgross@suse.com> wrote:
> > > > > >
> > > > > > Jason, Ard,
> > > > > >
> > > > > > I guess there are some prereq patches missing in stable 6.6.y branch?
> > > > > >
> > > > > >
> > > > > > Juergen
> > > > > >
> > > > > > On 11.12.24 12:41, Marek Marczykowski-Górecki wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > With Linux 6.6.64 I get the following crash on domU boot:
> > > > > > >
> > > > > > > (XEN) d5v0 Triple fault - invoking HVM shutdown action 1
> > > > > > > (XEN) *** Dumping Dom5 vcpu#0 state: ***
> > > > > > > (XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
> > > ...
> > > > > > >
> > > > > > > Linux 6.6.63 works fine.
> > > > > > >
> > > > > > > Looking at the changes, I suspect one of those:
> > > > > > >
> > > > > > >      83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
> > > > > > >      f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()
> > > > > > >
> > > > >
> > > > > The second patch shouldn't have been backported. It is unnecessary,
> > > > > given that in the old situation, the kernel image needs to be loaded
> > > > > at a fixed address. And it assumes  that %rbp is set to the physical
> > > > > load offset, but those patches were not backported.
> > > >
> > > > It has this tag:
> > > >
> > > >     Stable-dep-of: e8fbc0d9cab6 ("x86/pvh: Call C code via the kernel virtual mapping")
> > > >
> > >
> > > That was added by the stable maintainers - someone grabbed a patch
> > > from the middle of an unrelated series to make e8fbc0d9cab6 apply
> > > without lexical conflicts.
> > >
> > > > Does it mean neither of them should be backported?
> > > >
> > > > But then, the e8fbc0d9cab6 has "Fixes:" tag (pointing at very old
> > > > commit).
> > > >
> > >
> > > If someone thinks e8fbc0d9cab6 should be backported, they should
> > > rebase it onto v6.6.y, not backport random other patches until
> > > git-apply stops complaining. And ideally, someone would build and boot
> > > the result to check whether it works.
> > >
> > > For now, it would be better to revert both.
> >
> > I can confirm that reverting both commits fixes the issue.
>
> Ok, thanks, let me go rip all of these out and do a new release now to
> fix the issue.  Sorry about that, and thanks so much for the testing and
> letting us know!
>

I guess 6.11 is beyond repair?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
  2024-12-11 15:10             ` Ard Biesheuvel
@ 2024-12-11 15:22               ` Greg Kroah-Hartman
  2024-12-11 23:21               ` Christian Heusel
  1 sibling, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-11 15:22 UTC (permalink / raw)
  To: Ard Biesheuvel
  Cc: Marek Marczykowski-Górecki, Jürgen Groß,
	Jason Andryuk, Stefano Stabellini, Oleksandr Tyshchenko,
	regressions, xen-devel

On Wed, Dec 11, 2024 at 04:10:11PM +0100, Ard Biesheuvel wrote:
> On Wed, 11 Dec 2024 at 14:46, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Dec 11, 2024 at 02:39:33PM +0100, Marek Marczykowski-Górecki wrote:
> > > On Wed, Dec 11, 2024 at 01:37:52PM +0100, Ard Biesheuvel wrote:
> > > > (cc Greg)
> > > >
> > > > On Wed, 11 Dec 2024 at 13:30, Marek Marczykowski-Górecki
> > > > <marmarek@invisiblethingslab.com> wrote:
> > > > >
> > > > > On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote:
> > > > > > On Wed, 11 Dec 2024 at 12:53, Jürgen Groß <jgross@suse.com> wrote:
> > > > > > >
> > > > > > > Jason, Ard,
> > > > > > >
> > > > > > > I guess there are some prereq patches missing in stable 6.6.y branch?
> > > > > > >
> > > > > > >
> > > > > > > Juergen
> > > > > > >
> > > > > > > On 11.12.24 12:41, Marek Marczykowski-Górecki wrote:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > With Linux 6.6.64 I get the following crash on domU boot:
> > > > > > > >
> > > > > > > > (XEN) d5v0 Triple fault - invoking HVM shutdown action 1
> > > > > > > > (XEN) *** Dumping Dom5 vcpu#0 state: ***
> > > > > > > > (XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
> > > > ...
> > > > > > > >
> > > > > > > > Linux 6.6.63 works fine.
> > > > > > > >
> > > > > > > > Looking at the changes, I suspect one of those:
> > > > > > > >
> > > > > > > >      83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
> > > > > > > >      f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()
> > > > > > > >
> > > > > >
> > > > > > The second patch shouldn't have been backported. It is unnecessary,
> > > > > > given that in the old situation, the kernel image needs to be loaded
> > > > > > at a fixed address. And it assumes  that %rbp is set to the physical
> > > > > > load offset, but those patches were not backported.
> > > > >
> > > > > It has this tag:
> > > > >
> > > > >     Stable-dep-of: e8fbc0d9cab6 ("x86/pvh: Call C code via the kernel virtual mapping")
> > > > >
> > > >
> > > > That was added by the stable maintainers - someone grabbed a patch
> > > > from the middle of an unrelated series to make e8fbc0d9cab6 apply
> > > > without lexical conflicts.
> > > >
> > > > > Does it mean neither of them should be backported?
> > > > >
> > > > > But then, the e8fbc0d9cab6 has "Fixes:" tag (pointing at very old
> > > > > commit).
> > > > >
> > > >
> > > > If someone thinks e8fbc0d9cab6 should be backported, they should
> > > > rebase it onto v6.6.y, not backport random other patches until
> > > > git-apply stops complaining. And ideally, someone would build and boot
> > > > the result to check whether it works.
> > > >
> > > > For now, it would be better to revert both.
> > >
> > > I can confirm that reverting both commits fixes the issue.
> >
> > Ok, thanks, let me go rip all of these out and do a new release now to
> > fix the issue.  Sorry about that, and thanks so much for the testing and
> > letting us know!
> >
> 
> I guess 6.11 is beyond repair?

6.11.y is end-of-life for a week or so now, sorry.  Hopefully no one is
still using it (I did hear that Fedora is using it, so I don't know...)

greg k-h

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU
  2024-12-11 15:10             ` Ard Biesheuvel
  2024-12-11 15:22               ` Greg Kroah-Hartman
@ 2024-12-11 23:21               ` Christian Heusel
  1 sibling, 0 replies; 10+ messages in thread
From: Christian Heusel @ 2024-12-11 23:21 UTC (permalink / raw)
  To: Ard Biesheuvel
  Cc: Greg Kroah-Hartman, Marek Marczykowski-Górecki,
	Jürgen Groß, Jason Andryuk, Stefano Stabellini,
	Oleksandr Tyshchenko, regressions, xen-devel

[-- Attachment #1: Type: text/plain, Size: 3302 bytes --]

On 24/12/11 04:10PM, Ard Biesheuvel wrote:
> On Wed, 11 Dec 2024 at 14:46, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Dec 11, 2024 at 02:39:33PM +0100, Marek Marczykowski-Górecki wrote:
> > > On Wed, Dec 11, 2024 at 01:37:52PM +0100, Ard Biesheuvel wrote:
> > > > (cc Greg)
> > > >
> > > > On Wed, 11 Dec 2024 at 13:30, Marek Marczykowski-Górecki
> > > > <marmarek@invisiblethingslab.com> wrote:
> > > > >
> > > > > On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote:
> > > > > > On Wed, 11 Dec 2024 at 12:53, Jürgen Groß <jgross@suse.com> wrote:
> > > > > > >
> > > > > > > Jason, Ard,
> > > > > > >
> > > > > > > I guess there are some prereq patches missing in stable 6.6.y branch?
> > > > > > >
> > > > > > >
> > > > > > > Juergen
> > > > > > >
> > > > > > > On 11.12.24 12:41, Marek Marczykowski-Górecki wrote:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > With Linux 6.6.64 I get the following crash on domU boot:
> > > > > > > >
> > > > > > > > (XEN) d5v0 Triple fault - invoking HVM shutdown action 1
> > > > > > > > (XEN) *** Dumping Dom5 vcpu#0 state: ***
> > > > > > > > (XEN) ----[ Xen-4.19.0  x86_64  debug=n  Tainted:  M     ]----
> > > > ...
> > > > > > > >
> > > > > > > > Linux 6.6.63 works fine.
> > > > > > > >
> > > > > > > > Looking at the changes, I suspect one of those:
> > > > > > > >
> > > > > > > >      83d123e27623 x86/pvh: Call C code via the kernel virtual mapping
> > > > > > > >      f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh()
> > > > > > > >
> > > > > >
> > > > > > The second patch shouldn't have been backported. It is unnecessary,
> > > > > > given that in the old situation, the kernel image needs to be loaded
> > > > > > at a fixed address. And it assumes  that %rbp is set to the physical
> > > > > > load offset, but those patches were not backported.
> > > > >
> > > > > It has this tag:
> > > > >
> > > > >     Stable-dep-of: e8fbc0d9cab6 ("x86/pvh: Call C code via the kernel virtual mapping")
> > > > >
> > > >
> > > > That was added by the stable maintainers - someone grabbed a patch
> > > > from the middle of an unrelated series to make e8fbc0d9cab6 apply
> > > > without lexical conflicts.
> > > >
> > > > > Does it mean neither of them should be backported?
> > > > >
> > > > > But then, the e8fbc0d9cab6 has "Fixes:" tag (pointing at very old
> > > > > commit).
> > > > >
> > > >
> > > > If someone thinks e8fbc0d9cab6 should be backported, they should
> > > > rebase it onto v6.6.y, not backport random other patches until
> > > > git-apply stops complaining. And ideally, someone would build and boot
> > > > the result to check whether it works.
> > > >
> > > > For now, it would be better to revert both.
> > >
> > > I can confirm that reverting both commits fixes the issue.
> >
> > Ok, thanks, let me go rip all of these out and do a new release now to
> > fix the issue.  Sorry about that, and thanks so much for the testing and
> > letting us know!
> >
> 
> I guess 6.11 is beyond repair?
> 

Yes 6.11 is not a supported stable series anymore.

    $ curl -s https://kernel.org/releases.json | \
        jq '.releases[] | select(.version=="6.11.11") .iseol'
    -> true

Cheers,
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-12-11 23:21 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 11:41 [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU Marek Marczykowski-Górecki
2024-12-11 11:53 ` Jürgen Groß
2024-12-11 12:24   ` Ard Biesheuvel
2024-12-11 12:30     ` Marek Marczykowski-Górecki
2024-12-11 12:37       ` Ard Biesheuvel
2024-12-11 13:39         ` Marek Marczykowski-Górecki
2024-12-11 13:46           ` Greg Kroah-Hartman
2024-12-11 15:10             ` Ard Biesheuvel
2024-12-11 15:22               ` Greg Kroah-Hartman
2024-12-11 23:21               ` Christian Heusel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.