Re: [PATCH v6 3/3] riscv: dts: thead: Add mailbox node

From: Drew Fustini <dfustini@tenstorrent.com>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: drew@pdp7.com, guoren@kernel.org, wefu@redhat.com,
	jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu,
	m.szyprowski@samsung.com, samuel.holland@sifive.com,
	emil.renner.berthing@canonical.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, christophe.jaillet@wanadoo.fr
Subject: Re: [PATCH v6 3/3] riscv: dts: thead: Add mailbox node
Date: Thu, 12 Dec 2024 20:23:26 -0800	[thread overview]
Message-ID: <Z1u2vsoCmmcNm82V@x1> (raw)
In-Reply-To: <Z1uiWXWo9szbgfx9@x1>

On Thu, Dec 12, 2024 at 06:56:25PM -0800, Drew Fustini wrote:
> On Wed, Dec 11, 2024 at 02:15:01PM -0800, Drew Fustini wrote:
> > On Mon, Nov 04, 2024 at 11:07:34AM +0100, Michal Wilczynski wrote:
> > > Add mailbox device tree node. This work is based on the vendor kernel [1].
> > > 
> > > Link: https://github.com/revyos/thead-kernel.git [1]
> > > 
> > > Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> > > ---
> > >  arch/riscv/boot/dts/thead/th1520.dtsi | 16 ++++++++++++++++
> > >  1 file changed, 16 insertions(+)
> > > 
> > > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> > > index 6992060e6a54..89de5634d3d3 100644
> > > --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> > > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> > > @@ -520,6 +520,22 @@ timer7: timer@ffffc3303c {
> > >  			status = "disabled";
> > >  		};
> > >  
> > > +		mbox_910t: mailbox@ffffc38000 {
> > > +			compatible = "thead,th1520-mbox";
> > > +			reg = <0xff 0xffc38000 0x0 0x6000>,
> > > +			      <0xff 0xffc40000 0x0 0x6000>,
> > > +			      <0xff 0xffc4c000 0x0 0x2000>,
> > > +			      <0xff 0xffc54000 0x0 0x2000>;
> > > +			reg-names = "local", "remote-icu0", "remote-icu1", "remote-icu2";
> > > +			clocks = <&clk CLK_MBOX0>, <&clk CLK_MBOX1>, <&clk CLK_MBOX2>,
> > > +				 <&clk CLK_MBOX3>;
> > > +			clock-names = "clk-local", "clk-remote-icu0", "clk-remote-icu1",
> > > +				      "clk-remote-icu2";
> > > +			interrupt-parent = <&plic>;
> > > +			interrupts = <28 IRQ_TYPE_LEVEL_HIGH>;
> > > +			#mbox-cells = <1>;
> > > +		};
> > > +
> > >  		ao_gpio0: gpio@fffff41000 {
> > >  			compatible = "snps,dw-apb-gpio";
> > >  			reg = <0xff 0xfff41000 0x0 0x1000>;
> > > -- 
> > > 2.34.1
> > > 
> > 
> > Reviewed-by: Drew Fustini <dfustini@tenstorrent.com>
> > 
> > dt_binding_check and dtbs_check are clean when I apply this patch to
> > v6.13-rc1. There is trivial conflict due to the gpio node label having
> > changed. I'll resolve it when I apply the patch to thead-dt-for-next.
> 
> I've applied this patch to thead-dt-for-next [1].
> 
> Thanks,
> Drew
> 
> [1] https://github.com/pdp7/linux/commit/98064af36cbc0c216d0a2d11da5e3746a57ccce7

I forgot my SoB so it is now a new hash [1].

-Drew

[1] https://github.com/pdp7/linux/commit/c95c1362e5bcd90c45987828bbef02236d181ffd

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv